Re: Update embedded version object code

2007-01-28 Thread John Peacock
John Peacock wrote: >> use version $VERSION = qw$Revision: 1.2$[1]; >> >> What's different about cvs versions? Oh, I just remembered what the difference is: CVS versions need to go through qv() (or equivalent code) because they are incremented as subversions, not as floating point numbers (so 1.

Re: Update embedded version object code

2007-01-28 Thread John Peacock
Eric Wilhelm wrote: >> use version $VERSION => qv($Revision: 1.2$); > > I'll guess that's supposed to be qw(). No qv before import? Yes; I blame the Dayquill... ;-) > > use version $VERSION = qw$Revision: 1.2$[1]; > > What's different about cvs versions? That won't work with Perl 5.00

Re: Update embedded version object code

2007-01-28 Thread Eric Wilhelm
# from John Peacock # on Sunday 28 January 2007 10:56 am: >Eric Wilhelm wrote: >> Is the Scalar::Util dependency justified? >The patch is *removing* the dependency on Scalar::Util and *adding* > dependencies on locale and POSIX. My bad. I blame late-night diff reading. >> Taking advantage of $_

Re: Update embedded version object code

2007-01-28 Thread John Peacock
Eric Wilhelm wrote: > Is the Scalar::Util dependency justified? 'yes' is a fine answer, I'm > just not certain what it's compatibility is. The patch is *removing* the dependency on Scalar::Util and *adding* dependencies on locale and POSIX. > Taking advantage of $_[1] being an alias to $VERSION

Re: Update embedded version object code

2007-01-28 Thread Eric Wilhelm
# from John Peacock # on Saturday 27 January 2007 09:40 am: Hi John, Is the Scalar::Util dependency justified? 'yes' is a fine answer, I'm just not certain what it's compatibility is. >3) I am considering adding: > > use version $VERSION => '1.002'; > >as an alternate syntax for > >