Re: ordering output filters

2011-03-14 Thread Joshua Marantz
Thanks, Nick & Ben! On Mon, Mar 14, 2011 at 1:31 PM, Nick Kew wrote: > > AP_FTYPE_RESOURCE+1. That also leaves an admin the possibility of > overriding it. I didn't realize these +1/-1 hacks were available for this API. This looks really simple & is the direction I'm leaning. > Why not an i

Re: ordering output filters

2011-03-14 Thread Nick Kew
On 14 Mar 2011, at 15:54, Joshua Marantz wrote: > if (mod_includes was enabled in this config) { >re-insert mod_pagespeed at the end of the AP_FTYPE_RESOURCE chain >pass the buckets to mod_includes > } Not good. Modules are there to serve the server admin, not to enslave him. In gene

Re: ordering output filters

2011-03-14 Thread Ben Noordhuis
On Mon, Mar 14, 2011 at 16:54, Joshua Marantz wrote: > Even in the absence of 'remove_comments', it would be preferable to have > mod_pagespeed run after mod_includes so that it has an opportunity to > optimize the included text.  The user can achieve this by putting this line > into his config fi

ordering output filters

2011-03-14 Thread Joshua Marantz
Hello from mod_pagespeed again. Our users have identified another incompatibility between standard filters and mod_pagespeed; this time with mod_includes. In general I think that mod_pagespeed should run after mod_includes, for a few reasons. But in particular, mod_pagespeed, in its own html-ce