Re: [VOTE] flatten-maven-plugin 1.2.5

2020-08-16 Thread 'Stephanie Wang' via mojohaus-dev
t;> On Wed, Aug 12, 2020 at 6:30 PM 'Stephanie Wang' via mojohaus-dev < >> mojohaus-dev@googlegroups.com> wrote: >> >>> +1 >>> >>> thank you! >>> >>> On Wed, Aug 12, 2020 at 9:25 PM Olivier Lamy >>> wrote: >>>

Re: [VOTE] flatten-maven-plugin 1.2.5

2020-08-12 Thread 'Stephanie Wang' via mojohaus-dev
+1 thank you! On Wed, Aug 12, 2020 at 9:25 PM Olivier Lamy wrote: > Hi > I'd like to release flatten-maven-plugin 1.2.5 > Release notes: > https://github.com/mojohaus/flatten-maven-plugin/releases/tag/flatten-maven-plugin-1.2.5 > > Staging repository: >

flatten maven plugin - merge PR please?

2020-08-06 Thread 'Stephanie Wang' via mojohaus-dev
Hi, https://github.com/mojohaus/flatten-maven-plugin/pull/172 Ray Tsang and I both approved this PR. Could someone with write access to the repo merge this one in? Our intern was hoping to get this merged before he leaves Google :) Thank you and have a nice day, Stephanie -- You received

Re: [VOTE] flatten-maven-plugin 1.2.4

2020-06-22 Thread 'Stephanie Wang' via mojohaus-dev
+1 On Mon, Jun 22, 2020 at 7:14 PM Falko Modler wrote: > Hi! > > +1 (internal build with ~95 modules) > > That was quick, thanks! > > -- > You received this message because you are subscribed to the Google Groups > "mojohaus-dev" group. > To unsubscribe from this group and stop receiving emails

Re: [VOTE] Release flatten-maven-plugin 1.2.3

2020-06-15 Thread 'Stephanie Wang' via mojohaus-dev
Many thanks, Olivier. We will try it out today. On Sun, Jun 14, 2020 at 11:46 PM Olivier Lamy wrote: > Vote passed > I pushed the button. The artifacts should be available in Maven Central in > few hours > Cheers > Olivier > > On Sat, 13 Jun 2020 at 12:33, Olivier Lamy wrote: > >> Hi >> I'd

Re: release please?

2020-06-12 Thread 'Stephanie Wang' via mojohaus-dev
post-build script: >>>>>> /Users/olamy/dev/sources/open-sources/mojohaus/flatten-maven-plugin/target/it/no-overwrite-3.6.3-later/verify.groovy >>>>>> >>>>>> java.lang.NumberFormatException: For input string: "Maven" >>>>>> >

Re: release please?

2020-06-09 Thread 'Stephanie Wang' via mojohaus-dev
thank you! On Tue, Jun 9, 2020 at 7:47 PM Olivier Lamy wrote: > I can look at this now > > On Wed, 10 Jun 2020 at 07:38, 'Stephanie Wang' via mojohaus-dev < > mojohaus-dev@googlegroups.com> wrote: > >> Hi Karl -- the flatten-maven-plugin please. We're waiting on >

Re: release please?

2020-06-09 Thread 'Stephanie Wang' via mojohaus-dev
Hi Karl -- the flatten-maven-plugin please. We're waiting on https://github.com/mojohaus/flatten-maven-plugin/pull/155 to be rolled out specifically so we can continue adoption across GCP Java clients. On Tue, Jun 9, 2020 at 5:28 PM Karl Heinz Marbaise wrote: > Hi, > > can you tell about which

release please?

2020-06-09 Thread 'Stephanie Wang' via mojohaus-dev
Hi -- is it possible for us to do a release at your earliest convenience? We are waiting for a bug fix. Thanks, Stephanie -- You received this message because you are subscribed to the Google Groups "mojohaus-dev" group. To unsubscribe from this group and stop receiving emails from it, send

Re: PR review please?

2020-06-05 Thread 'Stephanie Wang' via mojohaus-dev
Thank you for merging! Any chance we can do a release soon please? On Friday, June 5, 2020 at 11:48:30 AM UTC-4 Stephanie Wang wrote: > @olivier, thanks for the initial review. We made some updates - could you > take another look? If all looks good, could we get this merged and released > at

Re: PR review please?

2020-06-05 Thread 'Stephanie Wang' via mojohaus-dev
@olivier, thanks for the initial review. We made some updates - could you take another look? If all looks good, could we get this merged and released at your earliest convenience? As we are waiting on this feature. Thank you. On Wednesday, June 3, 2020 at 4:45:31 PM UTC-4 Stephanie Wang wrote:

PR review please?

2020-06-03 Thread 'Stephanie Wang' via mojohaus-dev
Hi, Could we please have someone review https://github.com/mojohaus/flatten-maven-plugin/pull/155? We're waiting for this change to be made in the plugin to adopt it further in GCP. Thanks, Stephanie -- You received this message because you are subscribed to the Google Groups "mojohaus-dev"

Re: [VOTE] Migration from travis to GitHub Actions

2020-06-02 Thread 'Stephanie Wang' via mojohaus-dev
SGTM! On Tue, Jun 2, 2020 at 12:43 PM Karl Heinz Marbaise wrote: > Hi, > > > currently I'm working the subject to replace the travis build with GitHub > actions: > > > https://github.com/mojohaus/mojo-parent/issues/114 > > > Replace the CI tooling with GitHub actions > > * Building with

Re: no-overwrite failure

2020-06-02 Thread 'Stephanie Wang' via mojohaus-dev
Hi, could someone please review https://github.com/mojohaus/flatten-maven-plugin/pull/154? This is meant to fix the no-overwrite IT failure. Thanks, On Thursday, May 7, 2020 at 11:20:48 AM UTC-4 Stephanie Wang wrote: > Sure - will take a look. Thanks. > > On Thu, May 7, 2020 at 2:40 AM Lasse

Re: setup-customarchiver-maven-plugin failure on master when running a single IT

2020-05-13 Thread 'Stephanie Wang' via mojohaus-dev
I have been working on this with an engineer at Google, Nuoyu Yang . He discovered that this happens only if we *do not *explicitly run *setup-customarchive-maven-plugin* test first before running another IT. Below command always works without failure: `*mvn

setup-customarchiver-maven-plugin failure on master when running a single IT

2020-05-07 Thread 'Stephanie Wang' via mojohaus-dev
Hi, On the latest master branch, when we try to run any single IT in the project root by running: mvn verify -Dinvoker.test=bom-flattenMode We see the following build failure: *[ERROR] The following builds failed:* *[ERROR] * setup-customarchive-maven-plugin/pom.xml* build.log shows:

Re: no-overwrite failure

2020-05-07 Thread 'Stephanie Wang' via mojohaus-dev
Sure - will take a look. Thanks. On Thu, May 7, 2020 at 2:40 AM Lasse Lindqvist wrote: > I opened an issue about this ( > https://github.com/mojohaus/flatten-maven-plugin/issues/140) before the > latest release. The release was done anyway since it had demand. > > I was able to reproduce it in

no-overwrite failure

2020-05-06 Thread 'Stephanie Wang' via mojohaus-dev
Hi, We pulled the latest master from GitHub and tried building the project but got below failure: [INFO] Building: no-overwrite/pom.xml [INFO] run post-build script verify.groovy [INFO] The post-build script did not succeed. assert now - flattendPom.lastModified() > 20*1000 | | |

Re: [VOTE] Flatten Maven Plugin

2020-04-02 Thread 'Stephanie Wang' via mojohaus-dev
Great -- thank you! Confirming that the release artifact is available in Maven Central . Thanks again for your help! On Thu, Apr 2, 2020 at 7:51 AM Olivier Lamy wrote: > Vote passed > > +1: Stephanie,

Re: Release please?

2020-04-01 Thread 'Stephanie Wang' via mojohaus-dev
act and > confirm it's working as expected, so Olivier can publish the release in 48h > with more confidence than only his own conviction > > Le mer. 1 avr. 2020 à 00:43, 'Stephanie Wang' via mojohaus-dev < > mojoha...@googlegroups.com> a écrit : > >> Ah - understoo

Re: Release please?

2020-03-31 Thread 'Stephanie Wang' via mojohaus-dev
(I know it's weird but it's probably some > "heritage" from the past :) ) > > > On Wed, 1 Apr 2020 at 08:23, 'Stephanie Wang' via mojohaus-dev < > mojohaus-dev@googlegroups.com> wrote: > >> Looks like maven central >> <https://search.maven.org/arti

Re: Release please?

2020-03-31 Thread 'Stephanie Wang' via mojohaus-dev
Thank you for the release! On Tue, Mar 31, 2020 at 12:04 AM Olivier Lamy wrote: > > > On Tue, 31 Mar 2020 at 14:00, Lasse Lindqvist > wrote: > >> I kind of meant "I would not like to release" more than "I cannot". The >> fact is that it has a failing test, maybe it is a regression, maybe not.