Re: RE: Mojo Parent - properties

[mfriedenhagen]

Hello Stefan,

I agree the overhead is less for simple plugins but still 1 line vs 5 lines 
XML. And I think uniformity is a good thing as well. So either we use 
properties or do not for plugins. Or at least document and explain why we do 
stuff like we do it.

Best Regards 
Mirko Friedenhagen
— 
Sent from my mobile 

Am 22.05.20 um 11:48 schrieb Stefan Seifert

> in my pov defining properties for versions of complex plugins that often have 
> multiple plugins/dependencies defined in a single POM which all have to set 
> to the same version is ok.
> examples for such complex plugins are maven-release-plugin, 
> maven-surefire/failsave-plugin
> 
> for other "simple" plugins it makes no sense, and it seems that the plugins 
> listed by karl heinz fall into this latter category.
> 
> stefan
> 
> >-Original Message-
> >From: mojohaus-dev@googlegroups.com  On
> >Behalf Of mfriedenha...@gmx.de
> >Sent: Friday, May 22, 2020 11:13 AM
> >To: mojohaus-dev@googlegroups.com
> >Subject: Re: Mojo Parent - properties
> >
> >Hello Karl Heinz,
> >
> >I do not see the point, why properties are bad here.
> >Overriding them on the command line is not the main
> >benefit, but in a child project you may override
> >versions with one line of code instead of at least 5 lines.
> >Say you have problems with latest surefire/failsafe.
> >
> >Then it is
> >2.22.2
> >vs.
> >
> >
> >
> >o.a.m.p
> >maven-surefire-plugin
> >2.22.2
> >
> >
> >o.a.m.
> >maven-failsafe-plugin
> >2.22.2
> >
> >
> >
> >
> >
> >The latter are 14 lines of XML vs 1.
> >
> >Best Regards
> >Mirko Friedenhagen
> >—
> >Sent from my mobile
> >
> >Am 22.05.20 um 10:23 schrieb Karl Heinz Marbaise
> >Von: "Karl Heinz Marbaise" 
> >Datum: 22. Mai 2020
> >An: mojohaus-dev 
> >Cc:
> >Betreff: Mojo Parent - properties
> >Hi to all,
> >
> >currently we have some properties in our mojo-parent which define maven-
> >plugin versions.
> >
> >I intend to remove them with the next release of the mojo-parent (51)
> >
> >https://github.com/mojohaus/mojo-parent/issues/91
> >
> >If there are no objections I will remove them on tuesday (May 26. 2020).
> >
> >
> >If you have objects please raise your hand.
> >
> >Kind regards
> >Karl Heinz Marbaise
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "mojohaus-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to mojohaus-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/mojohaus-dev/198ed6a426394f6fb7f2a3396ac019cb%40mailx01.intern.pro-vision.de.
> 

-- 
You received this message because you are subscribed to the Google Groups 
"mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to mojohaus-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/mojohaus-dev/trinity-2fe58fb8-6941-40da-a30b-f507fc6f7c97-1590157335056%40msvc-mesg-gmx022.

RE: Mojo Parent - properties

[Stefan Seifert]

in my pov defining properties for versions of complex plugins that often have 
multiple plugins/dependencies defined in a single POM which all have to set to 
the same version is ok.
examples for such complex plugins are maven-release-plugin, 
maven-surefire/failsave-plugin

for other "simple" plugins it makes no sense, and it seems that the plugins 
listed by karl heinz fall into this latter category.

stefan

>-Original Message-
>From: mojohaus-dev@googlegroups.com  On
>Behalf Of mfriedenha...@gmx.de
>Sent: Friday, May 22, 2020 11:13 AM
>To: mojohaus-dev@googlegroups.com
>Subject: Re: Mojo Parent - properties
>
>Hello Karl Heinz,
>
>I do not see the point, why properties are bad here.
>Overriding them on the command line is not the main
>benefit, but in a child project you may override
>versions with one line of code instead of at least 5 lines.
>Say you have problems with latest surefire/failsafe.
>
>Then it is
>2.22.2
>vs.
>
>
>
>o.a.m.p
>maven-surefire-plugin
>2.22.2
>
>
>o.a.m.
>maven-failsafe-plugin
>2.22.2
>
>
>
>
>
>The latter are 14 lines of XML vs 1.
>
>Best Regards
>Mirko Friedenhagen
>—
>Sent from my mobile
>
>Am 22.05.20 um 10:23 schrieb Karl Heinz Marbaise
>Von: "Karl Heinz Marbaise" 
>Datum: 22. Mai 2020
>An: mojohaus-dev 
>Cc:
>Betreff: Mojo Parent - properties
>Hi to all,
>
>currently we have some properties in our mojo-parent which define maven-
>plugin versions.
>
>I intend to remove them with the next release of the mojo-parent (51)
>
>https://github.com/mojohaus/mojo-parent/issues/91
>
>If there are no objections I will remove them on tuesday (May 26. 2020).
>
>
>If you have objects please raise your hand.
>
>Kind regards
>Karl Heinz Marbaise

-- 
You received this message because you are subscribed to the Google Groups 
"mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to mojohaus-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/mojohaus-dev/198ed6a426394f6fb7f2a3396ac019cb%40mailx01.intern.pro-vision.de.

Re: Mojo Parent - properties

[mfriedenhagen]

Hello Karl Heinz,I do not see the point, why properties are bad here. Overriding them on the command line is not the main benefit, but in a child project you may override versions with one line of code instead of at least 5 lines.Say you have problems with latest surefire/failsafe.Then it is 2.22.2 vs.o.a.m.pmaven-surefire-plugin2.22.2o.a.m.maven-failsafe-plugin2.22.2The latter are 14 lines of XML vs 1.Best Regards Mirko Friedenhagen— Sent from my mobile Am 22.05.20 um 10:23 schrieb Karl Heinz Marbaise




Von: "Karl Heinz Marbaise" Datum: 22. Mai 2020An: mojohaus-dev Cc: Betreff: Mojo Parent - properties

Hi to all,
currently we have some properties in our mojo-parent which define maven-plugin versions.

I intend to remove them with the next release of the mojo-parent (51)


https://github.com/mojohaus/mojo-parent/issues/91


If there are no objections I will remove them on tuesday (May 26. 2020).


If you have objects please raise your hand.

Kind regards
Karl Heinz Marbaise




-- 
You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/64376aeb-418b-429c-98b1-8aae22963f13%40googlegroups.com.








-- 
You received this message because you are subscribed to the Google Groups "mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mojohaus-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mojohaus-dev/trinity-97cc9dac-bb7c-4be5-9f82-eb6ebc8705d6-1590138775041%40msvc-mesg-gmx021.

Re: release versions-maven-plugin 2.8?

[Karl Heinz Marbaise]

Hi, currently I'm working on some upgrade in the mojo-parent to get some 
plugins upgrades 
etc. afterwards I have planned to make a new release of 
versions-maven-plugin.

Kind regards
Karl Heinz Marbaise

On Friday, May 22, 2020 at 9:14:18 AM UTC+2, sseifert wrote:
>
> i'm interested in getting a new release of versions-maven-plugin 2.8 - 
> last release was 1.5 years ago, and there are currently no open issues 
> assigned to the github milestone [1] 
>
> any other open issues that should go into the release? 
> can I help to get it along? (i've currently only write access to 
> mojohaus/build-helper-maven-plugin) 
>
> stefan 
>
>
> [1] 
> https://github.com/mojohaus/versions-maven-plugin/issues?q=is%3Aissue+milestone%3A2.8.0+is%3Aclosed
>  
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to mojohaus-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/mojohaus-dev/987e8d9a-cab9-405a-9ef3-78dd51c4227c%40googlegroups.com.

Mojo Parent - properties

[Karl Heinz Marbaise]

Hi to all,

currently we have some properties in our mojo-parent which define 
maven-plugin versions.

I intend to remove them with the next release of the mojo-parent (51)

https://github.com/mojohaus/mojo-parent/issues/91

If there are no objections I will remove them on tuesday (May 26. 2020).


If you have objects please raise your hand.

Kind regards
Karl Heinz Marbaise

-- 
You received this message because you are subscribed to the Google Groups 
"mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to mojohaus-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/mojohaus-dev/64376aeb-418b-429c-98b1-8aae22963f13%40googlegroups.com.

release versions-maven-plugin 2.8?

[Stefan Seifert]

i'm interested in getting a new release of versions-maven-plugin 2.8 - last 
release was 1.5 years ago, and there are currently no open issues assigned to 
the github milestone [1]

any other open issues that should go into the release?
can I help to get it along? (i've currently only write access to 
mojohaus/build-helper-maven-plugin)

stefan


[1] 
https://github.com/mojohaus/versions-maven-plugin/issues?q=is%3Aissue+milestone%3A2.8.0+is%3Aclosed


-- 
You received this message because you are subscribed to the Google Groups 
"mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to mojohaus-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/mojohaus-dev/1222056106cb44d8a82d444b99343285%40mailx01.intern.pro-vision.de.