Re: Request for review of PRs for exec-maven-plugin
Hey Karl Heinz,
Any further insights into this issue?
Thanks,
--Gunnar
Am Freitag, 30. März 2018 21:48:19 UTC+2 schrieb Karl Heinz Marbaise:
>
> Hi Gunnar,
>
> yeah I'm already taking a look at it cause on of the IT's is failing which
> is not your fault...
>
> Kind regards
> Karl Heinz Marbaise
>
> On Friday, March 30, 2018 at 9:43:00 PM UTC+2, Gunnar Morling wrote:
>>
>> Karl Heinz,
>>
>> Thanks for your reply. Unfortunately, I can't reproduce this failure
>> locally. I run:
>>
>> mvn -Prun-its clean verify
>>
>> And all the integration tests pass:
>>
>>Passed: 20, Failed: 0, Errors: 0, Skipped: 1
>>
>> I know, "works on my machine"... . But could you check out my branch and
>> try building it, too?
>>
>> What makes me think that this isn't necessarily related to my change is
>> that e.g. this other PR also fails with the same problem:
>>
>> https://github.com/mojohaus/exec-maven-plugin/pull/97
>>
>> So maybe it's some issue specific to the CI environment?
>>
>> --Gunnar
>>
>>
>> Am Mittwoch, 28. März 2018 19:38:13 UTC+2 schrieb Karl Heinz Marbaise:
>>>
>>> Already mentioned on twitter but the CI is failing...
>>>
>>> Can you take a look at that...
>>>
>>> Kind regards
>>> Karl Heinz Marbaise
>>>
>>> On Wednesday, March 28, 2018 at 2:35:19 PM UTC+2, Gunnar Morling wrote:
Hi,
I've submitted two PRs for the exec-maven-plugin a few days ago:
* '#98 Resolving "target" dir via "${project.build.directory}' -
https://github.com/mojohaus/exec-maven-plugin/pull/99
* '#100 Supporting module path given as string' -
https://github.com/mojohaus/exec-maven-plugin/pull/100
Could anyone of the core dev team review and merge those and ideally do
a release containing these fixes?
Thanks a lot,
--Gunnar
--
You received this message because you are subscribed to the Google Groups
"mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to mojohaus-dev+unsubscr...@googlegroups.com.
To post to this group, send email to mojohaus-dev@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/mojohaus-dev/8f005c61-5734-4761-b29b-95d9917c902f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Request for review of PRs for exec-maven-plugin
Hi Gunnar,
yeah I'm already taking a look at it cause on of the IT's is failing which
is not your fault...
Kind regards
Karl Heinz Marbaise
On Friday, March 30, 2018 at 9:43:00 PM UTC+2, Gunnar Morling wrote:
>
> Karl Heinz,
>
> Thanks for your reply. Unfortunately, I can't reproduce this failure
> locally. I run:
>
> mvn -Prun-its clean verify
>
> And all the integration tests pass:
>
>Passed: 20, Failed: 0, Errors: 0, Skipped: 1
>
> I know, "works on my machine"... . But could you check out my branch and
> try building it, too?
>
> What makes me think that this isn't necessarily related to my change is
> that e.g. this other PR also fails with the same problem:
>
> https://github.com/mojohaus/exec-maven-plugin/pull/97
>
> So maybe it's some issue specific to the CI environment?
>
> --Gunnar
>
>
> Am Mittwoch, 28. März 2018 19:38:13 UTC+2 schrieb Karl Heinz Marbaise:
>>
>> Already mentioned on twitter but the CI is failing...
>>
>> Can you take a look at that...
>>
>> Kind regards
>> Karl Heinz Marbaise
>>
>> On Wednesday, March 28, 2018 at 2:35:19 PM UTC+2, Gunnar Morling wrote:
>>>
>>> Hi,
>>>
>>> I've submitted two PRs for the exec-maven-plugin a few days ago:
>>>
>>> * '#98 Resolving "target" dir via "${project.build.directory}' -
>>> https://github.com/mojohaus/exec-maven-plugin/pull/99
>>> * '#100 Supporting module path given as string' -
>>> https://github.com/mojohaus/exec-maven-plugin/pull/100
>>>
>>> Could anyone of the core dev team review and merge those and ideally do
>>> a release containing these fixes?
>>>
>>> Thanks a lot,
>>>
>>> --Gunnar
>>>
>>>
--
You received this message because you are subscribed to the Google Groups
"mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to mojohaus-dev+unsubscr...@googlegroups.com.
To post to this group, send email to mojohaus-dev@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/mojohaus-dev/cb664e83-1c5b-48a5-a28a-b267e9eb5ef8%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Request for review of PRs for exec-maven-plugin
Karl Heinz,
Thanks for your reply. Unfortunately, I can't reproduce this failure
locally. I run:
mvn -Prun-its clean verify
And all the integration tests pass:
Passed: 20, Failed: 0, Errors: 0, Skipped: 1
I know, "works on my machine"... . But could you check out my branch and
try building it, too?
What makes me think that this isn't necessarily related to my change is
that e.g. this other PR also fails with the same problem:
https://github.com/mojohaus/exec-maven-plugin/pull/97
So maybe it's some issue specific to the CI environment?
--Gunnar
Am Mittwoch, 28. März 2018 19:38:13 UTC+2 schrieb Karl Heinz Marbaise:
>
> Already mentioned on twitter but the CI is failing...
>
> Can you take a look at that...
>
> Kind regards
> Karl Heinz Marbaise
>
> On Wednesday, March 28, 2018 at 2:35:19 PM UTC+2, Gunnar Morling wrote:
>>
>> Hi,
>>
>> I've submitted two PRs for the exec-maven-plugin a few days ago:
>>
>> * '#98 Resolving "target" dir via "${project.build.directory}' -
>> https://github.com/mojohaus/exec-maven-plugin/pull/99
>> * '#100 Supporting module path given as string' -
>> https://github.com/mojohaus/exec-maven-plugin/pull/100
>>
>> Could anyone of the core dev team review and merge those and ideally do a
>> release containing these fixes?
>>
>> Thanks a lot,
>>
>> --Gunnar
>>
>>
--
You received this message because you are subscribed to the Google Groups
"mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to mojohaus-dev+unsubscr...@googlegroups.com.
To post to this group, send email to mojohaus-dev@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/mojohaus-dev/00b46c7b-70c8-4b3c-b176-07578976d231%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Request for review of PRs for exec-maven-plugin
Already mentioned on twitter but the CI is failing...
Can you take a look at that...
Kind regards
Karl Heinz Marbaise
On Wednesday, March 28, 2018 at 2:35:19 PM UTC+2, Gunnar Morling wrote:
>
> Hi,
>
> I've submitted two PRs for the exec-maven-plugin a few days ago:
>
> * '#98 Resolving "target" dir via "${project.build.directory}' -
> https://github.com/mojohaus/exec-maven-plugin/pull/99
> * '#100 Supporting module path given as string' -
> https://github.com/mojohaus/exec-maven-plugin/pull/100
>
> Could anyone of the core dev team review and merge those and ideally do a
> release containing these fixes?
>
> Thanks a lot,
>
> --Gunnar
>
>
--
You received this message because you are subscribed to the Google Groups
"mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to mojohaus-dev+unsubscr...@googlegroups.com.
To post to this group, send email to mojohaus-dev@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/mojohaus-dev/48df1c11-2122-4e0e-b971-ca98f1770a06%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Request for review of PRs for exec-maven-plugin
Hi,
I've submitted two PRs for the exec-maven-plugin a few days ago:
* '#98 Resolving "target" dir via "${project.build.directory}'
- https://github.com/mojohaus/exec-maven-plugin/pull/99
* '#100 Supporting module path given as string'
- https://github.com/mojohaus/exec-maven-plugin/pull/100
Could anyone of the core dev team review and merge those and ideally do a
release containing these fixes?
Thanks a lot,
--Gunnar
--
You received this message because you are subscribed to the Google Groups
"mojohaus-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to mojohaus-dev+unsubscr...@googlegroups.com.
To post to this group, send email to mojohaus-dev@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/mojohaus-dev/621f7942-104f-4547-bfe9-28dd062e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
