Hah, I've been too hasty. Fixed.
About patch 10, I'm wondering... Wouldn't it be safer if we just checked if
the owner is null in the CalculateAutoSize() method, in case the same
problem could occur from somewhere else? Not sure whether that's possible.
Steven Boswell II wrote
No, both were
A lot of work ahead, I see.
About patch 1... I cannot manage to run the concerned test case with Mono
master, for some reason (I get a NullReferenceException in the DataGrid
constructor). I can run it with Mono 2.10, though. Rather than a regression
(unlikely, DataGrid.cs hasn't been updated for
Rob,
if you want to go the advanced-git-route, you can always rebase your
patch on top of the current master.
This gives you a clean patch in the face of upstream changes, even in
the same area of code. On the downside, it changes the commit-hashes and
creates a break in the history of your
Can you recommend a cross-plattform media player? I'm not bound to WMP. I
mostly need to play WMV and AVI plus MP3 and WMA, but the focus is on the
video files/formats.
--
View this message in context:
Sorry, not a rush on my behalf, but i want to keep this thread alive
until it's taken care of.
Will probably go out a few hours mid day today (won't be out as much as
yesterday; today may be a lunch at the beach day-- dad bought an annual
beach parking pass and we 'have' to get the most for our
Steve's click simulation hack is in DataGridViewTest.cs. I wonder if it'd be
possible to refactor it into a helper class, so it can be reused for any
test class.
Rob Wilkens wrote
Sorry, not a rush on my behalf, but i want to keep this thread alive
until it's taken care of.
Will probably
Achim123 wrote
Can you recommend a cross-plattform media player? I'm not bound to WMP. I
mostly need to play WMV and AVI plus MP3 and WMA, but the focus is on the
video files/formats.
The best you can learn from it Banshee, built on GStreamer,
http://banshee.fm/
Note that Banshee is
Someone from Xamarin can chime in, but I think in general bugs in Novell
Bugzilla are not being actively tracked or worked on. I don't think it
hurts to close them, but there may also be some cruft in there as no one is
triaging or working on those bugs anymore.
On Sat, Jun 9, 2012 at 7:10 PM,
On Mon, Jun 18, 2012 at 10:40 AM, Jonathan Chambers jonc...@gmail.com wrote:
Someone from Xamarin can chime in, but I think in general bugs in Novell
Bugzilla are not being actively tracked or worked on. I don't think it hurts
to close them, but there may also be some cruft in there as no one
On 06/18/2012 01:40 PM, Jonathan Chambers wrote:
Someone from Xamarin can chime in, but I think in general bugs in
Novell Bugzilla are not being actively tracked or worked on. I don't
think it hurts to close them, but there may also be some cruft in
there as no one is triaging or working on
Alright, the first patch is in
(https://github.com/mono/mono/commit/42ebb31fc143a171a6a5930bc647627c557842ee).
I took the liberty to change the coding style.
Thanks.
Rob Wilkens wrote
This is for Stifu:
Please follow this sequence when applying or testing the patches listed
below. Doing
You can still submit a test later if you feel like it, and if you can find an
elegant-enough one. But considering it's a tricky part to test, I don't
require it.
Rob Wilkens wrote
Beautiful..
I was working on a unit test for this one, but i guess that is not needed
Here it is standalone
Hah, that thought did cross my mind.
Did you just wait for me to push it before saying that? :p
We could go for:
int next_pixel_offset = pixel_offset;
if (CurrentColumn
CurrentTableStyle.GridColumnStyles.Count)
{
I couldn't see it before you pushed it, and may have done it wrong
myself (I don't recall now).. :-)
I'm sure in the case where this version you wrote would result in a zero
result, the zero result is probably OK.
The version below is probably good if you're ok with it.
-Rob
On 06/18/2012
I couldn't see it before you pushed it, and may have done it wrong
myself (I don't recall now).. :-)
Well yeah, I only reformatted your patch, but didn't add in the zero, it was
there in the first place. You said it yourself, actually: It is probably
perfectly acceptable if we're beyond the
Whoops a second problem with the one you posted in the commit you
mentioned, I think if we're checking = then we want the results reversed...
-Rob
On 06/18/2012 05:06 PM, Rob Wilkens wrote:
I couldn't see it before you pushed it, and may have done it wrong
myself (I don't recall now).. :-)
No, it's fine.
Rob Wilkens wrote
Whoops a second problem with the one you posted in the commit you
mentioned, I think if we're checking = then we want the results
reversed...
-Rob
On 06/18/2012 05:06 PM, Rob Wilkens wrote:
I couldn't see it before you pushed it, and may have done it
Thanks for not blindly trusting me :-)
On 06/18/2012 05:20 PM, Stifu wrote:
No, it's fine.
Rob Wilkens wrote
Whoops a second problem with the one you posted in the commit you
mentioned, I think if we're checking = then we want the results
reversed...
-Rob
On 06/18/2012 05:06 PM, Rob
If it took me 3 tries to get such a simple patch in, I think I'd rather
resign. :)
Anyway, I'll check out the other patches another day. Is patch 2 hard to
test? I haven't looked at it yet.
Rob Wilkens wrote
Thanks for not blindly trusting me :-)
On 06/18/2012 05:20 PM, Stifu wrote:
In an automatable way, yes.
By hand, not that hard.
I can try to describe how to test it if you need.
-Rob
On 06/18/2012 05:27 PM, Stifu wrote:
If it took me 3 tries to get such a simple patch in, I think I'd rather
resign. :)
Anyway, I'll check out the other patches another day. Is patch 2
If you could just write the unit test, that should be all I need.
Rob Wilkens wrote
In an automatable way, yes.
By hand, not that hard.
I can try to describe how to test it if you need.
-Rob
On 06/18/2012 05:27 PM, Stifu wrote:
If it took me 3 tries to get such a simple patch in, I
As per the crash that it fixes, I think I can write an automatable test.
I want to test it here first which means i need to clone and build
again, shouldn't take me too long.
There was a visual error that was fixed by that patch as well, in the
same commit originally, because i noticed it while
Now that you modified patch 1, I had to modify patch 2 so it would apply
correctly, I've attached it (I'm testing just like you're testing, i'm
starting with a clean mono tree and applying the patches one by one as
you apply them or just before you would in this case)
I just deleted a section
I've attached the unit test, and tested it. It consistently fails,
though not always with the same exception, when run on unpatched
version. It seems to consistently pass with the patched version. Again
this was with patch 2 which i submitted a revised version earlier
tonight which took out a
This morning Miguel De Icaza (sp?) put through my fix for Xamarin bug
2663 (Regular Expressions Bug Fix) and as of tonight the bug report
still has not been closed. I would close it myself but i do not have
the authority. I do have the authority to close the novell bug, but
until 2663 is closed
Nevermind, Miguel commented on the bug report just now that the fix
needs to be backported which he said he would handle..
-Rob
On 06/18/2012 09:36 PM, Rob Wilkens wrote:
This morning Miguel De Icaza (sp?) put through my fix for Xamarin bug
2663 (Regular Expressions Bug Fix) and as of tonight
I'd definitely recommend giving it longer than a day for things to go
through :D
Sent from my Windows Phone
--
From: Rob Wilkens
Sent: 6/18/2012 6:50 PM
To: mono-devel-list@lists.ximian.com
Subject: Re: [Mono-dev] Closing bug report Xamarin 2663 + Novell 641823
Can't we simplify the test to avoid having to include that XML file?
Rob Wilkens wrote
I've attached the unit test, and tested it. It consistently fails,
though not always with the same exception, when run on unpatched
version. It seems to consistently pass with the patched version.
28 matches
Mail list logo
