Re: [Mono-devel-list] Re: [Mono-patches] r45854 - trunk/mcs/class/System.Data/System.Data

2005-06-15 Thread Sureshkumar T
On Tue, 2005-06-14 at 16:57 +0300, Boris Kirzner wrote: Hello Suresh I'm not sure this particular fix is correct : for the case that dataset.EnforceConstraints is false, but datatable.EnforceConstraints is true we still should check for possible constraint violation. 100% correct fix. I

[Mono-devel-list] Re: build breakage and comments

2005-06-15 Thread Sureshkumar T
2. The new internal DataRow Find (object [] keys, DataViewRowState rowStateFilter) in datarowcollection.cs, uses Table.FindIndex and if not found creates a new index. So if there is no suitable index a new one will be created on each call, what is very inneficient. The better practice

Re: [Mono-devel-list] Patch for System.Data.Common and System.Data.ProviderBase

2005-05-24 Thread Sureshkumar T
+ public override ParameterDirection Direction { + get { + if (_direction == ((ParameterDirection) 0)) { + return ParameterDirection.Input; + } what is this check

Re: [Mono-devel-list] Patch for System.Data.Common and System.Data.ProviderBase

2005-05-24 Thread Sureshkumar T
I'll try to keep the code as close as possible to the guidelines. Thanks. DbParameterBase.Parent : used by DbParameterCollectionBase to track collection ownership on parameters (for example it should be impossible to add the same parameter to two different collections simultaneously). I

Re: [Mono-devel-list] Patch for System.Data.Common and System.Data.ProviderBase

2005-05-23 Thread Sureshkumar T
Index: DbParameterBase.cs === --- DbParameterBase.cs(revision 44908) +++ DbParameterBase.cs(working copy) @@ -4,6 +4,7 @@ // Author: // Sureshkumar T ([EMAIL PROTECTED]) // Tim Coleman ([EMAIL PROTECTED

Re: [Mono-devel-list] Problem with DbDataAdapter... RESOLVED

2005-05-20 Thread Sureshkumar T
:-). Regards, Konstantin Triger Sureshkumar T wrote: + bool allowDBNull = value is bool ? (bool)value : false; default allowDBNull should be true ;-) suresh. ___ Ce message et les

Re: [Mono-devel-list] Problem with DbDataAdapter...

2005-05-17 Thread Sureshkumar T
+ bool allowDBNull = value is bool ? (bool)value : false; default allowDBNull should be true ;-) suresh. ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com

Re: [Mono-devel-list] DataView.Sort behaves different on mono than Windows

2005-04-14 Thread Sureshkumar T
Hey, This scenario perfectly works fine for me here. Find the attached sample code. it works as expected. I use mono 1.1.7 Let me know whether this works for you too. If not , I suggest to upgrade ;-). If you have any other specific situation, please post a simple code so that I can look