I didn't send it immediately after I wrote it (as the hotel was
disconnected) and anyways I didn't feel I have to reply to this
fruitless post immediately. But as you requested, here it is.
Gert Driesen wrote:
> This is not making much sense. Just about every member/class in
> System.Xml.Serial
Gert,
On Thu, Jun 26, 2008 at 12:03 PM, Gert Driesen <[EMAIL PROTECTED]>
wrote:
>
> I'm not deliberately ignoring your or anyone else's advice. Perhaps my idea
> of trivial changes is different than yours, definitely if a very large part
> of those changes is covered by unit tests. Next time, I'l
alf Of Atsushi Eno
Sent: vrijdag 27 juni 2008 2:37
To: 'mono-devel-list'
Subject: Re: [Mono-dev] [Fwd: [Mono-patches] r106626 - in
trunk/mcs/class/System.Configuration: . System.Configuration
Test/System.Configuration Test/standalone]
Actually anyone who uses this IConfigErrorInfo is an i
book about these trivial changes, but I've
>> responded to your comments inline.
>>
>> Gert
>>
>> -Original Message-----
>> From: [EMAIL PROTECTED]
>> [mailto:[EMAIL PROTECTED] On Behalf Of Atsushi Eno
>> Sent: donderdag 26 juni 2008 17:41
&
sage-
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf Of Atsushi Eno
> Sent: donderdag 26 juni 2008 17:41
> To: Gert Driesen
> Cc: 'mono-devel-list'
> Subject: Re: [Mono-dev] [Fwd: [Mono-patches] r106626 - in
> trunk/mcs/class/System.Configuration:
icable, instead of relying on the internal IConfigXmlNode
> interface, or explicitly checking for XmlTextReader.
>
> => My changes actually make it a little easier for your XmlNodeReader-based
> implementation, as you don't have to check for explicit checks against
> XmlTextReader
-list
Subject: Re: [Mono-dev] [Fwd: [Mono-patches] r106626 - in
trunk/mcs/class/System.Configuration: . System.Configuration
Test/System.Configuration Test/standalone]
Hey,
On 6/26/08, Gert Driesen <[EMAIL PROTECTED]> wrote:
> Please be reasonable. What more can you ask?
Is that worth n
ine.
Gert
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Atsushi Eno
Sent: donderdag 26 juni 2008 17:41
To: Gert Driesen
Cc: 'mono-devel-list'
Subject: Re: [Mono-dev] [Fwd: [Mono-patches] r106626 - in
trunk/mcs/class/System.Configuration: . Syste
I think that's kind of mistake we often make; CONFIGURATION_DEP
annoyance. Let's not worry much about it ;-)
Atsushi Eno
Jb Evain wrote:
> Hey,
>
> On 6/26/08, Gert Driesen <[EMAIL PROTECTED]> wrote:
>> Please be reasonable. What more can you ask?
>
> Is that worth noting that the particular c
Hey,
On 6/26/08, Gert Driesen <[EMAIL PROTECTED]> wrote:
> Please be reasonable. What more can you ask?
Is that worth noting that the particular commit we're talking about
broke the build?
--
Jb Evain <[EMAIL PROTECTED]>
___
Mono-devel-list mailing
On 6/26/08, Gert Driesen <[EMAIL PROTECTED]> wrote:
> Sorry dude, but this wasn't a large changeset.
Alright, so because you simply *refuse* to hear what we telling you,
let me rephrase and explain.
> If the definition of a large changeset is a patch which adds a large set of
> unit tests, the
time
"unfortunately" we were actually discussing System.Configuration
refactoring. That's why your change is specially mentioned.
Atsushi Eno
Gert Driesen wrote:
> Hey Jb,
>
> Sorry dude, but this wasn't a large changeset.
>
> If the definition of a large chan
ssage-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Jb Evain
Sent: donderdag 26 juni 2008 15:11
To: Gert Driesen
Cc: Atsushi Eno; mono-devel-list
Subject: Re: [Mono-dev] [Fwd: [Mono-patches] r106626 - in
trunk/mcs/class/System.Configuration: . System.Configuration
Test/System.Con
Hey,
On 6/26/08, Gert Driesen <[EMAIL PROTECTED]> wrote:
> > Even only with that point, I'm pretty much tempted to revert your
> > changes.
>
>
> Yeah, I'm glad my (any?) contributions are that much appreciated.
Come on Gert, it's definitely not the first time that you're told that
your commits
nal Message-
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf Of Atsushi Eno
> Sent: donderdag 26 juni 2008 12:51
> To: 'mono-devel-list'
> Subject: [Mono-dev] [Fwd: [Mono-patches] r106626 - in
> trunk/mcs/class/System.Configuration: . System.Configurat
t ;-)
>
> Gert
>
> -Original Message-
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf Of Atsushi Eno
> Sent: donderdag 26 juni 2008 12:51
> To: 'mono-devel-list'
> Subject: [Mono-dev] [Fwd: [Mono-patches] r106626 - in
> trunk/mcs/clas
--Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Atsushi Eno
Sent: donderdag 26 juni 2008 12:51
To: 'mono-devel-list'
Subject: [Mono-dev] [Fwd: [Mono-patches] r106626 - in
trunk/mcs/class/System.Configuration: . System.Configuration
Test/Syste
Man, I don't think this is a good change. We (in Boston) are talking
about sys.configuration optimization, and will likely have to eliminate
XmlTextReader dependency (actually I have such a change possibly
to switch to XmlNodeReader at some stage). Your change would make
performance worse, or at le
18 matches
Mail list logo
