Hey Rodrigo,
You're right, I'll revert the changes to Ipc/* as I did indeed replaces lots of spaces with tabs there. Apart from these classes, the changes should be easy to review. I did not change any line endings. I only added eol-style properties to files that had already LF endings. Gert From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Rodrigo Kumpera Sent: zaterdag 9 augustus 2008 17:23 To: Gert Driesen Cc: Mono devel list Subject: Re: [Mono-dev] [Mono-patches] r110042 - in trunk/mcs/class/System.Runtime.Remoting: . System.Runtime.Remoting.Channels System.Runtime.Remoting.Channels.Ipc System.Runtime.Remoting.Channels.Tcp System.Runtime.Remoting.MetadataServices System.Runtime.Remoti Hi Gert, This path is so huge that I cannot read it. It contains too many different changes. Formatting, parameter names, new functionality, line ending changes and possibly more that I cannot find. I'm not against your patches, it's the very opposite, I'm glad to see you contributing. But, on the other hand, a lot of people must review the patches that comes in to see if nothing wrong has slipped in. For example, I read all of them against mono and most for mcs. I commit code with a lot silly mistakes in and thankfully I have people that read my commits and point me to those errors. To make this possible I have to make sure each patch follow a single topic. More important that the size is to stick to a single topic, like parameter name changes or a bug fix. I admire your contributions, but please, don't mix up that much stuff on a single commit, it makes harder for everyone. I don't want to have to borrow JB's book. Cheers Rodrigo On Sat, Aug 9, 2008 at 11:06 AM, Gert Driesen ([EMAIL PROTECTED]) <[EMAIL PROTECTED]> wrote: Author: gert Date: 2008-08-09 10:06:44 -0400 (Sat, 09 Aug 2008) New Revision: 110042 Added: trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.Channels/Soc ketCachePolicy.cs Modified: trunk/mcs/class/System.Runtime.Remoting/ChangeLog trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.Channels.Ipc /ChangeLog trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.Channels.Ipc /IpcChannel.cs trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.Channels.Ipc /IpcClientChannel.cs trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.Channels.Ipc /IpcServerChannel.cs trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.Channels.Tcp /ChangeLog trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.Channels.Tcp /TcpChannel.cs trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.Channels.Tcp /TcpServerChannel.cs trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.Channels/Cha ngeLog trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.MetadataServ ices/ChangeLog trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.MetadataServ ices/MetaData.cs trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.MetadataServ ices/MetaDataCodeGenerator.cs trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.MetadataServ ices/MetaDataExporter.cs trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.MetadataServ ices/SUDSGeneratorException.cs trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.MetadataServ ices/SUDSParserException.cs trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.MetadataServ ices/SdlChannelSink.cs trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.MetadataServ ices/SdlChannelSinkProvider.cs trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.MetadataServ ices/SdlType.cs trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.MetadataServ ices/ServiceType.cs trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.Services/Cha ngeLog trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.Services/Rem otingClientProxy.cs trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.Services/Rem otingService.cs trunk/mcs/class/System.Runtime.Remoting/System.Runtime.Remoting.dll.sources Log: * System.Runtime.Remoting_test.dll.sources: add SocketCachePolicy.cs. * SocketCachePolicy.cs: Added. * IpcChannel.cs: Fixed argument names to match MS. Changed spaces to tabs. * IpcClientChannel.cs: Fixed argument names to match MS. Changed spaces to tabs. * IpcServerChannel.cs: Fixed argument names to match MS. Changed spaces to tabs. * TcpChannel.cs: Fixed argument names to match MS. * TcpServerChannel.cs: Fixed argument names to match MS. * MetaData.cs: Fixed argument names to match MS. * SdlChannelSink.cs: Fixed argument names to match MS. * SUDSGeneratorException.cs: Marked Serializable on 2.0 profile, and added deserialization ctor. * SUDSParserException.cs: Marked Serializable on 2.0 profile, and added deserialization ctor. * RemotingClientProxy.cs: Marked ComVisible on 2.0 profile.
_______________________________________________ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list