Re: [Mono-dev] [PATCH] CodeGenerator/CodeDom classes

2008-02-10 Thread Miguel de Icaza
ChangeLog entries are included, all unit tests pass. Please review (or at least comment...) I have no objections to this if Gert and Robert have blessed this approach. I take it you have tested this with ASP.NET and other assorted apps, right? ___

[Mono-dev] [PATCH] CodeGenerator/CodeDom classes

2008-02-01 Thread Juraj Skripsky
Hi monkeys, Could somebody please review my patch for the System.CodeDom classes? This is the fourth time I'm posting this and nobody provided any feedback so far. I'm sending this via my gmail account now, in case my previous mails did not reach the list subscribers (they _did_ reach the list

Re: [Mono-dev] [PATCH] CodeGenerator/CodeDom classes

2008-02-01 Thread Gert Driesen
:32 AM Subject: [Mono-dev] [PATCH] CodeGenerator/CodeDom classes Hi monkeys, Could somebody please review my patch for the System.CodeDom classes? This is the fourth time I'm posting this and nobody provided any feedback so far. I'm sending this via my gmail account now, in case my

[Mono-dev] [PATCH] CodeGenerator/CodeDom classes (again)

2008-01-24 Thread Juraj Skripsky
Hello, This is the third time I'm posting this (no counting my first, Visitor-less version). Nobody provided any feedback so far... Attached you'll find patches for CodeGenerator.cs and quite a few System.CodeDom classes. They implement the Visitor pattern for the CodeGenerator (traverser) and

Re: [Mono-dev] [PATCH] CodeGenerator/CodeDom classes

2008-01-16 Thread Juraj Skripsky
Hello, Could somebody please review this patch? Thanks. - Juraj On Wed, 2008-01-09 at 22:59 +0100, Juraj Skripsky wrote: Hello, Attached you'll find patches for CodeGenerator.cs and quite a few System.CodeDom classes. Also included is a new file ICodeDomVisitor.cs which belongs into

[Mono-dev] [PATCH] CodeGenerator/CodeDom classes

2008-01-09 Thread Juraj Skripsky
Hello, Attached you'll find patches for CodeGenerator.cs and quite a few System.CodeDom classes. Also included is a new file ICodeDomVisitor.cs which belongs into System/System.CodeDom. ChangeLog entries are included. These patches replace those (ugly ones) I posted on Jan 6th. They implement