Re: [Mono-dev] [PATCH] System.Configuration.Provider.ProviderBase.cs

2007-08-31 Thread Atsushi Eno
Hmm, I doubt. Your change looks strange (don't you think so? ;-) Please provide verifiable test case that exactly shows the behavioral difference. I'd rather think there is something else to fix (if any). Atsushi Eno John Anderson wrote: When dealing with the configuration, after the

Re: [Mono-dev] [PATCH] System.Configuration.Provider.ProviderBase.cs

2007-08-31 Thread John Anderson
On 8/31/07, Atsushi Eno [EMAIL PROTECTED] wrote: Hmm, I doubt. Your change looks strange (don't you think so? ;-) Please provide verifiable test case that exactly shows the behavioral difference. I'd rather think there is something else to fix (if any). I've attached a smaller test case

Re: [Mono-dev] [PATCH] System.Configuration.Provider.ProviderBase.cs

2007-08-31 Thread John Anderson
On 8/31/07, John Anderson [EMAIL PROTECTED] wrote: On 8/31/07, Atsushi Eno [EMAIL PROTECTED] wrote: Hmm, I doubt. Your change looks strange (don't you think so? ;-) Please provide verifiable test case that exactly shows the behavioral difference. I'd rather think there is something

Re: [Mono-dev] [PATCH] System.Configuration.Provider.ProviderBase.cs

2007-08-31 Thread Atsushi Eno
Your code does not verify that your change must be correct. It just shows the fact that it *affects* on our ASP.NET behavior (Or is that a general way for .NET developers to identify the source of bugs?). What I expected was rather like below: using System; using System.Collections.Specialized;

Re: [Mono-dev] [PATCH] System.Configuration.Provider.ProviderBase.cs

2007-08-31 Thread John Anderson
On 8/31/07, Atsushi Eno [EMAIL PROTECTED] wrote: Your code does not verify that your change must be correct. It just shows the fact that it *affects* on our ASP.NET behavior (Or is that a general way for .NET developers to identify the source of bugs?). What I expected was rather like below:

Re: [Mono-dev] [PATCH] System.Configuration.Provider.ProviderBase.cs

2007-08-31 Thread Gert Driesen
Hi John, This is now fixed in SVN (with matching unit tests). Gert _ From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of John Anderson Sent: vrijdag 31 augustus 2007 10:19 To: Atsushi Eno Cc: mono-devel Subject: Re: [Mono-dev] [PATCH

Re: [Mono-dev] [PATCH] System.Configuration.Provider.ProviderBase.cs

2007-08-31 Thread Atsushi Eno
:* mono-devel *Subject:* Re: [Mono-dev] [PATCH] System.Configuration.Provider.ProviderBase.cs On 8/31/07, *Atsushi Eno* [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: Your code does not verify that your change must be correct. It just shows the fact that it *affects* on our

[Mono-dev] [PATCH] System.Configuration.Provider.ProviderBase.cs

2007-08-30 Thread John Anderson
When dealing with the configuration, after the ProviderBase finds the Description it needs to remove it from the NameValueCollection, This is how it happens in MS.NET. heres the patch: Index: ProviderBase.cs === --- ProviderBase.cs