Re: [Mono-dev] [PATCH] Use correct console code page on Windows (affects Linux as well)

2006-08-07 Thread Kornél Pál
[EMAIL PROTECTED] Cc: mono-devel-list@lists.ximian.com Sent: Thursday, July 27, 2006 6:50 PM Subject: Re: [Mono-dev] [PATCH] Use correct console code page on Windows (affects Linux as well) Hi, I think this can be solved by moving the windows specific code to a separate

Re: [Mono-dev] [PATCH] Use correct console code page on Windows (affects Linux as well)

2006-08-07 Thread Zoltan Varga
? Kornél - Original Message - From: Zoltan Varga [EMAIL PROTECTED] To: Kornél Pál [EMAIL PROTECTED] Cc: mono-devel-list@lists.ximian.com Sent: Thursday, July 27, 2006 6:50 PM Subject: Re: [Mono-dev] [PATCH] Use correct console code page on Windows (affects Linux as well

Re: [Mono-dev] [PATCH] Use correct console code page on Windows (affects Linux as well)

2006-08-07 Thread Kornél Pál
Pál [EMAIL PROTECTED] Cc: mono-devel-list@lists.ximian.com Sent: Monday, August 07, 2006 5:25 PM Subject: Re: [Mono-dev] [PATCH] Use correct console code page on Windows (affects Linux as well) Currently, when a method referencing a pinvoke method is compiled, the pinvoke method is looked up even

[Mono-dev] [PATCH] Use correct console code page on Windows (affects Linux as well)

2006-07-27 Thread Kornél Pál
Hi, I recently posted this patch: http://lists.ximian.com/pipermail/mono-devel-list/2006-July/019433.html But I received no comments and didn't think that this can cause problems on other OSes so I commited it: http://lists.ximian.com/pipermail/mono-patches/2006-July/077941.html This was later

Re: [Mono-dev] [PATCH] Use correct console code page on Windows (affects Linux as well)

2006-07-27 Thread Robert Jordan
Kornél Pál wrote: Hi, I recently posted this patch: http://lists.ximian.com/pipermail/mono-devel-list/2006-July/019433.html But I received no comments and didn't think that this can cause problems on other OSes so I commited it:

Re: [Mono-dev] [PATCH] Use correct console code page on Windows (affects Linux as well)

2006-07-27 Thread Zoltan Varga
Hi, I think this can be solved by moving the windows specific code to a separate method, marking it with [MethodImplAttribute (MethodImplOptions.NoInlining)] and calling it from inside the if (OnWindows) block. That way, the pinvoke lookups would not be executed on

Re: [Mono-dev] [PATCH] Use correct console code page on Windows (affects Linux as well)

2006-07-27 Thread Miguel de Icaza
Hello, As for advapi32.dll and ole32.dll I don't think that these hints are caused by my modifications. This was caused because the P/Invoke libraries are listed as external modules. The following patch fixes this, it avoids this by not loading any external modules that are listed as

Re: [Mono-dev] [PATCH] Use correct console code page on Windows (affects Linux as well)

2006-07-27 Thread Zoltan Varga
It looks ok to me. Zoltan On 7/27/06, Miguel de Icaza [EMAIL PROTECTED] wrote: Hello, As for advapi32.dll and ole32.dll I don't think that these hints are caused by my modifications. This was caused because the P/Invoke libraries are listed as external modules. The following patch

Re: [Mono-dev] [PATCH] Use correct console code page on Windows (affects Linux as well)

2006-07-27 Thread Kornél Pál
@lists.ximian.com Sent: Thursday, July 27, 2006 10:59 PM Subject: Re: [Mono-dev] [PATCH] Use correct console code page on Windows (affects Linux as well) It looks ok to me. Zoltan On 7/27/06, Miguel de Icaza [EMAIL PROTECTED] wrote: Hello, As for advapi32.dll and ole32.dll I don't think