Hello again,
Now that the holidays are over, my chances should be better:
Who's the maintainer of the classes in System.Collections.Specialized,
who can give me the okay to commit my changes (and Gert's unit tests) to
NameObjectCollectionBase[Test].cs?
- Juraj
On Sat, 2007-12-29 at 19:50
Hey,
Who's the maintainer of the classes in System.Collections.Specialized,
who can give me the okay to commit my changes (and Gert's unit tests) to
NameObjectCollectionBase[Test].cs?
This looks fine, but it lacks ChangeLog entries.
Miguel
___
Hi Miguel,
Look again, they're there (as they were from day one), although they
might lead to commit conflicts by now (I'll sort that out of course). My
last mail with the patches attached was this:
http://lists.ximian.com/pipermail/mono-devel-list/2007-December/026250.html
Is that an okay to
@lists.ximian.com
Subject: Re: [Mono-dev] [Patch]
NameObjectCollectionBase,HttpCookieCollection
Hi Gert,
Sorry, I attached the wrong version.
Here you go again, it's the right one this time and also includes the
optimization suggested by Konstantin.
- Juraj
On Fri, 2007-12-21 at 13:09
: Re: [Mono-dev] [Patch]
NameObjectCollectionBase,HttpCookieCollection
Hi Gert,
Sorry, I attached the wrong version.
Here you go again, it's the right one this time and also includes the
optimization suggested by Konstantin.
- Juraj
On Fri, 2007-12-21 at 13:09 +0100, Gert Driesen wrote:
Hi
Sent: donderdag 20 december 2007 10:38
To: Gert Driesen
Cc: mono-devel-list@lists.ximian.com
Subject: Re: [Mono-dev] [Patch]
NameObjectCollectionBase,HttpCookieCollection
Hi Gert,
I'm attaching my patches, updated as per your suggestions.
- Juraj
On Thu, 2007-12-20 at 10:06 +0100
Title: RE: [Mono-dev] [Patch] NameObjectCollectionBase,HttpCookieCollection
Hi Juraj,
NameValuCollectionBase.ICollection.CopyTo (Array array, int arrayIndex):
Since the key is of type String, the destination array must be either of type string[] or object[], otherwise
Subject: Re: [Mono-dev] [Patch]
NameObjectCollectionBase,HttpCookieCollection
Hi Gert,
Thanks for your thorough review! Attached is the lastest and greatest.
All unit tests are updated and pass.
May I commit?
- Juraj
On Thu, 2007-12-20 at 18:44 +0100, Gert Driesen wrote:
Hi Juraj
12:51
To: Gert Driesen
Cc: mono-devel-list@lists.ximian.com
Subject: Re: [Mono-dev] [Patch]
NameObjectCollectionBase,HttpCookieCollection
Hi Gert,
Thanks for your thorough review! Attached is the lastest and greatest.
All unit tests are updated and pass.
May I commit?
- Juraj
On Thu, 2007-12
] [Patch] NameObjectCollectionBase, HttpCookieCollection
Hello,
Attached are three small patches for NameObjectCollectionBase.cs,
NameObjectCollectionBaseTest.cs and HttpCookieCollection.cs.
All unit tests pass on Mono. Could someone verify that the new unit tests
work on MS.NET?
May I commit
Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Juraj
Skripsky
Sent: donderdag 20 december 2007 10:38
To: Gert Driesen
Cc: mono-devel-list@lists.ximian.com
Subject: Re: [Mono-dev] [Patch]
NameObjectCollectionBase,HttpCookieCollection
Hi Gert,
I'm attaching my patches
Hello,
Attached are three small patches for NameObjectCollectionBase.cs,
NameObjectCollectionBaseTest.cs and HttpCookieCollection.cs.
All unit tests pass on Mono. Could someone verify that the new unit
tests work on MS.NET?
May I commit?
- Juraj
Index: System.Web/System.Web/ChangeLog
12 matches
Mail list logo
