Hey Paolo,
Thanks for the comments.
Carlos.
El mié, 14-09-2005 a las 20:45 +0200, Paolo Molaro escribió:
On 09/01/05 Carlos Alberto Cortez wrote:
Index: AssemblyName.cs
===
--- AssemblyName.cs (revisión: 48811)
+++
On 08/24/05 Carlos Alberto Cortez wrote:
The attached patches contain some changes to runtime functions to
support the new AssemblyName ctor. They also add an internal call for
this ctor.
I added a pair of new fields to MonoAssemblyName (is_persistent and
is_version_defined) to define if
On Thu, 2005-25-08 at 15:42 +0200, Paolo Molaro wrote:
@@ -1197,8 +1211,35 @@
aname-culture = g_strdup (culture);
}
- if (token strncmp (token, null, 4) != 0)
+ if (token strncmp (token, null, 4) != 0) {
+ if (strlen (token) !=
This break the ABI: is_version_defined is not needed since you can check
the fields anyway.
is_persistent can go away some other way (for example by always having
public_key allocated, but it would be better to find another which
doesn't make us waste memory).
No, you can't check the
Hey,
I didn't take the choice of using the internal call (unamnaged code)
since I thought it was not optimal (Paolo's told me that was not true).
About the other point, I hadn't thought about it (using the same
function to provide the same behavior for all the possible uses).
So I will be using
Hey Paolo,
We have mono_assembly_name_parse, which receives a MonoString* and a
MonoAssemblyName*. The problem I find is that every time a
System.Reflection.AssemblyName were created using the described ctor, we
should also create a MonoAssemblyName (not needed).
With the managed ctor, we also
: Mono Devel mono-devel-list@lists.ximian.com
Sent: Saturday, August 20, 2005 12:34 AM
Subject: Re: [Mono-dev] [Patch] AssemblyName ctor
Hello again,
comments below:
+ if (String.Compare (parts [i], 0, Version=, 0, 8, true,
CultureInfo.InvariantCulture) == 0)
This is most likely incorrect
Hey,
The patch attached implements the new AssemblyName ctor without using
internal calls. Could anybody review it?
+int GetCharNumericValue (char c)
+{
+if (c = (char)0x30 c = (char)0x3B)
+return c -
Hello again,
comments below:
+ if (String.Compare (parts [i], 0, Version=, 0, 8, true,
CultureInfo.InvariantCulture) == 0)
This is most likely incorrect and needs to use an ordinal comparison, no
InvariantCulture (used more than one time)
I'm not sure that's correct. I tested in .Net
Subject: Re: [Mono-dev] [Patch] AssemblyName ctor
Hello again,
comments below:
+ if (String.Compare (parts [i], 0, Version=, 0, 8, true,
CultureInfo.InvariantCulture) == 0)
This is most likely incorrect and needs to use an ordinal comparison, no
InvariantCulture (used more than one time
Hey,
The attached patch contains the latest suggestions of both Kornel and
Ben. Maybe the only thing to be noted is that I kept the hexadecimal
notation when comparing chars, since the same is used in
Char.GetNumericalValue ().
New tests are also attached, and run fine under .Net 2.0
Carlos.
On 08/09/05 Carlos Alberto Cortez wrote:
+static void
+ves_icall_System_Reflection_AssemblyName_InternalParseKeyToken
(MonoReflectionAssemblyName *aname, MonoString *key_token)
+{
+ char *p, *token;
+ int i, j;
+
+ token = mono_string_to_utf8 (key_token);
+ aname-keyToken
hey,
Currently the AssemblyName (string) ctor is not implemented to receive
the long format assembly name (such MyAssembly, Version=1.2,...). The
attached patch adds support for it.
Some tests are also attached.
Carlos.
Index: icall.c
In the last message some attachments were missing.
All of them are now correctly attached.
Index: AssemblyName.cs
===
--- AssemblyName.cs (revisión: 48211)
+++ AssemblyName.cs (copia de trabajo)
@@ -37,6 +37,7 @@
using System.Text;
14 matches
Mail list logo
