[Mono-dev] Fix shadow copy and define UNICODE on windows

2007-03-08 Thread Jonathan Chambers
Here is a patch that fixes shadow copy on windows, and also sets UNICODE and _UNICODE in configure.in on windows. I was getting warning in VS that some Win32 functions we were calling was using the ANSI version (meaning UNICODE was not getting defined in some places) even though we were passing

Re: [Mono-dev] Fix shadow copy and define UNICODE on windows

2007-03-08 Thread Miguel de Icaza
Hello, Why did you need to change snprintf to g_snprintf? There is no rationale documented in the ChangeLog. Miguel. ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list

Re: [Mono-dev] Fix shadow copy and define UNICODE on windows

2007-03-08 Thread Jonathan Chambers
Sorry, reattached ChangeLog with reason (snprintf doesn't exist on Win32 (VS build); also for uniformity as we use g_snprintf everywhere else) and added signoff. If you would rather me do something else than use g_snprintf please let me know. Code is contributed under MIT/X11 license. Thanks,

Re: [Mono-dev] Fix shadow copy and define UNICODE on windows

2007-03-08 Thread Aras Pranckevicius
Sorry, reattached ChangeLog with reason (snprintf doesn't exist on Win32 (VS build); also for uniformity as we use g_snprintf everywhere else) and added signoff. If you would rather me do something else than use g_snprintf please let me know. There is _snprintf on VS. What we do in our

Re: [Mono-dev] Fix shadow copy and define UNICODE on windows

2007-03-08 Thread Miguel de Icaza
Hello, The patch looks fine. Sorry, reattached ChangeLog with reason (snprintf doesn't exist on Win32 (VS build); also for uniformity as we use g_snprintf everywhere else) and added signoff. If you would rather me do something else than use g_snprintf please let me know. Code is