Re: [Mono-dev] Mono Winforms on Mac: Clipboard patches

2010-12-15 Thread Dat Ngo
Yeah I'm pretty sure those clipboard changes are meant to allow copying and pasting between mono and mac applications, instead of just X11 applications. I worked with Ralph briefly when he started working on patching mono and this was one of the problems that came up. I haven't tried these patches

Re: [Mono-dev] Mono Winforms on Mac: Clipboard patches

2010-11-24 Thread stifu
I don't think you should use the MONO_MWF_MAC_FORCE_X11 flag to try these changes, as then you wouldn't be using the native Mac driver anymore, which means you wouldn't notice any changes before and after the patches, then. In the first place, as Ralph was trying to get his app to work on Mono, I

Re: [Mono-dev] Mono Winforms on Mac: Clipboard patches

2010-11-24 Thread matteo tesser
Hi, I gave a first look at the clipboard patch. I applied the patch in my version and tried it. Honestly I have to say that I never saw clipboard (copy and paste) working on WinForms/OSX, and unfortunately I did noticed any change (but no regressions either) in the behavior of tests launched aft

[Mono-dev] Mono Winforms on Mac: Clipboard patches

2010-11-21 Thread Miguel de Icaza
Hello, I have isolated the clipboard changes from Ralph's patches, this version no longer regresses the API [1], and I updated the list of pending changes from Ralph and uploaded that [2]. I am not sure why these changes were needed in the first place. They moved the Clipboard functionality fro

Re: [Mono-dev] Mono Winforms on Mac

2010-11-21 Thread Miguel de Icaza
Hello Matteo, I would like to help too: let us know how to proceed. > Well, someone would pick up the changes2.gz patch that I posted, and digest it bit by bit, isolating individual pieces of functionality. Once that bit is isolated, and tested we post somewhere that the particular part of the

Re: [Mono-dev] Mono Winforms on Mac

2010-11-21 Thread matteo tesser
I would like to help too: let us know how to proceed. On Sun, Nov 21, 2010 at 6:25 AM, Miguel de Icaza wrote: >> >> Ugh, those are huge patches, I can imagine how that'd be hard to review. >> There is some reformatting noise, and also, some private / internal >> members >> were renamed to add a

Re: [Mono-dev] Mono Winforms on Mac

2010-11-21 Thread Stifu
I wish I could help, but I don't have a Mac. Is there anything I could do? Miguel de Icaza wrote: > >> >> >> Ugh, those are huge patches, I can imagine how that'd be hard to review. >> There is some reformatting noise, and also, some private / internal >> members >> were renamed to add a an und

Re: [Mono-dev] Mono Winforms on Mac

2010-11-20 Thread Miguel de Icaza
> > > Ugh, those are huge patches, I can imagine how that'd be hard to review. > There is some reformatting noise, and also, some private / internal members > were renamed to add a an underscore prefix, which is something that I > haven't seen in the Mono code so far, and which is a practice that M

Re: [Mono-dev] Mono Winforms on Mac

2010-11-20 Thread Stifu
Ugh, those are huge patches, I can imagine how that'd be hard to review. There is some reformatting noise, and also, some private / internal members were renamed to add a an underscore prefix, which is something that I haven't seen in the Mono code so far, and which is a practice that MS and other

Re: [Mono-dev] Mono Winforms on Mac

2010-11-19 Thread Miguel de Icaza
Hello, I took Ralph out of the CC line as he does not seem to be involved with this anymore. I said regarding the Winforms patches for OSX: * There is a refactoring of the Clipboard code, this seems > straightforward, but it still needs a review. > I got most of this merged,

Re: [Mono-dev] Mono Winforms on Mac

2010-11-11 Thread Stifu
Sucks to hear about your misfortune, especially since you were dedicated enough to fix Mono bugs all for your previous job. :( I wish you all the best. Ralph Leckett wrote: > > My apologies but I am currently occupied with the matter of finding a job. > My changes are there and they do fix quit

Re: [Mono-dev] Mono Winforms on Mac

2010-11-10 Thread Ralph Leckett
My apologies but I am currently occupied with the matter of finding a job. My changes are there and they do fix quite a number of problems with Mac Mono Winforms. Do with them as you will. Ralph On 11/10/10, Miguel de Icaza wrote: > Hello Ralph, > > I wanted to follow up to see if you had a

Re: [Mono-dev] Mono Winforms on Mac

2010-11-10 Thread Miguel de Icaza
Hello Ralph, I wanted to follow up to see if you had a chance of providing us a roadmap of the changes that you did for Winforms. As I mentioned on my post with the cleaned up patch, there are some bits that are not controversial, but still need to be reviewed and others that are hard to see

Re: [Mono-dev] Mono Winforms on Mac

2010-10-30 Thread Miguel de Icaza
Hello, I will step up, since I have more experience on the code, but based on its > size, I may be giving feedback piece by piece. > The challenge Carlos is that you have no way of testing this on OSX. The majority of the changes are OSX specific. Sadly this means that most of the OSX changes

Re: [Mono-dev] Mono Winforms on Mac

2010-10-30 Thread Ralph Leckett
Thank you Carlos. Ralph (the open source newbie) On 10/30/10, Carlos Alberto Cortez wrote: > Hello, > > I will step up, since I have more experience on the code, but based on its > size, I may be giving feedback piece by piece. > > Carlos. > > 2010/10/30 Miguel de Icaza > >> Hello Ralph, >> >>

Re: [Mono-dev] Mono Winforms on Mac

2010-10-30 Thread Carlos Alberto Cortez
Hello, I will step up, since I have more experience on the code, but based on its size, I may be giving feedback piece by piece. Carlos. 2010/10/30 Miguel de Icaza > Hello Ralph, > > Does the Mono Project have it's own format utility? It would be nice >> to make all the code consistent no matt

Re: [Mono-dev] Mono Winforms on Mac

2010-10-30 Thread Miguel de Icaza
Hello Ralph, Does the Mono Project have it's own format utility? It would be nice > to make all the code consistent no matter what that format is. > We do not. And I do agree with you that some of the practices on Windows.Forms were less than ideal, reading your patch made me realize that the W

Re: [Mono-dev] Mono Winforms on Mac

2010-10-30 Thread Ralph Leckett
Does the Mono Project have it's own format utility? It would be nice to make all the code consistent no matter what that format is. On 10/30/10, Miguel de Icaza wrote: > Hello Ralph, > > Have you given any consideration to providing a roadmap to your changes > so that they can be individually

Re: [Mono-dev] Mono Winforms on Mac

2010-10-30 Thread Miguel de Icaza
Hello Ralph, Have you given any consideration to providing a roadmap to your changes so that they can be individually reviewed? Since you reformatted the source code, it is not possible to apply the patches directly, we still have to apply every change by hand and it would be useful to ha

Re: [Mono-dev] Mono Winforms on Mac

2010-10-19 Thread Miguel de Icaza
Hello, I have created a diff file from the formatted sources that removes some of the other automatic changes that probably came out of some refactoring tool. The patch itself can not be used directly against Mono's source code since it is still a diff from formatted to formatted, not from M

Re: [Mono-dev] Mono Winforms on Mac (Carbon) fixes - all my source code changes attached

2010-10-07 Thread Geoff Norton
On 2010-10-07, at 9:33 PM, Bojan Rajkovic wrote: > Hi Ralph, > > This sounds really cool, but my bet is that the WinForms maintainer is going > to want to see it as smaller patch chunks, and preferably without > whitespace/formatting changes (which it sounds like you have if you used > Visual

Re: [Mono-dev] Mono Winforms on Mac (Carbon) fixes - all my source code changes attached

2010-10-07 Thread Bojan Rajkovic
Hi Ralph, This sounds really cool, but my bet is that the WinForms maintainer is going to want to see it as smaller patch chunks, and preferably without whitespace/formatting changes (which it sounds like you have if you used Visual Studio's Format Document feature). You may want to also fork

Re: [Mono-dev] Mono Winforms on Mac (Carbon) fixes - all my source code changes attached

2010-10-07 Thread Stifu
Nice work, I hope it passes review and gets checked in! Ralph Leckett wrote: > > Hi All, > > Attached is a zip file of 54 classes that I modified to get Mono > Winforms on Mac Carbon working with my .net application from hell. My > apologies for using MS Visual Studio's "Format Document" on al