Re: [Mono-dev] Performance issue with DataTable.Load on large data sets

2011-04-21 Thread Nicklas Overgaard
That's true! However, I'm currently very hung up on finishing the client's project, but once I have finished that, I will have some spare-time to dig into this issue. Thanks for the guidance so far :) Happy easter to everyone! /Nicklas On Wed, 2011-04-13 at 13:07 +0100, Alan wrote: Hey,

Re: [Mono-dev] Performance issue with DataTable.Load on large data sets

2011-04-13 Thread Alan
Hey, On Tue, Apr 12, 2011 at 11:09 AM, Nicklas Overgaard nick...@isharp.dk wrote: Hey Alan, Thanks for picking it up :) Firstly the simple change of moving the BeginLoad/EndLoad out of the loop could easily be committed as a separate patch. If it's possible to verify this change with an

Re: [Mono-dev] Performance issue with DataTable.Load on large data sets

2011-04-12 Thread Nicklas Overgaard
Hi again, I have now made further optimizations, which brings the Load method up to speed with the .net implementation. However, 5 of the regression-tests are now failing. Have all these System.Data regression tests been verified on a windows machine with .net? I just don't want to chase bugs /

Re: [Mono-dev] Performance issue with DataTable.Load on large data sets

2011-04-12 Thread Alan
Hey, Firstly the simple change of moving the BeginLoad/EndLoad out of the loop could easily be committed as a separate patch. If it's possible to verify this change with an additional unit test, all the better! It means it can never regress again. As for the failing tests, the simplest thing to

Re: [Mono-dev] Performance issue with DataTable.Load on large data sets

2011-04-12 Thread Nicklas Overgaard
Hey Alan, Thanks for picking it up :) Firstly the simple change of moving the BeginLoad/EndLoad out of the loop could easily be committed as a separate patch. If it's possible to verify this change with an additional unit test, all the better! It means it can never regress again. Well, the

[Mono-dev] Performance issue with DataTable.Load on large data sets

2011-04-07 Thread Nicklas Overgaard
Hi mono-devers! I'm currently working on a rather large webproject, where we are using a combination of mono 2.10.1 and MySQL. Over the past week, I have observed that loading large datasets (5000+ rows) from mysql into a DataTable takes a very long time. It's done somewhat like this: code

Re: [Mono-dev] Performance issue with DataTable.Load on large data sets

2011-04-07 Thread Nicklas Overgaard
Hi again, I now have a profile log, created with the new mono profiler. It shows, that the method EndLoadData is using up almost all of the time (16 minutes of the 17 minutes it took to create the dump). When looking in the file DbDataAdapter.cs line 355 in current GIT head, the BeginLoadData

Re: [Mono-dev] Performance issue with DataTable.Load on large data sets

2011-04-07 Thread Nicklas Overgaard
Hi again, Sorry for the spamming. Moving out the Begin and End load methods reduced DataTable.Load time to 1.7 seconds on my test machine, so we are getting there! /Nicklas On Thu, 2011-04-07 at 19:29 +0200, Nicklas Overgaard wrote: Hi again, I now have a profile log, created with the new