Re: [Mono-devel-list] [Patch] AssemblyName changes

2005-06-01 Thread Zoltan Varga
Hi, This is ok to check in. Zoltan On 5/30/05, Carlos Alberto Cortez [EMAIL PROTECTED] wrote: Hey, attached is the patch with the changes. Carlos. El jue, 26-05-2005 a las 12:04 +0200, Zoltan Varga escribió: Hey,

Re: [Mono-devel-list] [Patch] AssemblyName changes

2005-05-26 Thread Zoltan Varga
Hey, This looks ok, one comment: - it would be better to create a helper function in icall.c to avoid the code duplication. Zoltan On 5/20/05, Carlos Alberto Cortez [EMAIL PROTECTED] wrote: Hey, Does this fix

Re: [Mono-devel-list] [Patch] AssemblyName changes

2005-05-19 Thread Carlos Alberto Cortez
Hey, Does this fix http://bugzilla.ximian.com/show_bug.cgi?id=59891 -- Ben It is not exactly a patch for that error (I'm not getting that error, however), but to correct the problem of always having something like: AssemblyName aname = new AssemblyName (); aname.Name = Something; and

[Mono-devel-list] [Patch] AssemblyName changes

2005-05-18 Thread Carlos Alberto Cortez
Hey there, I made some changes to at icall.c and AssemblyName.cs to correct some incorrect behavior of AssemblyName class. With these changes, all the tests at AssemblyNameTest.cs run ok, and I even could make a bootstrap. Any comment? Carlos. Index: icall.c

Re: [Mono-devel-list] [Patch] AssemblyName changes

2005-05-18 Thread Ben Maurer
On Wed, 2005-05-18 at 17:25 -0500, Carlos Alberto Cortez wrote: Hey there, I made some changes to at icall.c and AssemblyName.cs to correct some incorrect behavior of AssemblyName class. With these changes, all the tests at AssemblyNameTest.cs run ok, and I even could make a bootstrap.

Re: [Mono-devel-list] [Patch] AssemblyName changes

2005-05-18 Thread Carlos Alberto Cortez
Hey, I noticed this too, but in the MS impl, a new Version instance is created. We could however, use the same. Carlos. El mi, 18-05-2005 a las 18:25 -0400, Ben Maurer escribi: On Wed, 2005-05-18 at 17:25 -0500, Carlos Alberto Cortez wrote: Hey there, I made some changes to at icall.c