Re: [Mono-dev] Re: [Mono-devel-list] [Patch] Publisher Policy support

2005-08-20 Thread Carlos Alberto Cortez
Hey Paolo, Thanks for the comments. I will be commiting today. Carlos. El sáb, 20-08-2005 a las 15:50 +0200, Paolo Molaro escribió: > On 08/17/05 Carlos Alberto Cortez wrote: > > the attached patch works ok, and applies the last suggestions you did. > > Please commit, _after_ fixing the coding

Re: [Mono-dev] Re: [Mono-devel-list] [Patch] Publisher Policy support

2005-08-20 Thread Paolo Molaro
On 08/17/05 Carlos Alberto Cortez wrote: > the attached patch works ok, and applies the last suggestions you did. Please commit, _after_ fixing the coding style with the else placement as I pointed out the last time. Thanks. lupus > Index: metadata-internals.h >

Re: [Mono-dev] Re: [Mono-devel-list] [Patch] Publisher Policy support

2005-08-17 Thread Paolo Molaro
On 08/13/05 Carlos Alberto Cortez wrote: > > struct version doesn't conform to the mono naming conventions. > > Use a typedef and something like MonoAssemblyVersion. > > This was based on the fact I wanted to keep it -at least initially- as > private. We can rename it the way you want, however. I

Re: [Mono-dev] Re: [Mono-devel-list] [Patch] Publisher Policy support

2005-08-17 Thread Carlos Alberto Cortez
Hey, the attached patch works ok, and applies the last suggestions you did. Carlos. El lun, 15-08-2005 a las 19:55 +0200, Paolo Molaro escribió: > On 08/13/05 Carlos Alberto Cortez wrote: > > > struct version doesn't conform to the mono naming conventions. > > > Use a typedef and something lik

Re: [Mono-dev] Re: [Mono-devel-list] [Patch] Publisher Policy support

2005-08-15 Thread Carlos Alberto Cortez
Hey Paolo, Thanks for answering, comments below: El vie, 12-08-2005 a las 15:49 +0200, Paolo Molaro escribió: > On 08/11/05 Carlos Alberto Cortez wrote: > > Index: assembly.c > > === > > --- assembly.c (revisión: 47896) > > +++

[Mono-dev] Re: [Mono-devel-list] [Patch] Publisher Policy support

2005-08-14 Thread Carlos Alberto Cortez
Hey, Great. Maybe we could move it to the svn tree. Carlos. El vie, 12-08-2005 a las 19:30 -0400, Ben Maurer escribió: > > Hey, > > > > I'm re-sending this patch, since the corrected version was only sent by > > mistake to Miguel, Paolo and Ben. > > > > Ben, I applied your change, do you think i

[Mono-dev] Re: [Mono-devel-list] [Patch] Publisher Policy support

2005-08-13 Thread Ben Maurer
> Hey, > > I'm re-sending this patch, since the corrected version was only sent by > mistake to Miguel, Paolo and Ben. > > Ben, I applied your change, do you think it's ok? > As I remember, I had no other objections to the patch. -- Ben ___ Mono-devel

[Mono-dev] Re: [Mono-devel-list] [Patch] Publisher Policy support

2005-08-11 Thread Miguel de Icaza
Hello, > I'm re-sending this patch, since the corrected version was only sent by > mistake to Miguel, Paolo and Ben. Carlos, could you please provide a ChangeLog for these changes? Explain in the ChangeLog what this does and what this fixes. > > Ben, I applied your change, do you think it's ok

[Mono-dev] Re: [Mono-devel-list] [Patch] Publisher Policy support

2005-08-11 Thread Carlos Alberto Cortez
Hey, Sorry for not sending it in my last message. Now it's attached. Carlos. El jue, 11-08-2005 a las 12:33 -0400, Miguel de Icaza escribió: > Hello, > > > I'm re-sending this patch, since the corrected version was only sent by > > mistake to Miguel, Paolo and Ben. > > Carlos, could you pleas

[Mono-dev] Re: [Mono-devel-list] [Patch] Publisher Policy support

2005-08-11 Thread Carlos Alberto Cortez
Hey, I'm re-sending this patch, since the corrected version was only sent by mistake to Miguel, Paolo and Ben. Ben, I applied your change, do you think it's ok? Carlos. El mar, 02-08-2005 a las 14:41 -0500, Carlos Alberto Cortez escribió: > Hello, > > The changes suggested by Ben are attached

Re: [Mono-devel-list] [Patch] Publisher Policy support

2005-07-30 Thread Ben Maurer
On Sat, 2005-07-30 at 11:53 -0400, Miguel de Icaza wrote: > Could you assist Carlos in making this patch work? Yeah, sure. I think he needs to just find a more suitable lock. I think the loader lock would work. I'm not sure why the assembly loading stuff is per-domain anyways. This is a good use

Re: [Mono-devel-list] [Patch] Publisher Policy support

2005-07-30 Thread Miguel de Icaza
Hello, > > The patch looks good to me. > > > > Does anyone have any objections to get this patch in? > > Locking wise, I am not so sure about this path. It adds a domain lock in > the assembly loading code path. Could you assist Carlos in making this patch work? Miguel. __

Re: [Mono-devel-list] [Patch] Publisher Policy support

2005-07-29 Thread Ben Maurer
On Fri, 2005-07-29 at 22:31 -0400, Miguel de Icaza wrote: > Hello Carlos, > > > I'm attaching a patch which adds support for publisher policy files > > ( http://msdn.microsoft.com/library/default.asp?url=/library/en- > > us/cpguide/html/cpconcreatingpublisherpolicyfile.asp ), which allows to > > r

Re: [Mono-devel-list] [Patch] Publisher Policy support

2005-07-29 Thread Miguel de Icaza
Hello Carlos, > I'm attaching a patch which adds support for publisher policy files > ( http://msdn.microsoft.com/library/default.asp?url=/library/en- > us/cpguide/html/cpconcreatingpublisherpolicyfile.asp ), which allows to > redirect one assembly version to another. The patch looks good to me.

[Mono-devel-list] [Patch] Publisher Policy support

2005-07-21 Thread Carlos Alberto Cortez
Hello, I'm attaching a patch which adds support for publisher policy files ( http://msdn.microsoft.com/library/default.asp?url=/library/en- us/cpguide/html/cpconcreatingpublisherpolicyfile.asp ), which allows to redirect one assembly version to another. I'm using a per-domain cache, which saves t