RE: [Mono-devel-list] Merging our System.Drawing

2005-08-03 Thread Andrew Skiba
Hello Jordi, Tuesday, August 2, 2005, 6:49:37 PM, you wrote: I think that we should add a test unit for this class also. Can you write it ? I would like to see the patch and the unit test applied to the tree at the same time. I know that we have not been very good writing test units

RE: [Mono-devel-list] Merging our System.Drawing

2005-08-03 Thread Andrew Skiba
Sorry, the patch included the whole file because of whitespace difference. Please review the fixed patch to make sure it is really innocent. Sorry, forgotten to attach the patch. ColorTranslator.patch Description: ColorTranslator.patch ___

RE: [Mono-devel-list] Merging our System.Drawing

2005-08-03 Thread Jordi Mas
El dt 02 de 08 del 2005 a les 23:00 -0700, en/na Andrew Skiba va escriure: In any case, this patch is not mine, it's only a part of the merge. There are good chances we will write a test fixture for this class. As you can see, I write tests for all classes I deal with - starting with basic

RE: [Mono-devel-list] Merging our System.Drawing

2005-08-03 Thread Andrew Skiba
Thank you. What about patches sent on Sunday, can I commit them yet? Please, commit the patch. Thanks for your work. Jordi, ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list

Re: [Mono-devel-list] Merging our System.Drawing

2005-08-02 Thread Jordi Mas
El dt 02 de 08 del 2005 a les 08:38 -0700, en/na Andrew Skiba va escriure: The attached file is the first patch, adding to ColorTranslator ability to produce HTML color names for system colors. Andrew, Thanks for your work. I think that we should add a test unit for this class also. Can you

Re: [Mono-devel-list] Merging our System.Drawing

2005-08-02 Thread Hugo Ferreira
BTW, do your patches include any fix for the Graphics.FillPie()? startAngle/sweepAngle is behaving differently from MSFT (I guess its due to the way both interpret direction in negative angles). Cheers, Hugo FerreiraOn 8/2/05, Andrew Skiba [EMAIL PROTECTED] wrote: Hello.I am starting to merge