-devel'
Betreff: Re: [Mono-dev] [Patch] to significantly shorten Char.cs
I have some comments even without reading your application/octet-stream
patch (I ususally don't read them).
- Sometimes we have some code pieces that look like duplicates
exactly because of performance
-dev] [Patch] to significantly shorten Char.cs
Andreas,
How about splitting your patches in two? One with the lesser risky
CheckParameter changes and other with the Is*** changes.
The CheckParameter changes look lovely, go ahead commit then.
I would like to do some testing on other changes
));
}
And no, IsWhiteSpace did not get optimized away ;)
-Ursprüngliche Nachricht-
Von: [EMAIL PROTECTED] [mailto:mono-devel-list-
[EMAIL PROTECTED] Im Auftrag von Atsushi Eno
Gesendet: Donnerstag, 26. Juni 2008 23:25
An: 'mono-devel'
Betreff: Re: [Mono-dev] [Patch] to significantly
I have some comments even without reading your application/octet-stream
patch (I ususally don't read them).
- Sometimes we have some code pieces that look like duplicates
exactly because of performance improvements.
- For performance improvements there should be some benchmark
results with
Your patch have a huge ammount of useless whitespace changes, these make
reviews a lot hard.
Please provide some benchmarks so we can run it locally and see the
performance improvements.
I would say that moving the argumento checks to a funcion is a bad idea. We
should move the exception
raising
23:25
An: 'mono-devel'
Betreff: Re: [Mono-dev] [Patch] to significantly shorten Char.cs
I have some comments even without reading your application/octet-stream
patch (I ususally don't read them).
- Sometimes we have some code pieces that look like duplicates
exactly because
