Hi Miguel,
I've rebased, and also added the reordering of the compilation. Please can
you review that before you merge? I've tested it on a fresh clone and it
works, but I can understand that this would be a delicate process, so would
prefer it at least gets a glance over.
Thanks again for all
Hi Miguel,
I've also updated the MachineKey.Protect implementation to have the TODO
removed now.
Please can you merge both https://github.com/mono/mono/pull/1363
(Membership) and https://github.com/mono/mono/pull/1349 (MachineKey) when
you're next free.
I'll start another thread about the other
Amazing, thanks Miguel, comments inline.
On 2 Nov 2014 00:52, Miguel de Icaza mig...@xamarin.com wrote:
PR1349: https://github.com/mono/mono/pull/1349
This is the machine key work, and needs a small tweak before it can be
merged that I will do this week.
I believe the TODO can be removed.
Hello Martin,
The TODO should be used to flag to the consumer that something is not
implemented or half implemented.
But we do not do this for missing items that could be configured out of
band. For those, if they matter, we file bug reports.
Miguel
On Sun, Nov 2, 2014 at 4:20 AM, Martin
Thanks Miguel,
I'll remove that and rebase then. As the test does both protect an
unprotect, should there really be a separate test?
Martin
On 2 November 2014 13:09, Miguel de Icaza mig...@xamarin.com wrote:
Hello Martin,
The TODO should be used to flag to the consumer that something is
I don't really have a strong opinion. Can you teens me the email you want
me to look at?
On Sunday, November 2, 2014, Martin Thwaites monofo...@my2cents.co.uk
wrote:
Thanks Miguel,
I'll remove that and rebase then. As the test does both protect an
unprotect, should there really be a
Hi,
I've noticed that new functionality is going into the wrappers, while in
my opinion that the functionality belongs to HttpRequest and HttpResponse:
* HttpRequestBase.ReadEntityBodyMode: returning 0 instead of
ReadEntityBodyMode.Classic made more sense
*
On 2 November 2014 14:26, Kornel Pal kornel...@gmail.com wrote:
Hi,
I've noticed that new functionality is going into the wrappers, while in
my opinion that the functionality belongs to HttpRequest and HttpResponse:
- HttpRequestBase.ReadEntityBodyMode: returning 0 instead of
PR1349: https://github.com/mono/mono/pull/1349
*This is the machine key work, and needs a small tweak before it can be
merged that I will do this week.*
I believe the TODO can be removed. Can you do that? See comments on pull
request.
PR1363: https://github.com/mono/mono/pull/1363
: mono-devel-list@lists.ximian.com
Subject: Re: [Mono-dev] State of aspnetwebstack on mono
PR1349: https://github.com/mono/mono/pull/1349
This is the machine key work, and needs a small tweak before it can be
merged that I will do this week.
I believe the TODO can be removed. Can you do
From: mig...@xamarin.com
Date: Sat, 1 Nov 2014 20:52:27 -0400
To: monofo...@my2cents.co.uk
CC: mono-devel-list@lists.ximian.com
Subject: Re: [Mono-dev] State of aspnetwebstack on mono
PR1349: https://github.com/mono/mono/pull/1349
This is the machine key work, and needs a small tweak
Hi All,
Just another quick update.
Some potentially amazing news. I've managed to get a fairly large MVC
5.2/WebAPI running on mono! That is out of the box, without any special
versions of dll's (other than removing the Microsoft.Web.Infrastructure.dll
I think.
So, there are a few outstanding
Hi Daniel,
I'm referring to all the work coming out of the aspnetwebstack repository
on codeplex. I don't think MVC 6 is being developed there yet.
Currently that cover MVC and Webapi that I know of, but there could be
others. It essentially the codebase used to create the nuget packages.
I
Martin,
With vNext, they have moved from codeplex to github. You can find the new
repo here: https://github.com/aspnet
-Mike
On Mon, Oct 20, 2014 at 4:01 AM, Martin Thwaites monofo...@my2cents.co.uk
wrote:
Hi Daniel,
I'm referring to all the work coming out of the aspnetwebstack repository
Hello,
PR874 - from Chris Carroll with a few properties implemented around routes
While the properties were added, they are not actually used for anything,
this looks bogus.
The tests basically show that setting a boolean property back and forth is
set, but likely what needs to be tested is
Miguel,
I can not apologize enough for the issue you point out in regards to the
poisoned patch, I had no idea it was sourced from MS. I have been a big
mono fan since 2003, and certainly was not trying to jeopardize mono. As I
identified in my commit message, I found that from another repo on
Hey Mike,
I would just submit a new pull request purely with code that you wrote,
excluding any third party code.
As for the WebRoute, like I mentioned, while it adds the properties, it
looks broken, the properties *should* do something, currently they dont.
On Mon, Oct 20, 2014 at 12:32 PM,
Hi Miguel,
I did look at the Membership stuff, but it looked to me that the names
made sense, therefore didn't think it was decompiled.
I haven't actually looked at that much so I'll implement it this week.
@Mike, mail me when you're done if you want and I'll review it.
As for the properties,
As for the properties, although they should do something to the generated
urls, simply adding them should surely be a valid pull? the issue at the
moment is that without them, you get an exception even if it should be
false. I actually think that these are used by other classes when
Hi Miguel,
The code that I'm referring to here is that of the aspnetwebstack on
codeplex. That is to say that they are not something where you can remove
the code and recompile (unless there as a specific mono implementation
which is not ideal). The goal is to have the compiled dlls that are
20 matches
Mail list logo
