Hello.
I finished my duties at Mainsoft, and started to work for Liveperson. So
probably I will be less visible in the nearest future, and I want to thank
all of you who worked with me. I enjoyed participating in Mono very much,
and I had luck to work with outstanding people. Special thanks to
Hello Sebastien.
I ran mono-api-check on both 1.1 and 2.0 profile, and it did not see any
difference after I removed IEnumerable. So I will commit this patch and
check class statuses of 1.1 and 2.0 in a few days.
* X509CertificateCollection.patch - remove unnecessary overload
If this
Hello,
Before we have our weekend, I'd like to resend this patch for approval.
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Andrew
Skiba
Sent: Tuesday, October 03, 2006 15:48
To: mono-devel-list@lists.ximian.com
Subject: [Mono-dev] EventHandlerList
Hello.
Please review these patches for System.dll.
Part of them is needed to omit TARGET_JVM, so code will be common.
* DigestClient.patch - use MD5.Create instead of HashAlgorithm.Create
(MD5)
* X509CertificateCollection.patch - remove unnecessary overload
Thank you.
Andrew.
Please review the attached patch for EventHandlerList implementation.
Here is the description:
Implement event handler list according to MS definition. No hash table,
just
a simple list with good performance for a small number of events ( 20)
and
worse performance when number of events is bigger.
Hello Raja.
I'm working an GH System.dll project files to build them from Visual
studio and I'm trying to understand how is it bootstrapped in 2.0. How
many times is it compiled? It looks that the process must be like this:
1. System.dll w/o xml and configuration
2. System.Xml
3. System.dll w/
Hello Sebastien,
Part of them is needed to omit TARGET_JVM, so code will be common.
There are no TARGET_JVM in the two files.
As I said, these changes are needed to omit TARGET_JVM.
* DigestClient.patch - use MD5.Create instead of
HashAlgorithm.Create
(MD5)
This is ok in the
Hello.
Please review these patches for System.dll.
Part of them is needed to omit TARGET_JVM, so code will be common.
* AcceptList.patch - stop using of non-standard methods from mscorlib
* DigestClient.patch - use MD5.Create instead of HashAlgorithm.Create
(MD5)
* IOrderedDictionary.patch -
Hello.
The attachment has a patch for ConfigurationSettings to add support for
requirePermission attribute.
Thank you.
Andrew.
ConfigSet.patch
Description: ConfigSet.patch
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
19:50
To: mono-devel-list@lists.ximian.com
Subject: Re: [Mono-dev] I need help with AppDomain or runtime bug
On Mon, 2006-09-25 at 07:43 -0700, Andrew Skiba wrote:
Hello.
As I wrote a few mothes ago, when I made NunitWeb test framework,
there a strange bug when I run tests on mono
Hello.
As I wrote a few mothes ago, when I made NunitWeb test framework, there
a strange bug when I run tests on mono. Sometimes mono hangs, and
oftentimes there are exceptions with the following stacktrace:
Tick caught an exception that has not been propagated:
System.NullReferenceException:
.
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf
Of Andrew Skiba
Sent: Monday, September 18, 2006 15:31
To: mono-devel-list@lists.ximian.com
Subject: [Mono-dev] patch for System.Net/WebException.cs
Hello.
The following code reveils 2 problems
Hello.
The following code reveils 2 problems in subj: wrong initial value for
Status, and incompatibility with .Net serialization. To check the
latter, run test on .net, rename out.xml into in.xml and run test on
mono. After applying the patch the test passes and initial value for
Status is the
Hello,
Please review the attached patch for SqlDataSourceView.ExecuteSelect. A
standalone test aspx is attached as well. It proves that in .Net
ExecuteSelect returns DataView and not DataTableReader. This is
important for implementing paging abilities for GridView. The test also
demonstrates that
Hello.
Robert, I see that Gonzalo approved your patch for bug #77539. Are you
going to commit it soon? I want to commit the attached patch, and it
depends on yours.
Gonzalo, can I commit the attached patch after patch for bug #77539 is
in SVN?
Thank you.
Andrew.
TableStyle.patch
Description:
, together with a bugfix
for ResolveUrl:
http://bugzilla.ximian.com/show_bug.cgi?id=77539
Robert
Andrew Skiba wrote:
Hi, Gonzalo.
Following our IRC conversation, I made some investigation.
On 2.0 when
I tried to render asp:table with BackImageUrl=~/c:\aaa.jpg I've
got
Hi.
I want to add the documentation for the new test framework to the online
Mono documentation. When I browse the documentation for
Novel.Directory.Ldap, it looks that it was generated from XML comments.
Code in mcs\class\System.Web.dotnet\Test\mainsoft\NunitWeb already has
XML comments, what
Hi,
please review the attached patch for AutoGeneratedField internal
constructor. This fixes DetailsView_CreateAutoGenerateRow test.
Andrew.
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
,
Andrew.
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf
Of Gonzalo Paniagua Javier
Sent: Friday, July 14, 2006 01:22
To: mono-devel-list@lists.ximian.com
Subject: Re: [Mono-dev] [PATCH] System.Web.UI.Page fix
On Sun, 2006-07-09 at 08:41 -0700, Andrew
patch
On Wed, 2006-07-26 at 07:05 -0700, Andrew Skiba wrote:
Hi,
please review the attached patch for AutoGeneratedField internal
constructor. This fixes DetailsView_CreateAutoGenerateRow test.
Forgot the attachment?
-Gonzalo
Please review the new patch instead of the previous one.
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf
Of Andrew Skiba
Sent: Thursday, July 06, 2006 16:29
To: mono-devel-list@lists.ximian.com
Subject: [Mono-dev] [PATCH] System.Web.UI.Page fix
Hello,
The attached test reveils the missing functionality in PageThemeCompiler
and the attached patch provides it. In addition to the test here is some
documentation on the issue (see Theme Graphics and Other Resources) :
http://msdn2.microsoft.com/en-us/library/ykzx33wh.aspx
if no one objects,
Don't commit. It's a hack that fixes the problem for you, but
we don't know why that happens.
That happens because HttpContext.Current is set in
HttpRuntime.RealProcessRequest, and when HttpApplication.Start runs in a
different thread, HttpContext.Current is null. I explained it in more
Hello,
While running in custom web hosting of NunitWeb I got a
NullReferenceException from TemplateParser.cs:118. The problem is that
HttpContext.Current is null. It's hard to reproduce in a small
standalone test, though. So I attach the stacktrace of my exception
together with the patch that
Hello,
This patch create a symlink at mono/runtime/etc/mono/2.0/web.config
similar to mono/runtime/etc/mono/2.0/machine.config
This is necessary to have web.config in user created host when running
via mono-wrapper from make run-test
If no one objects, I will commit.
web.config.patch
Sorry, I sent the old patch in the last message. This is the correct
one.
-Original Message-
From: Andrew Skiba
Sent: Sunday, May 21, 2006 17:12
To: 'Chris Toshok'
Cc: mono-devel-list@lists.ximian.com
Subject: improved patch for ApplyTheme
Hello, Chris.
Sorry for the late
Title: Re: [Mono-dev] new test framework works on dotnet
Hello
Miguel,
Thank youfor your response. I forgot
to mention that I used cygwin to run mono, if that matters. When I sent QUIT to
the Mono process, it terminated, with message about core dump, but core dump was
not created. I
Hello,
The attached patch adds new tests to the system.web testsuite, using the
new test framework. The tests can be built on mono and run on mono or on
dotnet by using the standard target make run-test-ondotnet.
Some tests pass on Mono, but some of them need more effort. Sometimes
mono vm
Hello, Chris.
Are you sure you compiled the sources from the attached zip? Because in
those sources I see code
Console.WriteLine (res);
Assert.AreEqual (@spana
href=#_SkipLinkimg alt=Skip Navigation Links height=0
width=0
Hello,
I tried to compile aspx from directory with spaces in the name, and got
the following error. This patch fixes that bug. If no one objects, I
will commit.
bDescription: /bError compiling a resource required to service this
request. Review your source file and modify it to fix this error.
p
This keeps the inner exception. If noone objects, I will commit.
HttpHandlerAction.patch
Description: HttpHandlerAction.patch
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
Hi Chris.
I committed it to sys.web/Tests/mainsoft/NunitWeb. There you will see
new functionality like aspx and master page support. There is a
primitive Makefile to build and run some sample tests with
nunit-console2. However, I have some problem with aspx compilation on
mono. I attach the
Why not adopt this to be part of the unit tests directly?
That's definitely the idea - the patch just didn't provide
any changes to the existing unit tests.
My colleges Tal and Yoni are going to commit few tests as soon as this
framework is ready.
And if this is not possible, we
the problem with the testcase.
Thank you.
Andrew.
-Original Message-
From: Chris Toshok [mailto:[EMAIL PROTECTED]
Sent: Monday, May 01, 2006 20:45
To: Andrew Skiba
Cc: mono-devel-list@lists.ximian.com
Subject: RE: [WARNING : A/V UNSCANNABLE] RE:
[Mono-dev]System.Web.UI.Pagepatch
I
Hello.
I created a simple framework that might help in creating unit tests for
system.web, and want to contribute it. When we tryed to write test for
SiteMapPath.Render, we saw that it needs many things from HttpContext.
Now it's possible to create a method that will run in a web context,
looking
Hello, Chris.
So can I commit these patches yet?
Thank you.
Andrew.
-Original Message-
From: Chris Toshok [mailto:[EMAIL PROTECTED]
Sent: Tuesday, April 25, 2006 20:51
To: Andrew Skiba
Cc: mono-devel-list@lists.ximian.com
Subject: Re: [WARNING : A/V UNSCANNABLE] RE: [Mono-dev
Hello, Chris.
Yesterday you asked for testcases for my patches. The attached tar.gz
includes a small website, which reveals the effect of the following
patches:
ApplyTheme.patch
Page.Web.Config.patch
PageTheme.patch
If no one objects, I'll add the test to
System.Web/Tests/standalone/theme
Hi Gonzalo,
First I forgot to use VirtualPathUtility.Combine and committed my patch
with simple concatenation. Immediately after that, I noticed my mistake
and tried to fix it.
But when I used VirtualPathUtility.Combine, I've got ArgumentException
(basePath is not an absolute path, basePath);
The attached patch uses LinkedStyleSheets from the PageTheme to insert
links in page header. If no one objects, I will commit.
Thank you.
Andrew.
PageTheme.patch
Description: PageTheme.patch
___
Mono-devel-list mailing list
The attached patch fixes the flow for themes combined with master pages.
If no one objects, I will commit.
Page.patch
Description: Page.patch
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
] On Behalf
Of Chris Toshok
Sent: Sunday, April 23, 2006 18:28
To: Andrew Skiba
Cc: mono-devel-list@lists.ximian.com
Subject: Re: [Mono-dev] System.Web.UI.PageTheme patch
could use a test case for this..
Chris
On Sun, 2006-04-23 at 01:42 -0700, Andrew Skiba wrote:
The attached patch
Please review the attached patch for test and fix. If no one objects, I
will commit.
Andrew.
ControlNull.patch
Description: ControlNull.patch
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
The attached patch provides an ability to set the default theme and
stylesheet theme in Web.Config, as documented in
http://msdn2.microsoft.com/en-US/library/950xf363.aspx If no one
objects, I will commit.
Page.Web.Config.patch
Description: Page.Web.Config.patch
-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf
Of Andrew Skiba
Sent: Sunday, April 23, 2006 11:46
To: mono-devel-list@lists.ximian.com
Subject: [Mono-dev] System.Web.UI.Page patch
The attached patch fixes the flow for themes combined with
master pages.
If no one objects
Hello.
Please review the attached patch. Current implementation always returns
null, this patch makes it return values similar to dotnet. Please
ignore CR-LF problems in the patch, I will fix them before committing.
If no one objects, I will commit.
Thank you.
Andrew.
PageThemeCompiler.patch
To: mono-devel-list@lists.ximian.com
Subject: Re: [Mono-dev] LinkedStyleSheets in PageThemeCompiler
On Thu, 2006-04-20 at 09:01 -0700, Andrew Skiba wrote:
Hello.
Please review the attached patch. Current implementation always returns
null, this patch makes it return values similar to dotnet
please review the attached patch for reproducing and fixing several null
reference exceptions in SiteMapNode. Please, ignore the previous patch,
that fixed the problem with 'attributes' field but did not fix 'roles'
field. If no one objects, I will commit.
SiteMapNode.patch
Description:
Hi Chris,
Please review the new patch.
BTW, what do you think on refactoring ThrowParseException into throw
ParseException? I mean to create the exception in the helper function,
but to throw it explicitely?
Thank you,
Andrew.
Index: PageThemeFileParser.cs
);
AddAssembly (assembly, true);
return assembly;
}
Chris
On Mon, 2006-04-10 at 02:34 -0700, Andrew Skiba wrote:
When I use a custom web control in a skin file, then the
dll holding
this control must be added to references when compiling
PageTheme. The
attached patch
As no one replied, I will commit the patch.
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf
Of Andrew Skiba
Sent: Sunday, April 09, 2006 16:41
To: [EMAIL PROTECTED]
Cc: Mono-devel-list@lists.ximian.com
Subject: [Mono-dev] TemplateControlCompiler.cs
Use properties instead of fields to protect from null values. If no one
objects, I will commit.
Index: SiteMapNode.cs
===
--- SiteMapNode.cs (revision 59261)
+++ SiteMapNode.cs (working copy)
@@ -249,10 +249,10 @@
This patch still does not handle situation when attributes==null and
node.attributes!=null. Please review the corrected patch. If no one
objects, I will commit.
Index: SiteMapNode.cs
===
--- SiteMapNode.cs (revision 59261)
+++
I think CompareOrdinal is more appropriate here, so if you don't mind I
will commit my patch.
I actually already committed a patch that works more or less
like the one you've written here.
Chris
___
Mono-devel-list mailing list
You are right. Sorry for the inconvenience.
This patch isn't necessary. comparison works just fine in
the face of null values.
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
I disagree that it is more appropriate - it's case sensitive.
I checked, and found that you are right and directives are case
insensitive. FYI TemplateControlParser uses case-sensitive comparison
everywhere.
But anyway OrdinalComparison is more appropriate in this patch (with
ignore case),
Please review the patch including the testcase. Thank you.
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf
Of Chris Toshok
Sent: Tuesday, April 11, 2006 15:09
To: Andrew Skiba
Cc: mono-devel
Subject: RE: [Mono-dev] PATCH: System.Web/SiteMapNode.cs
, April 11, 2006 19:36
To: Andrew Skiba
Cc: Mono-devel-list@lists.ximian.com
Subject: RE: [Mono-dev] PageThemeFileParser.AddDirective
On Tue, 2006-04-11 at 08:31 -0700, Andrew Skiba wrote:
FYI TemplateControlParser uses case-sensitive comparison everywhere.
where? these should be fixed
Hello, Chris.
I attach skin file, that works perfectly in dotnet, but fails in mono.
If I remove PageThemeFileParser.AddDirective, then
TemplateControlParser.AddDirective perfectly performs the job.
PageThemeFileParser.AddDirective overrides
TemplateControlParser.AddDirective to make adding
When I use a custom web control in a skin file, then the dll holding
this control must be added to references when compiling PageTheme. The
attached patch makes this possible. As such references is already found
by parsers of individual skins, it's only necessary to add new
assemblies to the theme
Hi Chris,
Please review the attached patch for the method in subj. If no one
objects, I will commit.
Index: ThemeDirectoryCompiler.cs
===
--- ThemeDirectoryCompiler.cs (revision 59261)
+++ ThemeDirectoryCompiler.cs (working
Hi, Chris.
At revision 56619 you introduced the following code at
TemplateControlCompiler.cs:176
if (builder is RootBuilder) {
typeString = parser.ClassName;
}
In my flow, parser.ClassName == Default_aspx, which is unresolved, but
parser.PartialClassName has the correct value of
Hello.
I found code duplication, please review the patch to remove it.
If no one objects, I will commit.
Index: UrlUtils.cs
===
--- UrlUtils.cs (revision 59261)
+++ UrlUtils.cs (working copy)
@@ -101,7 +101,9 @@
Hi guys,
The patch contains new unittest, passing on dotnet and failing on mono,
and fix for that unittest.
This is an old issue, probably you remember as Ben suggested an
improvement for the testcase. I did that improvement, please tell me
what you think now. The new unittest passes on dotnet
so it checks the both. Please review the new patch.
If nobody objects, I will commit.
Thank you.
Andrew.
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf
Of Andrew Skiba
Sent: Sunday, April 02, 2006 14:09
To: Ben Maurer; [EMAIL PROTECTED]
Cc: Mono
Hello,
I found a big performance trouble relative to dotnet with the following
code:
static void Main(string[] args)
{
while (true) {
DateTime start = DateTime.Now;
for (int i=0; i1000; i++) {
TextBox tb = new TextBox ();
Hi Ben.
You wrote
A much better test
would be to copy to proposed impl into the test suite (you'd
first have to make sure manually that it gives the exact same
result for any given char as msft). Then make the test check
that the result is the same as the copied impl. This would be
a
Hi Ben.
You wrote:
+ for (char c=Char.MinValue; c128; c++)
chars are from 0 to 2^16-1
I do check those chars. Look at the second loop that iterates from 128
to Char.MaxValue (did you notice it?)
Let me clarify my idea: I could not create expected results for 64K
!=
System.Web.HttpUtility.UrlEncode(s),
+ UrlEncode must escape character
'+s+');
+ }
+ }
}
}
-Original Message-
From: Ben Maurer [mailto:[EMAIL PROTECTED]
Sent: Thursday, December 22, 2005 01:14
To: Andrew Skiba
Cc: [EMAIL
Hi Gonzalo,
I found that UrlEncode behaves differently in dotnet and Mono, namely
Mono encodes the asterisk (*) symbol into %2a.
The following code prints different values, for example:
public static void Main ()
{
Console.Out.WriteLine
Hi Eno,
I saw in one of the overloads there is a check that stylesheet was
loaded, and in the other there is no such check, so instead of
XsltException there will be NullPointerException. Please review the
patch to fix it.
Regards,
Andrew.
Index: XslTransform.cs
Title: RE: porting tool
Sure.
In the most simple scenario you run
$ find -type fINDEX
And then use this index as both source and target list. Typically one will filter executables out of this list, as well as svn directories, etc. Then you can run
$ mono CaseRePorter.exe INDEX INDEX
Title: RE: [Mono-dev] RE: porting tool
Thank you for comments, especially for idea of bin files. So what's in your opinion is the right place in mono tree for such tool?
This is a clever idea. Just a few suggestions:
1) try testing for binary files when you open something to see if it has
Hi Eno,
Good idea, I like it. Please commit this patch.
Thank you,
Andrew.
-Original Message-
From: Atsushi Eno [mailto:[EMAIL PROTECTED]
Sent: Tuesday, August 16, 2005 22:23
To: Andrew Skiba
Cc: mono-devel
Subject: patch for xmlconf.cs
Hi Andrew,
I think xmlconf.exe
Just for curiosity: can svn:eol-style of parent dir take care of all the
files?
* Color.cs: Fixed line endings. Set eol-style to native.
* ColorConverter.cs: Fixed line endings. Set eol-style to native.
* Size.cs: Set eol-style to native.
* SizeF.cs: Use current culture in ToString(), set
I wrote some test cases, and searched for a culture-specific
character that matches the results I got.
You wrote tests that demonstrate the difference in behavior of dotnet
and mono before your fixes? Can you add these tests to the testsuite, or
at least send these tests to the devlist?
String lengths are both 14.
Strings differ at index 2.
expected:10, 20, 30, 40
but was:10. 20. 30. 40
-^
Thank you.
Andrew Skiba.
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http
Hi Gert.
You wrote:
I'm still working on additional fixes and tests, I should get
things stable today (meaning tests should pass on both mono
and MS.NET).
Gert
Can you make things stable before committing, please? We are actively
working on System.Drawing these days, and it is very
As a temporary solution I committed TARGET_JVM so that this destructor
will not be present in our build, but probably it's worth to do same for
Mono, too.
I wonder, what was the need to throw NotImplementedException
in FontNameConverter destructor? What will do GC when
destructor fails in
Added GetStandardValuesSupported to the previous patches. Includes
previous changes, too.
PointAndRectangle.patch
Description: PointAndRectangle.patch
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
Add same tests for SizeConvertor.
If no one objects, I will commit.
PointRectangleSize.patch
Description: PointRectangleSize.patch
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
Hi.
Please review the attached patches. The tests are written from scratch,
so I made as Ben and Jordi suggested regarding ExpectedExceptions. In 2
places it revealed a difference in the exception thrown in dotnet and
mono. Also the new tests uncovered a few bugs in ColorConverter class.
One of
Please review the attached ColorTranslator tests and fixes. The fixes
patch includes the previously sent fixes for ColorConverter tests, as
well.
If no one objects, I will commit.
Thank you.
Andrew.
ColorConverterAndTranslator.patch
Description: ColorConverterAndTranslator.patch
Hi Jonathan.
For regression tests I write that rely on external files, I
usually have a XXX-update target. For example, if make
check runs the regression tests, then check-update would
update the external resources.
Good idea. I'll separate the platform from the generation of results. So
Hello, Eno.
Today I saw someone trying to run old
sys.xml/Test/System.Xml/standalone_tests testsuite. It's outdated and it
fails on svn latest. As it is completely replaced by Test/System.Xml/W3C
suite, may be it's better just to remove the old one (or move it to
deleted dirs), so it does not
Hello.
Yesterday I finished merging out our changes to System.Drawing. Vast
majority of changes were java-specific.
The next thing I want to do is to commit the drawing tests helper we
started to develop at Mainsoft.
I will create a directory under sys.drawing/test for this helper and
will
Hello Jon.
Thanks for your answer.
I understand that ability to run tests without windows box is an
advantage. I thought to commit expected results in similar way we did
with XML tests.
By explicit update mechanism do you mean any particular technique?
Also, how do you suggest to solve the
I commited this helper. It is possible to compile and run it under Mono,
but I did not make generate and test phases yet. I'll continue to work
on it on Sunday. Anyway, code is available to play with, and there are
basic Makefiles to build and run it.
The next thing I want to do is to commit the
Hello Jordi,
Tuesday, August 2, 2005, 6:49:37 PM, you wrote:
I think that we should add a test unit for this class also. Can you
write it ? I would like to see the patch and the unit test applied to
the tree at the same time. I know that we have not been very good
writing test units
Sorry, the patch included the whole file because of whitespace
difference.
Please review the fixed patch to make sure it is really innocent.
Sorry, forgotten to attach the patch.
ColorTranslator.patch
Description: ColorTranslator.patch
___
Thank you. What about patches sent on Sunday, can I commit them yet?
Please, commit the patch. Thanks for your work.
Jordi,
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
Hello.
I am starting to merge out our fixes to System.Drawing, together with
TARGET_JVM ifdefs. The goal is to use Mono SVN as our primary source
repository for System.Drawing.
Patches that do not change flow with TARGET_JVM undefined I will commit
without sending to devlist, and those that
Hi Ben.
Thanks for your comments. What you suggest is really the cleanest
solution.
Unfortunately, to use it, it's necessary to separate positive parts of
tests from those that are expected to throw exceptions. In part of
places, it's relatively easy to do, in other it requires refactoring of
Hello.
We are going to implement a big part of System.Drawing for JVM. While
majority of the code will be java-specific, I expect some changes to
shared code, too.
So the question is - can I create a branch to perform this development
in svn? After we get to some stable point I will create
Please review the attached tests and fixes for them.
I know the fixes look weird, but that's what dot net appear to do in
their sys.drawing. PointF.ToString returns string with space, while
Point.ToString returns without space. And the hash code for PointF seem
to ignore the y value.
PROTECTED]
Sent: Monday, August 01, 2005 13:32
To: Andrew Skiba
Subject: Re: [Mono-devel-list] More tests and fixes for them
Heya there,
I'm wondering... Should we stick so close to MSFT idiosyncrasies? I
mean, for example, if the GetHashCode() for PointF ignores the Y value,
shouldn't we make
Forgotten testcase added and more elegant fix. Please use these patches
instead of previous.
TestRectangle.patch
Description: TestRectangle.patch
Rectangle.patch
Description: Rectangle.patch
___
Mono-devel-list mailing list
Sorry, I missed a couple of methods to test in both Rectangle and
RectangleF. I attach all patches here for convenience.
RectangleF.patch
Description: RectangleF.patch
Rectangle.patch
Description: Rectangle.patch
TestRectangle.patch
Description: TestRectangle.patch
TestRectangleF.patch
At the beginning I hoped to simulate MS functionality as much as
possible, but as I don't know how to reproduce Rectangle hash code, I
don't care if Point will have different code, too.
So I will change the test so it does not requires fixed hash values, as
I did with Rectangle.
Thank you.
Added tests to cover 100% of Color API. Needed to fix Color.GetHashCode
to take Name into account, in addition to ARGB.
TestColor.patch
Description: TestColor.patch
Color.patch
Description: Color.patch
___
Mono-devel-list mailing list
Added tests to cover 100% of Size and SizeF API. No bugs revealed.
TestSize.patch
Description: TestSize.patch
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
1 - 100 of 143 matches
Mail list logo
