Re: [Mono-dev] Tests for ParseRouteInfo

2015-01-16 Thread Ben Woods
OK, I have now added regression tests to my pull request. https://github.com/mono/mono/pull/1404 Could someone please check whether this is good to commit now? Cheers, Ben -- From: Benjamin Woods woods...@gmail.com On 15 January 2015 at 23:33, Miguel de Icaza mig...@xamarin.com wrote: It

Re: [Mono-dev] Tests for ParseRouteInfo

2015-01-15 Thread Miguel de Icaza
Hello, Considering that we do not even have a test, I think it would be nice to turn one of the samples on the git discussion into the test. While not 100% robust, we could check that at least *one* of the interfaces has a gateway, and perhaps make this into a soft failure for those that do not

Re: [Mono-dev] Tests for ParseRouteInfo

2015-01-15 Thread Miguel de Icaza
Also, thanks so much for this patch! On Thu, Jan 15, 2015 at 10:16 AM, Miguel de Icaza mig...@xamarin.com wrote: Hello, Considering that we do not even have a test, I think it would be nice to turn one of the samples on the git discussion into the test. While not 100% robust, we could

Re: [Mono-dev] Tests for ParseRouteInfo

2015-01-15 Thread Ben Woods
Should a test really print to the Console? Presumably this should be adapted to detect if there is at least one valid route? Also, what does a soft failure look like? Is there an example already in the mono source? Thanks for your help. -- From: Benjamin Woods woods...@gmail.com On 15 January

Re: [Mono-dev] Tests for ParseRouteInfo

2015-01-15 Thread Miguel de Icaza
It does not need to print to console. Ignore the soft failure, let us jsut assert if there is no gateway (the soft failure part of my email was written before I changed my mind, and forgot to remove it). Miguel On Thu, Jan 15, 2015 at 10:28 AM, Ben Woods woods...@gmail.com wrote: Should a

[Mono-dev] Tests for ParseRouteInfo

2015-01-15 Thread Ben Woods
Mono is not able to get the system gateway address on Mac OSX or BSD when performing GetIPProperties on an a NetworkInterface. This is due to the mono class libraries solely utilising the /proc/net/route file, which is only available on Linux. I have submitted a pull request to fix this here: