Hi Chris,
Please review the new patch.
BTW, what do you think on refactoring ThrowParseException into throw
ParseException? I mean to create the exception in the helper function,
but to throw it explicitely?
Thank you,
Andrew.
Index: PageThemeFileParser.cs
I think CompareOrdinal is more appropriate here, so if you don't mind I
will commit my patch.
I actually already committed a patch that works more or less
like the one you've written here.
Chris
___
Mono-devel-list mailing list
I disagree that it is more appropriate - it's case sensitive.
Chris
On Tue, 2006-04-11 at 06:21 -0700, Andrew Skiba wrote:
I think CompareOrdinal is more appropriate here, so if you don't mind I
will commit my patch.
I actually already committed a patch that works more or less
like
I disagree that it is more appropriate - it's case sensitive.
I checked, and found that you are right and directives are case
insensitive. FYI TemplateControlParser uses case-sensitive comparison
everywhere.
But anyway OrdinalComparison is more appropriate in this patch (with
ignore case),
Look, I have reviewed the patch.
1) There's no need for the patch, as there's already code in the repo
that does what's needed.
2) You're suggesting changing to a different string method than what is
used in all of the other cases where we compare directive strings.
Check out all the other parser
On Tue, 2006-04-11 at 08:31 -0700, Andrew Skiba wrote:
FYI TemplateControlParser uses case-sensitive comparison
everywhere.
where? these should be fixed.
Chris
___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
, April 11, 2006 19:36
To: Andrew Skiba
Cc: Mono-devel-list@lists.ximian.com
Subject: RE: [Mono-dev] PageThemeFileParser.AddDirective
On Tue, 2006-04-11 at 08:31 -0700, Andrew Skiba wrote:
FYI TemplateControlParser uses case-sensitive comparison everywhere.
where? these should be fixed
Because most directives are illegal in skin files (Page, Assembly, etc),
I assumed that all were. Obviously this isn't the case :)
After more investigation, it looks like Register is the only directive
allowed. Does this agree with your assessment?
By the way, I'm subscribed to this list, so
