Re: [Mono-dev] Unwanted freeing of generic types

2017-08-17 Thread Neale Ferguson
In threads.c we defined SpecialStaticOffset: typedef union { struct { #if G_BYTE_ORDER != G_LITTLE_ENDIAN guint32 type : 1; guint32 offset : 25; guint32 index : 6; #else guint32 index : 6; guint32

[Mono-dev] Mono Weather Report 2017-08-17

2017-08-17 Thread Connor Adsit via Mono-devel-list
Salutations, all. Xamarin Release Engineering here with this week’s edition of the Mono Weather Report. Apologies for missing last week’s report. Here are the top failures currently making Jenkins builds unstable: 1. Test failure in

Re: [Mono-dev] Unwanted freeing of generic types

2017-08-17 Thread Aleksey Kliger via Mono-devel-list
Hey Neale, I think the code below is from mono_metadata_inflate_generic_inst. And the question is whether it’s ok to call mono_metadata_free_type on each type_argv[i] if mono_metadata_get_generic_inst was called. I’m going to go through how I think it’s working - let me know if I messed

Re: [Mono-dev] Unwanted freeing of generic types

2017-08-17 Thread Neale Ferguson
I've been staring at this stuff for the last few days such that I'm seeing things that aren't there. Vargaz suggested bisecting which would be the reasonable approach but s390x wasn't building prior to the generic-special2 test coming into being and when it did start to build again there was an