[Mono-dev] [PATCH] Optimization to Regex.cs

2007-10-25 Thread Arina Itkes
Hello. It looks good, but I see 2 issues that can be resolved in addition: - missed multi thread synchronization; - first instantiation is on fly; One of possible solutions: move initialization of machine to constructor. Regards, Arina.

[Mono-dev] [PATCH] New tests for Regular expressions

2007-10-28 Thread Arina Itkes
I added new tests for regular expressions. Part of them is not working. RegexTests.patch Description: RegexTests.patch ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list

[Mono-dev] [PATCH] Fix for Result method of Match

2007-10-28 Thread Arina Itkes
Result method for failed match should throw exception. Match.patch Description: Match.patch ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list

[Mono-dev] [PATCH] Moving of creation of Regex machine to ctor.

2007-10-28 Thread Arina Itkes
Regex.patch Description: Regex.patch ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list

[Mono-dev] [PATCH] Fix of SmtpClient.Read() method.

2007-10-30 Thread Arina Itkes
Please review this bug fix. It tested on the server with SMTP server. Regression Nunit test cannot be supplied because it requires SMTP server. SmtpClient.patch Description: SmtpClient.patch ___ Mono-devel-list mailing list

Re: [Mono-dev] [PATCH] Fix of SmtpClient.Read() method.

2007-10-30 Thread Arina Itkes
Ok. Done. Please see attachment. Arina. -Original Message- From: Gert Driesen [mailto:[EMAIL PROTECTED] Sent: Tuesday, October 30, 2007 6:44 PM To: Arina Itkes; mono-devel-list@lists.ximian.com Subject: Re: [Mono-dev] [PATCH] Fix of SmtpClient.Read() method. Arina, A standalone test

[Mono-dev] [PATCH] System.Configuration changes for compilation with TARGET_JVM flag.

2007-10-31 Thread Arina Itkes
Hi, I changed code for compilation with defined TARGET_JVM flag. It should not change a code flow compiled without TARGET_JVM. Please review. Thanks, Arina. ConfigurationTest.patch Description: ConfigurationTest.patch Configuration.patch Description: Configuration.patch

Re: [Mono-dev] [PATCH] New tests for Regular expressions

2007-11-04 Thread Arina Itkes
for some not working tests in the file RegexMatchTests.cs. I checked they all are passing on MS. Can you check it again? Thank you. Arina. From: Gert Driesen [mailto:[EMAIL PROTECTED] Sent: Thursday, November 01, 2007 11:49 PM To: Arina Itkes; mono-devel

[Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety fix.

2007-11-15 Thread Arina Itkes
Hi all, Please review the attached patch. It contains synchronization fix for the class WebClientAsyncResult and light changes for the class WebClientProtocol that is a base of SoapHttpClientProtocol for thread safety purpose. WebServicesProtocolPatch.patch

[Mono-dev] [PATCH] System changes for SOAP serialization compatibility with .NET

2007-11-20 Thread Arina Itkes
Hi Please review the changes for SOAP serialization compatibility with .NET. Thanks. SystemChangesForSoapSerizlizationCompatibility.patch Description: SystemChangesForSoapSerizlizationCompatibility.patch ___ Mono-devel-list mailing list

[Mono-dev] [PATCH] Fix of Parsing Uri path on Windows

2007-11-25 Thread Arina Itkes
Hi all, Please review this fix. SystemUri.patch Description: SystemUri.patch SystemTestUri.patch Description: SystemTestUri.patch ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com

Re: [Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety fix.

2007-11-27 Thread Arina Itkes
Please review additional fix for Url get property. Now it supported by NET_1_1 too. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Arina Itkes Sent: Thursday, November 15, 2007 2:57 PM To: mono-devel Subject: [Mono-dev] [PATCH] SoapHttpClientProtocol

Re: [Mono-dev] [PATCH] System changes for SOAP serialization compatibility with .NET

2007-11-29 Thread Arina Itkes
for SOAP serialization compatibility with .NET Hi Arina, Arina Itkes wrote: Hi Please review the changes for SOAP serialization compatibility with .NET. Please assure that historical data serialized with the old version is still consumable by the new version, when possible, i.e. the class

[Mono-dev] [PATCH] Fix for RegEx parser.

2007-11-29 Thread Arina Itkes
Hi, I've added a new set of tests for regular expressions and a correction to the parser.cs for passing the test PerlTest.Trial0990(). Please review the attached patch. Thanks. Regex.patch Description: Regex.patch ___ Mono-devel-list

Re: [Mono-dev] [PATCH] SoapHttpClientProtocol Thread Safety fix.

2007-12-02 Thread Arina Itkes
is the Uri change related to the thread safety issue? I know that your patch had included the change. I was asking for the reason why. Atsushi Eno Arina Itkes wrote: Fix for thread safety had included changes in Url property. It was made with calling to property supported only by net 2.0. Now

[Mono-dev] [PATCH] Refactoring of WebClient

2007-12-18 Thread Arina Itkes
Hi I did a refactoring for the WebClient class for compatibility purpose (The type IntPtr is not supported in JAVA PROFILE). Please review and approve. Thanks. WebClient.patch Description: WebClient.patch ___ Mono-devel-list mailing list

[Mono-dev] [PATCH] System.ComponentModel.Design.CheckoutException

2007-12-23 Thread Arina Itkes
Hello, Please review the patch. It includes small change for ctors of CheckoutException: CheckoutException should not be initialized with ErrorCode = 0 by default. Thanks. CheckoutExceptionCtor.patch Description: CheckoutExceptionCtor.patch

Re: [Mono-dev] [PATCH] WebMethods with SOAPAction =

2007-12-27 Thread Arina Itkes
. Arina. -Original Message- From: Atsushi Eno [mailto:[EMAIL PROTECTED] Sent: Thursday, December 27, 2007 10:38 AM To: Arina Itkes Cc: mono-devel-list@lists.ximian.com Subject: Re: [Mono-dev] [PATCH] WebMethods with SOAPAction = Hi, What is the real issue that you want to solve? Without

Re: [Mono-dev] [PATCH] WebMethods with SOAPAction =

2007-12-31 Thread Arina Itkes
Hi, A wsdl file generated by a web service on IIS that has a method with SOAPAction == is attached. Regards, Arina. -Original Message- From: Gert Driesen [mailto:[EMAIL PROTECTED] Sent: Thursday, December 27, 2007 12:28 PM To: 'Atsushi Eno'; Arina Itkes Cc: mono-devel-list

[Mono-dev] [PATCH] DataTable IXmlSerializable.WriteXml

2008-01-22 Thread Arina Itkes
Hi all, I added new Nunit tests for DataTable class and changed the implementation of IXmlSerializable.WriteXml() in DataTable that fixes these tests failures. Please review. Arina. ___ Mono-devel-list mailing list

[Mono-dev] [PATCH] XmlSchemeExporter for typed DataTable

2008-01-29 Thread Arina Itkes
Hi I added a new test for exporting of a typed DataTable and a typed DataSet by the same XmlSchemaExporter and a fix for the XmlSchemaExporter. Generated typed DataTable and typed DataSet have an identical schema and an identical TargetNamespace. This fix is a workaround for this specific

[Mono-dev] [PATCH] IXmlSerializable.ReadXml fix.

2008-01-29 Thread Arina Itkes
Hi all, I fixed IXmlSerializable.ReadXml implementation in the DataTable class. And removed Ignore attribute from the tests that failed before this fix. Please review. Thanks. SystemDataReadXml.patch Description: SystemDataReadXml.patch ___

Re: [Mono-dev] [PATCH] XmlSchemeExporter for typed DataTable

2008-02-03 Thread Arina Itkes
...? http://www.mono-project.com/Coding_Guidelines Atsushi Eno Arina Itkes wrote: Hi I added a new test for exporting of a typed DataTable and a typed DataSet by the same XmlSchemaExporter and a fix for the XmlSchemaExporter. Generated typed DataTable and typed DataSet have

[Mono-dev] [PATCH] System.Xml.Xsl standalone tests fix.

2008-02-13 Thread Arina Itkes
Hi Please review the patch for fixing standalone tests in System.Xml.Xsl: attribset_attribset24 and attribset_attribset40. Thanks, Arina. System.Xml.Attr.patch Description: System.Xml.Attr.patch ___ Mono-devel-list mailing list