Re: [Mono-dev] nunit test upgrading task force

2009-06-25 Thread Robert Jordan
Same for corlib/Test/System.IO/*. Robert Atsushi Eno wrote: Done. Thanks! Atsushi Eno Robert Jordan wrote: Atsushi, Atsushi Eno wrote: * list of the files I have made an easy list of such old test files on a spreadsheet:

Re: [Mono-dev] nunit test upgrading task force

2009-06-25 Thread Levi Campbell
Here's my portion of the upgrading, I've included the patches with this e-mail using the latest sources from SVN. -- Levi Campbell levicc00...@gmail.com GPG key ID: 7710A5E7 patches.tar.bz2 Description: BZip2 compressed data ___ Mono-devel-list

Re: [Mono-dev] nunit test upgrading task force

2009-06-25 Thread Atsushi Eno
Hi, Those sources are already converted to the new styles and your changes rather revert them. And most of the files in the bz archive are empty. Atsushi Eno Levi Campbell wrote: Here's my portion of the upgrading, I've included the patches with this e-mail using the latest sources from SVN.

Re: [Mono-dev] nunit test upgrading task force

2009-06-24 Thread Atsushi Eno
Thanks Charlie. It is good to know that it does not likely to be much more tasks to do for upgrading. On the other hand I was under the impression that those obsoleted ones lived in 2.5 - the conversion work is likely needed more. BTW for those who join the upgrading, Zoltan has a script of

Re: [Mono-dev] nunit test upgrading task force

2009-06-24 Thread Robert Jordan
Atsushi, Atsushi Eno wrote: * list of the files I have made an easy list of such old test files on a spreadsheet: http://spreadsheets.google.com/pub?key=rkWl-ZQHJvcu6tkJOeFFg3Aoutput=html I've fixed all Test/System.Collections/*.cs in r136771 but I'm apparently too dumb to edit the

Re: [Mono-dev] nunit test upgrading task force

2009-06-24 Thread Charlie Poole
Thanks Charlie. It is good to know that it does not likely to be much more tasks to do for upgrading. On the other hand I was under the impression that those obsoleted ones lived in 2.5 - the conversion work is likely needed more. From the release notes... * The following obsolete

Re: [Mono-dev] nunit test upgrading task force

2009-06-24 Thread Atsushi Eno
Done. Thanks! Atsushi Eno Robert Jordan wrote: Atsushi, Atsushi Eno wrote: * list of the files I have made an easy list of such old test files on a spreadsheet: http://spreadsheets.google.com/pub?key=rkWl-ZQHJvcu6tkJOeFFg3Aoutput=html I've fixed all Test/System.Collections/*.cs in

[Mono-dev] nunit test upgrading task force

2009-06-23 Thread Atsushi Eno
Hi, I'm thinking if we can upgrade our nunit tests to eliminate derivation from Assertion (such as eliminating AssertEquals), to make our tests ready for future versions of NUnit. The task is very easy: if there is a test class that looks like [TestFixture] public class FooTest :

Re: [Mono-dev] nunit test upgrading task force

2009-06-23 Thread Stifu
We could automate the change using a regexp and do a massive replace, no? Using Notepad++ (http://notepad-plus.sourceforge.net/uk/regExpList.php), this seems to work fine: Find: AssertEquals \((.+[^,]),(.+[^,]), (.+[^,])\); Replace with: Assert.AreEqual (\2, \3, \1); Needs a bit more work to

Re: [Mono-dev] nunit test upgrading task force

2009-06-23 Thread Robert Jordan
Stifu wrote: We could automate the change using a regexp and do a massive replace, no? Using Notepad++ (http://notepad-plus.sourceforge.net/uk/regExpList.php), this seems to work fine: Find: AssertEquals \((.+[^,]),(.+[^,]), (.+[^,])\); Replace with: Assert.AreEqual (\2, \3, \1);

Re: [Mono-dev] nunit test upgrading task force

2009-06-23 Thread Stifu
Well, I don't have write access myself, so just giving ideas. Robert Jordan wrote: I believe Atsushi does not care how this conversion is performed as long as he doesn't have to do on his own. You may use a regexp or a farm of typing monkeys as long you just do it (TM) :) Robert --

Re: [Mono-dev] nunit test upgrading task force

2009-06-23 Thread Levi Campbell
I'd be more than happy to help with the upgrade, just tell me which ones you want me to do. -- Levi Campbell levicc00...@gmail.com GPG key ID: 7710A5E7 Casey Stengelhttp://www.brainyquote.com/quotes/authors/c/casey_stengel.html - All right everyone, line up alphabetically according to your

Re: [Mono-dev] nunit test upgrading task force

2009-06-23 Thread Atsushi Eno
Oh, yes Robert is right. I haven't actually tried if it automated rewrite is possible (and safe). If it is possible just with a script, that's awesome :) Just put patches and script somewhere (you don't need write access for that). Atsushi Eno Stifu wrote: Well, I don't have write access

Re: [Mono-dev] nunit test upgrading task force

2009-06-23 Thread Atsushi Eno
Thanks! I have added you to the spreadsheet editor. Please pick blank ones, mark as yours (you are going to change), and start upgrading. Atsushi Eno Levi Campbell wrote: I'd be more than happy to help with the upgrade, just tell me which ones you want me to do. -- Levi Campbell

Re: [Mono-dev] nunit test upgrading task force

2009-06-23 Thread Atsushi Eno
Rodrigo gave another input that we will have to add [Test] and [TestFixture] in case they are missing. Atsushi Eno Atsushi Eno wrote: Oh, yes Robert is right. I haven't actually tried if it automated rewrite is possible (and safe). If it is possible just with a script, that's awesome :) Just

Re: [Mono-dev] nunit test upgrading task force

2009-06-23 Thread Charlie Poole
-list-boun...@lists.ximian.com [mailto:mono-devel-list-boun...@lists.ximian.com] On Behalf Of Atsushi Eno Sent: Monday, June 22, 2009 11:35 PM To: mono-devel-list@lists.ximian.com; Mono Mailing List Subject: [Mono-dev] nunit test upgrading task force Hi, I'm thinking if we can upgrade