Re: [Mono-dev] Review of PR1354 - add Request.Abort()

2014-10-19 Thread Martin Thwaites
Thanks Miguel,

From the documentation, it simply says it throws an exception if not
integrated so that should be simple to add.  I wasn't aware that the
pipelines existed in mono which is why I've not done it.  Is there an
example of doing a check that you know of off the top of your head?

In terms of usage, it's used in the WebAPI/MVC, and doesn't appear to be
malicious related so maybe it's being misused there.  I would imagine
though that it's around theory of keeping connections open to the server
(probably for something like websockets?).

Thanks,
Martin

On 19 October 2014 00:56, Miguel de Icaza mig...@xamarin.com wrote:

 Hey Martin,

 Thanks for the patch;   The documentation describes that this has two
 behaviors depending on the pipeline mode in use:


 http://msdn.microsoft.com/en-us/library/system.web.httprequest.abort(v=vs.110).aspx

 It might be good to find out if there are other things that this call
 should do beyond closing the connection.  It seems like it was intended to
 be used against a malicious HTTP client (which I have no information about
 what they mean by this).



 On Sat, Oct 18, 2014 at 5:40 PM, Martin Thwaites monofo...@my2cents.co.uk
  wrote:

 Hi all,

 I've just submitted a pull to add Request.Abort() to the HttpRequest
 class.  It simply calls CloseConnection on the worker request so it's
 pretty simple.

 I'm not sure how to add a unit test for this so any help would be
 appreciated.

 This is for the work I'm doing on getting the aspnetwebstack working.

 https://github.com/mono/mono/pull/1354

 Thanks
 Martin

 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list



___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list


Re: [Mono-dev] Review of PR1354 - add Request.Abort()

2014-10-18 Thread Miguel de Icaza
Hey Martin,

Thanks for the patch;   The documentation describes that this has two
behaviors depending on the pipeline mode in use:

http://msdn.microsoft.com/en-us/library/system.web.httprequest.abort(v=vs.110).aspx

It might be good to find out if there are other things that this call
should do beyond closing the connection.  It seems like it was intended to
be used against a malicious HTTP client (which I have no information about
what they mean by this).



On Sat, Oct 18, 2014 at 5:40 PM, Martin Thwaites monofo...@my2cents.co.uk
wrote:

 Hi all,

 I've just submitted a pull to add Request.Abort() to the HttpRequest
 class.  It simply calls CloseConnection on the worker request so it's
 pretty simple.

 I'm not sure how to add a unit test for this so any help would be
 appreciated.

 This is for the work I'm doing on getting the aspnetwebstack working.

 https://github.com/mono/mono/pull/1354

 Thanks
 Martin

 ___
 Mono-devel-list mailing list
 Mono-devel-list@lists.ximian.com
 http://lists.ximian.com/mailman/listinfo/mono-devel-list


___
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list