Re: [Monotone-devel] Monotone Commit Template (Patches)

2007-10-12 Thread Ralf S. Engelschall
On Thu, Sep 27, 2007, Pablo Delgado wrote: [...] So I went ahead after a few days of looking around in the code and decided to hack away at it. [...] The behavior is as follows, First it reads the .mtn-message if it exist. If it is not empty then it inserts the contents of the file into

[Monotone-devel] Monotone Commit Template (Patches)

2007-09-27 Thread Pablo Delgado
OK, So I went ahead after a few days of looking around in the code and decided to hack away at it. I made sure to follow the formatting and coding style and the naming scheme. Attached or 3 patches for the files that I changed and below is a small description of the changes. 1) work.hh work.cc

Re: [Monotone-devel] Monotone Commit Template

2007-09-24 Thread Pablo Delgado
Nathaniel Smith wrote: On Sun, Sep 23, 2007 at 06:45:14PM +0200, Ralf S. Engelschall wrote: On Sun, Sep 23, 2007, Nathaniel Smith wrote: This is broken, unfortunately -- e.g., if the user starts a commit, aborts it, then tries again, they will end up with multiple copies of the

Re: [Monotone-devel] Monotone Commit Template

2007-09-23 Thread Ralf S. Engelschall
On Sat, Sep 22, 2007, Timothy Brownawell wrote: On Sat, 2007-09-22 at 22:25 -0600, Pablo Delgado wrote: Someone recommended that I started working on something that I feel bothers me or I need. Well, one of thing I miss is the commit templating capability that cvs has. This feature allows

Re: [Monotone-devel] Monotone Commit Template

2007-09-23 Thread Ralf S. Engelschall
On Sun, Sep 23, 2007, Ralf S. Engelschall wrote: On Sat, Sep 22, 2007, Timothy Brownawell wrote: On Sat, 2007-09-22 at 22:25 -0600, Pablo Delgado wrote: Someone recommended that I started working on something that I feel bothers me or I need. Well, one of thing I miss is the commit

Re: [Monotone-devel] Monotone Commit Template

2007-09-23 Thread Markus Schiltknecht
Hello Pablo, I'm not quite sure what exactly the use case for such a template is. The example you gave is certainly not convincing: Pablo Delgado wrote: Example: PR Number: A Purchase Requisition number? Or what's that PR supposed to mean? Anyway, IMO it's better practice to add

Re: [Monotone-devel] Monotone Commit Template

2007-09-23 Thread Timothy Brownawell
On Sun, 2007-09-23 at 17:45 +0200, Markus Schiltknecht wrote: Hello Pablo, I'm not quite sure what exactly the use case for such a template is. The example you gave is certainly not convincing: Pablo Delgado wrote: Example: PR Number: A Purchase Requisition number? Or what's

Re: [Monotone-devel] Monotone Commit Template

2007-09-23 Thread Nathaniel Smith
On Sun, Sep 23, 2007 at 02:12:33PM +0200, Ralf S. Engelschall wrote: Searching the parent dirs might be not the best idea. Agreed. For the remaining functionality the following does the trick for me: Index: std_hooks.lua --- std_hooks.lua 6ca29b67a6913342668b4cfa2464a37654615280 +++

Re: [Monotone-devel] Monotone Commit Template

2007-09-23 Thread Ralf S. Engelschall
On Sun, Sep 23, 2007, Nathaniel Smith wrote: On Sun, Sep 23, 2007 at 02:12:33PM +0200, Ralf S. Engelschall wrote: Index: std_hooks.lua --- std_hooks.lua 6ca29b67a6913342668b4cfa2464a37654615280 +++ std_hooks.lua 3852a7038c60e2389b3d1438906439794999d443 @@ -271,6 +271,13 @@ function

Re: [Monotone-devel] Monotone Commit Template

2007-09-23 Thread Nathaniel Smith
On Sun, Sep 23, 2007 at 06:45:14PM +0200, Ralf S. Engelschall wrote: On Sun, Sep 23, 2007, Nathaniel Smith wrote: This is broken, unfortunately -- e.g., if the user starts a commit, aborts it, then tries again, they will end up with multiple copies of the template in their log message.

Re: [Monotone-devel] Monotone Commit Template

2007-09-23 Thread Markus Schiltknecht
Hi Timothy, Timothy Brownawell wrote: Maybe, maybe not. Somewhat easier to do complex processing perhaps, but harder to do simple things like look at the log and see what's changed since $foo. That's only because we don't have the proper interface for such things. So yes, as a work around

Re: [Monotone-devel] Monotone Commit Template

2007-09-23 Thread Pablo Delgado
Markus Schiltknecht wrote: Hello Pablo, I'm not quite sure what exactly the use case for such a template is. The example you gave is certainly not convincing: Pablo Delgado wrote: Example: PR Number: A Purchase Requisition number? Or what's that PR supposed to mean? Anyway, IMO it's

[Monotone-devel] Monotone Commit Template

2007-09-22 Thread Pablo Delgado
Hi Everyone, [name] recommended that I started working on something that I feel bothers me or I need. Well, one of this things is the commit templating capability that cvs has. This feature allows the repository manager to establish the basic structure of the commit message. This helps obvioudly

[Monotone-devel] Monotone Commit Template

2007-09-22 Thread Pablo Delgado
This message was submitted incomplete to the accidently pressing enter on this keyboard. Here is the email as it was inteded to go out. -- Email Hi Everyone, Someone recommended that I started working on something that I feel bothers me or I need. Well, one of thing I miss is the commit

Re: [Monotone-devel] Monotone Commit Template

2007-09-22 Thread Timothy Brownawell
On Sat, 2007-09-22 at 22:25 -0600, Pablo Delgado wrote: Someone recommended that I started working on something that I feel bothers me or I need. Well, one of thing I miss is the commit templating capability that cvs has. This feature allows the repository manager or project leader to