Re: [Monotone-devel] 3rd party libraries

2008-10-25 Thread Stephen Leake
Matthew Nicholson [EMAIL PROTECTED] writes: Zack Weinberg wrote: On Thu, Oct 23, 2008 at 3:38 AM, Markus Wanner [EMAIL PROTECTED] wrote: * lua: pretty similar to sqlite, except the source inclusion variant is a bit more complicated. I'm all for dynamic linking and don't see much of a

Re: [Monotone-devel] 3rd party libraries

2008-10-25 Thread Markus Wanner
Hi, Stephen Leake wrote: I'm confused. Your question confuses me too ;-) You seem to be implying that a dynamically linked object file cannot be compiled with a C++ compiler. Is that correct? An object file *is* compiled, it can only be linked against other compiled objects. The difference

Re: [Monotone-devel] 3rd party libraries

2008-10-25 Thread Stephen Leake
Markus Wanner [EMAIL PROTECTED] writes: Stephen Leake wrote: You seem to be implying that a dynamically linked object file cannot be compiled with a C++ compiler. Is that correct? An object file *is* compiled, it can only be linked against other compiled objects. Obviously we don't want

Re: [Monotone-devel] 3rd party libraries

2008-10-25 Thread Zack Weinberg
On Sat, Oct 25, 2008 at 4:52 AM, Stephen Leake [EMAIL PROTECTED] wrote: Markus Wanner [EMAIL PROTECTED] writes: Stephen Leake wrote: You seem to be implying that a dynamically linked object file cannot be compiled with a C++ compiler. Is that correct? An object file *is* compiled, it can

[Monotone-devel] compilation failure on Win32 MinGW

2008-10-25 Thread Stephen Leake
compile on Win32 MinGW is failing with: make[3]: *** No rule to make target `../monotone/botan/big_base.cpp', needed by `botan/lib3rdparty_a-big_base.o'. Stop. Is that a generated file, or did it just not get checked in? -- -- Stephe ___

Re: [Monotone-devel] compilation failure on Win32 MinGW

2008-10-25 Thread Stephen Leake
Stephen Leake [EMAIL PROTECTED] writes: compile on Win32 MinGW is failing with: in branch net.venge.monotone make[3]: *** No rule to make target `../monotone/botan/big_base.cpp', needed by `botan/lib3rdparty_a-big_base.o'. Stop. Is that a generated file, or did it just not get checked

Re: [Monotone-devel] 3rd party libraries

2008-10-25 Thread Markus Wanner
Hi, Stephen Leake wrote: Obviously we don't want to re-compile the system library. But is there some reason it wasn't compiled with C++ in the first place? Uh.. because if compiled by a C compiler, it's still usable from C++, but not the other way around, AFAICT. Besides, I'd guess there are

Re: [Monotone-devel] compilation failure on Win32 MinGW

2008-10-25 Thread Markus Wanner
Hi, Stephen Leake wrote: Stephen Leake [EMAIL PROTECTED] writes: compile on Win32 MinGW is failing with: in branch net.venge.monotone make[3]: *** No rule to make target `../monotone/botan/big_base.cpp', needed by `botan/lib3rdparty_a-big_base.o'. Stop. Hm.. did you run 'make

Re: [Monotone-devel] 3rd party libraries

2008-10-25 Thread Stephen Leake
Zack Weinberg [EMAIL PROTECTED] writes: On Sat, Oct 25, 2008 at 4:52 AM, Stephen Leake [EMAIL PROTECTED] wrote: Markus Wanner [EMAIL PROTECTED] writes: Stephen Leake wrote: You seem to be implying that a dynamically linked object file cannot be compiled with a C++ compiler. Is that correct?

Re: [Monotone-devel] compilation failure on Win32 MinGW

2008-10-25 Thread Stephen Leake
Markus Wanner [EMAIL PROTECTED] writes: Hi, Stephen Leake wrote: Stephen Leake [EMAIL PROTECTED] writes: compile on Win32 MinGW is failing with: in branch net.venge.monotone make[3]: *** No rule to make target `../monotone/botan/big_base.cpp', needed by

Re: [Monotone-devel] nvm.dates

2008-10-25 Thread Stephen Leake
Markus Wanner [EMAIL PROTECTED] writes: I'm considering nvm.dates ready to land on mainline. All it does is using a 64 bit integer to represent dates internally, so that date_t now provides comparison and difference operators on these timestamps. It does not alter the textual representation

Re: [Monotone-devel] nvm.dates

2008-10-25 Thread Markus Wanner
Hi, thank you for your review. Stephen Leake wrote: So I think keeping date unsigned is ok, but please document this rationale in dates.hh. Okay, will do. One reason for using unsigned is that a single $DATE $MAX is sufficient in valid(), whereas with a signed integer we'd have two

Re: [Monotone-devel] Lua loading dynamic libraries not possible in monotone?

2008-10-25 Thread Daniel Carosone
On Fri, Oct 24, 2008 at 01:28:50PM -0700, Zack Weinberg wrote: On Fri, Oct 24, 2008 at 1:19 PM, Markus Wanner [EMAIL PROTECTED] wrote: However, I don't quite understand why it should be a security issue. All hooks are user defined, so what should preventing dynamic loading protect against?

Re: [Monotone-devel] 3rd party libraries

2008-10-25 Thread Florian Weimer
* Zack Weinberg: * pcre, idna: I'm not too sure about these, but dynamic linking seems to make more sense. I didn't hit any stumbling block so far in nvm.stripped. Concur. API/ABI stability shouldn't be an issue with these. The PCRE C++ API/ABI is not stable, and the regexp syntax isn't,

Re: [Monotone-devel] compilation failure on Win32 MinGW

2008-10-25 Thread Stephen Leake
compile on n.v.m Win32 MinGW is failing with: ../monotone/botan/es_dev.cpp:7:24: sys/select.h: No such file or directory followed by more errors in the same file. MinGW doesn't have 'sys/select.h'. Previously, this file was not compiled on Win32. The problem is in Makefile.am BOTAN_SOURCES;

[Monotone-devel] new test --no-workspace

2008-10-25 Thread Stephen Leake
The new test '--no-workspace' fails on MinGW. I'm not clear where the exact problem is; I get this message: unrecognized option '--no-workspace'error: incorrect self-invocation; -r abs path to lua-testsuite.lua abs path to tester_dir test There are other test directories whose names start with

Re: [Monotone-devel] 3rd party libraries

2008-10-25 Thread Zack Weinberg
On Sat, Oct 25, 2008 at 2:17 PM, Florian Weimer [EMAIL PROTECTED] wrote: * pcre, idna: I'm not too sure about these, but dynamic linking seems to make more sense. I didn't hit any stumbling block so far in nvm.stripped. Concur. API/ABI stability shouldn't be an issue with these. The PCRE

Re: [Monotone-devel] new test --no-workspace

2008-10-25 Thread Zack Weinberg
On Sat, Oct 25, 2008 at 3:08 PM, Stephen Leake [EMAIL PROTECTED] wrote: The new test '--no-workspace' fails on MinGW. I'm not clear where the exact problem is; I get this message: unrecognized option '--no-workspace'error: incorrect self-invocation; -r abs path to lua-testsuite.lua abs path

[Monotone-devel] nvm.dates review

2008-10-25 Thread Zack Weinberg
diff -ruN S-vanilla/dates.hh S-dates/dates.hh --- S-vanilla/dates.hh 2008-05-13 20:07:26.693813111 -0700 +++ S-dates/dates.hh2008-10-25 17:07:22.986962447 -0700 @@ -19,31 +19,62 @@ struct date_t { - // For the benefit of the --date option. - date_t() : d() {} - bool valid() const {