Hi,
Zack Weinberg wrote:
Implemented now and pushed as
81798740507c3414f4833a7451f9b559ca03a167, with tests even.
Wow, cool, thanks!
Markus
___
Monotone-devel mailing list
Monotone-devel@nongnu.org
On 4/14/07, Zack Weinberg [EMAIL PROTECTED] wrote:
I'm going to suggest write_data_userprivate(), with the same interface
as write_data(), implemented entirely in platform/, and (on Unix)
using 3-argument open() so the file permissions are right from the
moment it's created.
Implemented now
Nathaniel Smith [EMAIL PROTECTED] writes:
On Wed, Apr 11, 2007 at 08:16:38PM +0200, Markus Schiltknecht wrote:
--- key_store.cc70b97a9e2a06654ec641a1709c2a875cdfa603d5
+++ key_store.ccfda46d5fa8a5b2a52421c1f83413a208e2c6401f
@@ -1,4 +1,5 @@
#include sstream
+#include
On Sat, Apr 14, 2007 at 01:27:33PM -0400, Stephen Leake wrote:
This is my first time compiling monotone. Looking thru other code, it
seems the correct fix might be:
[...]
+#ifndef WIN32
+ // umask not in MinGW. We assume MinGW boxes have single users, so
+ // this doesn't matter.
mode_t
On 4/14/07, Nathaniel Smith [EMAIL PROTECTED] wrote:
[...]
...Except that the unix version needs a field in there to temporarily
stash the old umask. After a little more looking around, it might be
far smarter to use fchmod(2) (inside an appropriate platform.hh
wrapper, of course) than to mess
On Wed, Apr 11, 2007 at 12:17:16PM -0700, Nathaniel Smith wrote:
On Wed, Apr 11, 2007 at 08:16:38PM +0200, Markus Schiltknecht wrote:
--- key_store.cc70b97a9e2a06654ec641a1709c2a875cdfa603d5
+++ key_store.ccfda46d5fa8a5b2a52421c1f83413a208e2c6401f
@@ -1,4 +1,5 @@
#include
Hi,
please, someone who's more into UNIX file permissions and C++ style,
review revision a40d623653f3e9db83553ee2b9ecbd4f2b5a81f0 which I've just
committed. It should fix bug # 19137.
There are only very few changes, thus I've copied them below for having
a quick look.
Thanks.
Markus
On Wed, Apr 11, 2007 at 08:16:38PM +0200, Markus Schiltknecht wrote:
--- key_store.cc70b97a9e2a06654ec641a1709c2a875cdfa603d5
+++ key_store.ccfda46d5fa8a5b2a52421c1f83413a208e2c6401f
@@ -1,4 +1,5 @@
#include sstream
+#include sys/stat.h
#include key_store.hh
#include
