Re: [MP3 ENCODER] Bug of long block pre-echo control

2000-10-04 Thread Robert Hegemann

Mark Powell schrieb am Mit, 04 Okt 2000:
> On Wed, 4 Oct 2000, Naoki Shibata wrote:
> 
> >   I found a bug in the long block pre-echo control code.
> >   This code should be fixed like this.
> > 
> > if (gfc->blocktype_old[gfp->mode == MPG_MD_JOINT_STEREO ? 0 : chn] == SHORT_TYPE )
> 
> Naoki,
>   Did this affect quality? I just folded this change back into my own
> v3.87, as v3.88 doesn't compile at the moment. It reduced a VBR file from
> 181.5Kbps down to 177.3Kbps. Is this to be expected?
>   Cheers.

I would say: YES, it affects quality; it may sometimes result in 
smaller, somtimes in larger VBR files (I haven't investigated this).

Ciao Robert


--
MP3 ENCODER mailing list ( http://geek.rcc.se/mp3encoder/ )



Re: [MP3 ENCODER] Bug of long block pre-echo control

2000-10-04 Thread Mark Powell

On Wed, 4 Oct 2000, Naoki Shibata wrote:

>   I found a bug in the long block pre-echo control code.
>   This code should be fixed like this.
> 
> if (gfc->blocktype_old[gfp->mode == MPG_MD_JOINT_STEREO ? 0 : chn] == SHORT_TYPE )

Naoki,
  Did this affect quality? I just folded this change back into my own
v3.87, as v3.88 doesn't compile at the moment. It reduced a VBR file from
181.5Kbps down to 177.3Kbps. Is this to be expected?
  Cheers.

Mark Powell - UNIX System Administrator - The University of Salford
Academic Information Services, Clifford Whitworth Building,
Salford University, Manchester, M5 4WT, UK.
Tel: +44 161 295 5936  Fax: +44 161 295 5888  www.pgp.com for PGP key

--
MP3 ENCODER mailing list ( http://geek.rcc.se/mp3encoder/ )