Re: [mpd-devel] [PATCH] Add support for ArtistSort and AlbumArtistSort tags

2015-08-24 Thread Stefan Monnier
> I can see your point when moving "The" and replacing "&" with "and", but how > would your rewrite rules handle rewriting "John Lennon" to "Lennon, John"? Indeed, they probably wouldn't. Stefan ___ mpd-devel mailing list mpd-devel@musicpd.org

Re: [mpd-devel] [PATCH] Add support for ArtistSort and AlbumArtistSort tags

2015-08-23 Thread Max Kellermann
On 2015/08/21 16:52, Kim Tore Jensen wrote: > Thanks. See attached patch. Merged ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] Add support for ArtistSort and AlbumArtistSort tags

2015-08-23 Thread Kim Tore Jensen
Hi Stefan, On Thu, Aug 20, 2015 at 09:09:24AM -0400, Stefan Monnier wrote: > - A handful of rewrite rules would probably be able to correctly > generate 99.9% of the ArtistSort and AlbumArtistSort tags you > might need. I can see your point when moving "The" and replacing "&" with "and", but

Re: [mpd-devel] [PATCH] Add support for ArtistSort and AlbumArtistSort tags

2015-08-23 Thread Kim Tore Jensen
On Thu, Aug 20, 2015 at 03:11:52PM +0200, Max Kellermann wrote: > On 2015/08/20 13:21, Kim Tore Jensen wrote: > > Actually, yes. It'd be really useful to be able to manipulate search results > > locally in the client. For example: search within a search result with new > > sort > > parameters; re

Re: [mpd-devel] [PATCH] Add support for ArtistSort and AlbumArtistSort tags

2015-08-20 Thread Max Kellermann
On 2015/08/20 13:21, Kim Tore Jensen wrote: > Actually, yes. It'd be really useful to be able to manipulate search results > locally in the client. For example: search within a search result with new > sort > parameters; re-sort a search result with new sort order; regular expression > based sear

Re: [mpd-devel] [PATCH] Add support for ArtistSort and AlbumArtistSort tags

2015-08-20 Thread Kim Tore Jensen
On Thu, Aug 20, 2015 at 11:41:29AM +0200, Max Kellermann wrote: > On 2015/08/20 11:36, Kim Tore Jensen wrote: > > These tags are much needed in order to sort songs correctly at the client > > side, > > after having retrieved them from MPD using either a search or retrieving > > the library. > >

Re: [mpd-devel] [PATCH] Add support for ArtistSort and AlbumArtistSort tags

2015-08-20 Thread Stefan Monnier
>> These tags are much needed in order to sort songs correctly at the >> client side, after having retrieved them from MPD using either >> a search or retrieving the library. > I understand. If there was a way to sort search results server-side, > would you still need this feature? [ I personally

Re: [mpd-devel] [PATCH] Add support for ArtistSort and AlbumArtistSort tags

2015-08-20 Thread Max Kellermann
On 2015/08/20 11:36, Kim Tore Jensen wrote: > These tags are much needed in order to sort songs correctly at the client > side, > after having retrieved them from MPD using either a search or retrieving the > library. I understand. If there was a way to sort search results server-side, would y

Re: [mpd-devel] [PATCH] Add support for ArtistSort and AlbumArtistSort tags

2015-08-20 Thread Kim Tore Jensen
Hi Max, On Thu, Aug 20, 2015 at 10:35:35AM +0200, Max Kellermann wrote: > On 2015/08/19 22:26, Kim Tore Jensen wrote: > > I propose to add support for the ArtistSort and AlbumArtistSort tags in > > libmpdclient; see attached patch. > > These were left out of libmpdclient intentionally, because t

Re: [mpd-devel] [PATCH] Add support for ArtistSort and AlbumArtistSort tags

2015-08-20 Thread Max Kellermann
On 2015/08/19 22:26, Kim Tore Jensen wrote: > I propose to add support for the ArtistSort and AlbumArtistSort tags in > libmpdclient; see attached patch. These were left out of libmpdclient intentionally, because these tags appear to make sense only on the server side, for sorting. Adding them i

[mpd-devel] [PATCH] Add support for ArtistSort and AlbumArtistSort tags

2015-08-19 Thread Kim Tore Jensen
Hi, I propose to add support for the ArtistSort and AlbumArtistSort tags in libmpdclient; see attached patch. Best regards, Kim Tore Jensen diff --git a/include/mpd/tag.h b/include/mpd/tag.h index 48f7cfe..7e8c7c1 100644 --- a/include/mpd/tag.h +++ b/include/mpd/tag.h @@ -44,6 +44,8 @@ enum mpd_t