Re: [mpd-devel] [PATCH] sndio: Add option to select output device

2016-06-22 Thread Max Kellermann
On 2016/06/22 11:27, Dimitris Papastamos wrote: > On Wed, Jun 22, 2016 at 11:21:02AM +0200, Max Kellermann wrote: > > On 2016/06/22 11:10, Dimitris Papastamos wrote: > > > Must have been an oversight when I looked at other plugin code. > > > The patch below removes the timer usage. > > > > Pleas

Re: [mpd-devel] [PATCH] sndio: Add option to select output device

2016-06-22 Thread Dimitris Papastamos
On Wed, Jun 22, 2016 at 11:21:02AM +0200, Max Kellermann wrote: > On 2016/06/22 11:10, Dimitris Papastamos wrote: > > Must have been an oversight when I looked at other plugin code. > > The patch below removes the timer usage. > > Please rebase. I have conflicts. Oops, here it is. From 8b19f26

Re: [mpd-devel] [PATCH] sndio: Add option to select output device

2016-06-22 Thread Max Kellermann
On 2016/06/22 11:10, Dimitris Papastamos wrote: > Must have been an oversight when I looked at other plugin code. > The patch below removes the timer usage. Please rebase. I have conflicts. ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailma

Re: [mpd-devel] [PATCH] sndio: Add option to select output device

2016-06-22 Thread Dimitris Papastamos
On Wed, Jun 22, 2016 at 11:02:44AM +0200, Max Kellermann wrote: > On 2016/06/22 10:57, Dimitris Papastamos wrote: > > >From 43cb9a089363301636317446765f7ca689d6b8c5 Mon Sep 17 00:00:00 2001 > > From: sin > > Date: Wed, 22 Jun 2016 09:41:54 +0100 > > Subject: [PATCH] sndio: Add option to select ou

Re: [mpd-devel] [PATCH] sndio: Add option to select output device

2016-06-22 Thread Max Kellermann
On 2016/06/22 10:57, Dimitris Papastamos wrote: > >From 43cb9a089363301636317446765f7ca689d6b8c5 Mon Sep 17 00:00:00 2001 > From: sin > Date: Wed, 22 Jun 2016 09:41:54 +0100 > Subject: [PATCH] sndio: Add option to select output device Merged. I just noticed that you're using a Timer in your plu

Re: [mpd-devel] [PATCH] sndio: Add option to select output device

2016-06-22 Thread Dimitris Papastamos
On Wed, Jun 22, 2016 at 10:54:37AM +0200, Max Kellermann wrote: > On 2016/06/22 10:51, Dimitris Papastamos wrote: > > + device = block.GetBlockValue("device", nullptr); > > + if (!device) > > + device = SIO_DEVANY; > > Easier: > > device = block.GetBlockValue("device", SIO_DEVANY)

Re: [mpd-devel] [PATCH] sndio: Add option to select output device

2016-06-22 Thread Max Kellermann
On 2016/06/22 10:51, Dimitris Papastamos wrote: > + device = block.GetBlockValue("device", nullptr); > + if (!device) > + device = SIO_DEVANY; Easier: device = block.GetBlockValue("device", SIO_DEVANY); ___ mpd-devel mailing list m

[mpd-devel] [PATCH] sndio: Add option to select output device

2016-06-22 Thread Dimitris Papastamos
Hi, This option allows one to select the output device if they have more than one audio device. From 1c512d1302969155af94d478fcf0ce25098a07c2 Mon Sep 17 00:00:00 2001 From: sin Date: Wed, 22 Jun 2016 09:41:54 +0100 Subject: [PATCH 1/2] sndio: Add option to select output device --- src/output/p