Re: [mpd-devel] Was this change reverted by accident?
On Thu, 02 Mar, 2017 at 02:15:50 GMT, Ben Boeckel wrote: > Ah, indeed. Sorry for the noise. Heh, sorry for that (and this) noise; I got this thread mixed up with my other recent mpd mails. --Ben ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mpd-devel
Re: [mpd-devel] Was this change reverted by accident?
On Wed, Mar 01, 2017 at 19:43:12 +0100, Max Kellermann wrote: > It was not reverted - look what happens after these lines, now that > the "return" is removed. > > Hint: "git show -W 021519f" might be just enough context to understand > this commit. Ah, indeed. Sorry for the noise. --Ben ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mpd-devel
Re: [mpd-devel] Was this change reverted by accident?
On 2017/02/27 17:22, Eric Wollesen wrote: > It was merged, but then immediately it seems to have been reverted in this > commit: > > 021519f command/QueueCommands: eliminate duplicate code in > handle_addid() It was not reverted - look what happens after these lines, now that the "return" is removed. Hint: "git show -W 021519f" might be just enough context to understand this commit. ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mpd-devel
[mpd-devel] Was this change reverted by accident?
Max, Last year, I submitted a github pull request[1], which resulted in this commit: 81a198a return id for "addid" with position It was merged, but then immediately it seems to have been reverted in this commit: 021519f command/QueueCommands: eliminate duplicate code in handle_addid() If this was a simple mistake, then I can easily re-submit a pull request if you'd like. If not, may I know why? Thank you, Eric 1: https://github.com/MaxKellermann/MPD/pull/8 -- er...@xmtp.net ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mpd-devel