Re: [Mscore-developer] Reviewing Code

2014-10-19 Thread Joachim Schmitz
I’ve now submitted a PR for this. I wasn’t too sure how best to fix it, but now I’ll go for LEFT|TOP Bye, Jojo From: Nalin Goel [mailto:[email protected]] Sent: Sunday, October 19, 2014 3:47 PM To: [email protected] Subject: [Mscore-developer] Reviewing Code

Re: [Mscore-developer] Reviewing Code

2014-10-19 Thread Lasconic
Hi Nalin, The best way to contribute a change is via Git. See http://musescore.org/en/developers-handbook/git-workflow If you need help with this workflow, feel free to ask here or on IRC #musescore on freenode.net https://kiwiirc.com/client/irc.freenode.net/?nick=musescore|?#musescore lasconic

[Mscore-developer] Reviewing Code

2014-10-19 Thread Nalin Goel
Hi, I just fixed Issue #36971(Style for both Instrument Name And Lyricist collide). I am a newbie so just want to make sure if what I did really corrects the problem or not. I changed the line 271 (AlignmentFlags to LEFT And TOP) as mentioned in the issue. Here is the patch. Thank You. //===