Re: [Mspgcc-users] Incorrect TASSEL0/1 comments in msp430mcu headers

2011-10-04 Thread JMGross
Jasper, you'd be surprised how many incorrect comments I've seen over the years. I agree that finding them in an 'official' header file is rather surprising. And of course it raises questions about the correctness of the code they comment. Usually, it comes from a bug or typo that has been corr

Re: [Mspgcc-users] Incorrect TASSEL0/1 comments in msp430mcu headers

2011-10-01 Thread Peter Bigot
If somebody cares enough to create a ticket for it, I'll push it upstream. Mailing list posts don't remain open until addressed. Peter On Sat, Oct 1, 2011 at 3:59 AM, Jasper Lievisse Adriaanse wrote: > On Sat, Oct 01, 2011 at 01:25:26AM -0700, Eric Decker wrote: > > Hey Jasper, > > > > Thanks fo

Re: [Mspgcc-users] Incorrect TASSEL0/1 comments in msp430mcu headers

2011-10-01 Thread Jasper Lievisse Adriaanse
On Sat, Oct 01, 2011 at 01:25:26AM -0700, Eric Decker wrote: > Hey Jasper, > > Thanks for the find. > > Here is the situation > > First, these files come directly from TI and for maintanence and sanity > reasons we don't want to modify them. There is a very simple mod done at > the very fr

Re: [Mspgcc-users] Incorrect TASSEL0/1 comments in msp430mcu headers

2011-10-01 Thread Eric Decker
Hey Jasper, Thanks for the find. Here is the situation First, these files come directly from TI and for maintanence and sanity reasons we don't want to modify them. There is a very simple mod done at the very front which adds the define for TI_HEADERS. Peter takes care of that. And he m

[Mspgcc-users] Incorrect TASSEL0/1 comments in msp430mcu headers

2011-10-01 Thread Jasper Lievisse Adriaanse
Hi, it seems the comment in all the msp430mcu header files for TASSEL0 and TASSEL1 are swapped: #define TASSEL1 (0x0200) /* Timer A clock source select 0 */ #define TASSEL0 (0x0100) /* Timer A clock source select 1 */ though they should read: #define TASSEL1