[msysGit] Re: CRLF problems with Git on Win32

2008-01-08 Thread Junio C Hamano
Steffen Prohaska [EMAIL PROTECTED] writes: msysgit installs plain git. core.autocrlf is unset. Whatever plain git's default is, this is msysgit's default, too. That sounds like a mistake if you are installing a port to a platform whose native line ending convention is different from where

[msysGit] Re: CRLF problems with Git on Win32

2008-01-08 Thread Steffen Prohaska
On Jan 8, 2008, at 8:09 PM, J. Bruce Fields wrote: On Tue, Jan 08, 2008 at 07:58:57PM +0100, Steffen Prohaska wrote: On Jan 8, 2008, at 7:07 PM, Junio C Hamano wrote: Steffen Prohaska [EMAIL PROTECTED] writes: msysgit installs plain git. core.autocrlf is unset. Whatever plain

[msysGit] Re: CRLF problems with Git on Win32

2008-01-08 Thread Linus Torvalds
On Tue, 8 Jan 2008, Junio C Hamano wrote: I think the project can mark text files as text with attributes and if the port to the platform initialized core.autocrlf appropriately for the platform everything should work as you described. Yes, I think core.autocrlf should default to true on

[msysGit] Re: CRLF problems with Git on Win32

2008-01-08 Thread Robin Rosenberg
tisdagen den 8 januari 2008 skrev Junio C Hamano: It counts CR and CRLF and converts only when there are the same number of them. You probably only need to make it also count LF? Strictly speaking yes, but probably no anyway. Some tools on Windows keep existing line endings for existing

[msysGit] Re: CRLF problems with Git on Win32

2008-01-08 Thread Linus Torvalds
On Tue, 8 Jan 2008, Dmitry Potapov wrote: Perhaps, this option can be called core.autocrlf=safe We already do half of that: if (action == CRLF_GUESS) { /* * We're currently not going to even try to convert stuff * that has bare CR

[msysGit] Re: CRLF problems with Git on Win32

2008-01-08 Thread Sean
On Tue, 8 Jan 2008 13:31:57 -0800 (PST) Linus Torvalds [EMAIL PROTECTED] wrote: So the only thing you'd need to add is to add a /* No naked LF's! */ if (safecrlf stats.lf) return 0; to that sequence too, but the thing is, having mixed