Hi Jeff,
That's an old patch, Here attatched is the new one.
I was just writing the email to be sent to MTT-devel, now I think it's
better to put it in this thread.
===
--- lib/MTT/Common/GNU_Install.pm(revision 1271)
+++ li
Should this code rather be in a different .pm and the user selects
which one to use via the .ini file?
Yes, that's also what I thought. Then we need to change a little in
upper level, e.g. OMPI.pm, we should test the environment and
compiler, in order to choose the right install module (Gnu_
Hi Jeff,
I'm not sure about this. From what's written in the comment, restoring
%ENV is only for a 'make check' step, but we don't have such step for
cmake. That's why I skipped it.
I mention it because you're modifying LD_LIBRARY_PATH above -- so you
should restore it when you're done.
Ah
Hi Jeff,
Finally, I got everything ready in a patch. If it is fine, can I commit it?
Thanks,
Shiqing
Jeff Squyres wrote:
On Mar 11, 2009, at 11:49 AM, Shiqing Fan wrote:
> I mention it because you're modifying LD_LIBRARY_PATH above -- so you
> should restore it when you&#x
Hi Jeff,
Sorry for the carelessness. This time it looks better? :-)
Thanks,
Shiqing
Can you double check your cr / cr/lf settings? It looks like you're
committing in the windows format -- can you convert and commit in the
unix format? That way, it wouldn't look like the entire
GNU_Insta
ot;cygwin", "CYGWIN", "cygwin-2.0", etc.?
$sys_type =~ /cygwin/i
Other than that, it looks good to me.
-Ethan
On Mar 11, 2009, at 2:58 PM, Shiqing Fan wrote:
Hi Jeff,
Sorry for the carelessness. This time it looks better? :-)
Thanks,
Shiqing
Can
Hi Jeff,
Yes, I tried also via https and the same account/passwort as I use for
OMPI repository, but it's not working.
Thanks,
Shiqing
Jeff Squyres wrote:
Did you check out via https? We only allow commits to all OMPI SVN
repositories via https.
On Mar 12, 2009, at 5:10 AM, Shiqin
https.
On Mar 12, 2009, at 5:10 AM, Shiqing Fan wrote:
Hi Ethan and Jeff,
Thanks for all your help. Now it's been fixed and tested.
But it seems that I don't have permission to commit the patch ( I got
403 forbidden ). Any idea?
Thanks,
Shiqing
Index
I can commit it (OS
X Mail.app does weird things with the spacing of inlined patches :-( ).
On Mar 12, 2009, at 7:00 AM, Shiqing Fan wrote:
Here is some output of 'svn info':
Path: .
URL: https://svn.open-mpi.org/svn/mtt/trunk
Repository Root: https://svn.open-mpi.org/svn/mtt
n.org/~abarclay/Filesys-DiskFree-0.06/DiskFree.pm
(i.e., we wholly imported this module into MTT; we didn't write it)
On Mar 12, 2009, at 9:24 AM, Shiqing Fan wrote:
Hi Jeff,
No problem. I made a tarball for you. :-)
Thanks,
Shiqing
Jeff Squyres wrote:
> This could be an artifact of the ne
-o`;
if(($sys_type =~ /cygwin/i || $sys_type =~ /msys/i) &&
$config->{compiler_name} eq "microsoft") {
$install = MTT::Common::Cmake::Install($gnu);
} else {
$install = MTT::Common::GNU_Install::Install($gnu);
}
--
---
11 matches
Mail list logo
