[Mudlet-makers] [Bug 1537906] Re: installModule() crashes if Module Manager not open

2017-03-24 Thread Vadim Peretokin
** Changed in: mudlet Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mudlet Makers, which is subscribed to Mudlet. https://bugs.launchpad.net/bugs/1537906 Title: installModule() crashes if Module Manager not open Status in Mudlet

[Mudlet-makers] [Bug 1537906] Re: installModule() crashes if Module Manager not open

2016-02-03 Thread Stephen Lyons
Fix pulled into development (https://github.com/Mudlet/Mudlet/pull/291) AND release_30 branches (https://github.com/Mudlet/Mudlet/pull/292)! ** Changed in: mudlet Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mudlet Makers, which is

[Mudlet-makers] [Bug 1537906] Re: installModule() crashes if Module Manager not open

2016-01-27 Thread Stephen Lyons
** Changed in: mudlet Status: New => Confirmed ** Changed in: mudlet Assignee: (unassigned) => Stephen Lyons (slysven) ** Changed in: mudlet Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mudlet Makers, which is subscribed t

[Mudlet-makers] [Bug 1537906] Re: installModule() crashes if Module Manager not open

2016-01-25 Thread Stephen Lyons
Ah yeah - got it, the moduleTableVisible() call does not check that the (QTableWidget *)mudlet::moduleTable point is valid (and that pointer is not zeroed by an initialisation list in the mudlet class constructor anyhow). Workings on it now! -- You received this bug notification because you are

[Mudlet-makers] [Bug 1537906] Re: installModule() crashes if Module Manager not open

2016-01-25 Thread Stephen Lyons
I wonder how the details of the module widget is stored - perhaps a pointer that is not initialised to zero before the widget is instantiated - let me go and look... -- You received this bug notification because you are a member of Mudlet Makers, which is subscribed to Mudlet. https://bugs.launc

Re: [Mudlet-makers] [Bug 1537906] Re: installModule() crashes if Module Manager not open

2016-01-25 Thread Vadim Peretokin
Right - the crash is within the moduleTableVisible() function itself, specifically when it calls isVisible(). On Tue, Jan 26, 2016 at 8:25 AM Stephen Lyons wrote: > Ah, misread the function of that "if" - it is supposed to install the > package AND IF the module widget is present THEN it is refr

[Mudlet-makers] [Bug 1537906] Re: installModule() crashes if Module Manager not open

2016-01-25 Thread Stephen Lyons
Ah, misread the function of that "if" - it is supposed to install the package AND IF the module widget is present THEN it is refreshed to reflect the change - so that ISN'T the problem... *sigh* -- You received this bug notification because you are a member of Mudlet Makers, which is subscribed t

[Mudlet-makers] [Bug 1537906] Re: installModule() crashes if Module Manager not open

2016-01-25 Thread Stephen Lyons
The function concerned is: int TLuaInterpreter::installModule( lua_State * L) { string modName; if ( ! lua_isstring( L, 1 ) ) { lua_pushstring( L, "installModule: wrong first argument (should be a path to module)"); lua_error( L ); return 1; } else

[Mudlet-makers] [Bug 1537906] Re: installModule() crashes if Module Manager not open

2016-01-25 Thread Vadim Peretokin
** Summary changed: - Crash using installModule + installModule() crashes if Module Manager not open -- You received this bug notification because you are a member of Mudlet Makers, which is subscribed to Mudlet. https://bugs.launchpad.net/bugs/1537906 Title: installModule() crashes if Module