[Mudlet-makers] [Bug 1675988] Re: 3.0 regression: search field no longer stays visible

2017-03-31 Thread Vadim Peretokin
Migrating issues to Github, please follow the new discussion here: https://github.com/Mudlet/Mudlet/issues/508 This issue needs to be closed and there is no appropriate status, so will set it to "Opinion" just for migration purposes. ** Bug watch added: github.com/Mudlet/Mudlet/issues #508

[Mudlet-makers] [Bug 1675988] Re: 3.0 regression: search field no longer stays visible

2017-03-31 Thread Vadim Peretokin
Yes, let's put it into release_30 and then update development_merge_30 with it too: #1 feedback in some discussions on 3.0 is this change in behaviour Vadi - Yesterday at 4:02 PM Just about a week after 3.0. How's everyone going with it? Upgraded / not yet / love it / hate it / same ? Klendathu

Re: [Mudlet-makers] [Bug 1675988] Re: 3.0 regression: search field no longer stays visible

2017-03-26 Thread Vadim Peretokin
I'm not sure either. I was hoping to freeze release_30 so we can merge and be done with it. However the need to do a forthnightly update where we fix loading of 17, 18 map formats means that it won't really be frozen. I guess let's put it in, at the risk of starting a slippery slope that we just

[Mudlet-makers] [Bug 1675988] Re: 3.0 regression: search field no longer stays visible

2017-03-26 Thread Stephen Lyons
I have a PR to push out against the release_30 branch that does this but am not yet sure whether that is the place to request a pull against... -- You received this bug notification because you are a member of Mudlet Makers, which is subscribed to Mudlet. https://bugs.launchpad.net/bugs/1675988

[Mudlet-makers] [Bug 1675988] Re: 3.0 regression: search field no longer stays visible

2017-03-25 Thread Vadim Peretokin
Okay, we misused an icon, but as far as the users are concerned, the functionality before worked OK, the functionality before does not work OK. Let's replace it with one of those expand/collapse icons then, but the feedback is clear, the old behaviour needs to come back. There's no real reason to

[Mudlet-makers] [Bug 1675988] Re: 3.0 regression: search field no longer stays visible

2017-03-25 Thread Vadim Peretokin
There were two ways to understand the situation - it was either a bug or a misused icon - in this case it was the latter, let's bring the behaviour back and change the button's icon. -- You received this bug notification because you are a member of Mudlet Makers, which is subscribed to Mudlet.

[Mudlet-makers] [Bug 1675988] Re: 3.0 regression: search field no longer stays visible

2017-03-25 Thread Stephen Lyons
Humm, I remember this, commit-10649019416655df3e6499d83862b09e88f803ed {2016-02-18 19:34:01} The QWidget then called "mpSearchArea" (but renamed there to widget_searchArea") was defined in the trigger_editor.ui file and was the container for all the search stuff, including the QComboBox that was

[Mudlet-makers] [Bug 1675988] Re: 3.0 regression: search field no longer stays visible

2017-03-25 Thread Vadim Peretokin
** Summary changed: - Search field no longer stays visible + 3.0 regression: search field no longer stays visible -- You received this bug notification because you are a member of Mudlet Makers, which is subscribed to Mudlet. https://bugs.launchpad.net/bugs/1675988 Title: 3.0 regression: