[Mutopia-discuss] spurious git diff
Hi all I think that a good practice to ancourage and ease the review of updates is splitting a pull request in at least two commits: one for the initial convert-ly and the second for the manual changes. I think it may be added to the wiki page: https://github.com/chrissawer/The-Mutopia-Project/wiki/Updating-Lilypond-files-for-the-Mutopia-Project I have a question: do you know why git diff after convert-ly doesn't show a proper diff line by line? I've already read a complain about this from Keith on lilypond-user, pointing to this commit: https://github.com/chrissawer/The-Mutopia-Project/commit/81a588f5d16a3bcb4110bd1e8197dbdc5a08137e If I add the file to a new git repository, the 'git diff' of the updated file is correct. What's wrong with the main repository? It's not a big deal, it means only that the actual changes made by convert-ly won't be visible. But still I want to understand why it happens. Thanks Federico ___ Mutopia-discuss mailing list Mutopia-discuss@mutopiaproject.org http://lists.bcn.mythic-beasts.com/mailman/listinfo/mutopia-discuss
Re: [Mutopia-discuss] spurious git diff
Federico Bruni f...@inventati.org writes: Hi all I think that a good practice to ancourage and ease the review of updates is splitting a pull request in at least two commits: one for the initial convert-ly and the second for the manual changes. I think it may be added to the wiki page: https://github.com/chrissawer/The-Mutopia-Project/wiki/Updating-Lilypond-files-for-the-Mutopia-Project I have a question: do you know why git diff after convert-ly doesn't show a proper diff line by line? I've already read a complain about this from Keith on lilypond-user, pointing to this commit: https://github.com/chrissawer/The-Mutopia-Project/commit/81a588f5d16a3bcb4110bd1e8197dbdc5a08137e Uh, different file names _with_ changed content and without options detecting more than renames on unchanged blobs? -- David Kastrup ___ Mutopia-discuss mailing list Mutopia-discuss@mutopiaproject.org http://lists.bcn.mythic-beasts.com/mailman/listinfo/mutopia-discuss
Re: [Mutopia-discuss] spurious git diff
2014-02-22 16:46 GMT+01:00 Federico Bruni f...@inventati.org: I have a question: do you know why git diff after convert-ly doesn't show a proper diff line by line? I've already read a complain about this from Keith on lilypond-user, pointing to this commit: https://github.com/chrissawer/The-Mutopia-Project/commit/81a588f5d16a3bcb4110bd1e8197dbdc5a08137e If I add the file to a new git repository, the 'git diff' of the updated file is correct. What's wrong with the main repository? There are some different 'diff algorithms' that produce very different output, see git diff --help Just a thought. -- Francisco Vila. Badajoz (Spain) www.paconet.org , www.csmbadajoz.com ___ Mutopia-discuss mailing list Mutopia-discuss@mutopiaproject.org http://lists.bcn.mythic-beasts.com/mailman/listinfo/mutopia-discuss
