Re: [Mutopia-discuss] reviewing pull requests in github
Il giorno ven 5 dic 2014 alle 18:36, Federico Bruni f...@inventati.org ha scritto: Perhaps it's better using 'git format-patch' in case the contributor approves it and what to apply to his branch? I don't know if the patch generated with the command above can be applied with 'git am'. sorry, typo: ... and want to apply to... ___ Mutopia-discuss mailing list Mutopia-discuss@mutopiaproject.org http://lists.bcn.mythic-beasts.com/mailman/listinfo/mutopia-discuss
Re: [Mutopia-discuss] reviewing pull requests in github
Ah, so right. My apologies for not doing deeper research. I'll take a more complete look later today. On Thu, Dec 4, 2014 at 3:12 AM, Federico Bruni f...@inventati.org wrote: Il giorno gio 4 dic 2014 alle 8:00, Glen Larsen glenl@gmail.com ha scritto: These instructions are modifying an inactive pull request. Looking at the first section about modifying an *active* pull request locally it mentions following commands given at the bottom of a pull request. Right, but only collaborators can merge a pull request through github. On the bottom of any pull request I can see only: This pull request can be automatically merged by project collaborators. Only those with write access to this repository can merge pull requests. ___ Mutopia-discuss mailing list Mutopia-discuss@mutopiaproject.org http://lists.bcn.mythic-beasts.com/mailman/listinfo/mutopia-discuss
Re: [Mutopia-discuss] reviewing pull requests in github
Il giorno mer 3 dic 2014 alle 4:24, Javier Ruiz-Alma jav...@ruiz-alma.com ha scritto: Having a link to this guide would've made things easier for the few times I've copy/pasted code to compile some else's pull-requests. This doesn't happen often, though, so maybe you can create a new wiki page for advanced topics. Ok, I'll add it in the afternoon. Is it possible to also submit changes to someone else's open pull-request via github? If so, add a link to this too. Speaking for myself: I'd be lost on how to process a change request to one of my open PR's thru github. Changing and updating your own pull request is very easy. You just have to work on the same branch used for that specific pull request (that's why using a different branch from master is highly recommended in github, unless you know that you are going to merge it immediately). You add a commit to that branch and push it to your remote/branch; the pull request will be updated automatically. I don't think it's possible to submit changes to someone else's open pull request. You can upload the .patch file of your changes in the comments of the pull request, if you want the author of the PR to see your ideas. Or you can copy his branch in your repository and send a new PR, if you want to take up his work. ___ Mutopia-discuss mailing list Mutopia-discuss@mutopiaproject.org http://lists.bcn.mythic-beasts.com/mailman/listinfo/mutopia-discuss
Re: [Mutopia-discuss] reviewing pull requests in github
Il giorno mer 3 dic 2014 alle 10:23, Federico Bruni f...@inventati.org ha scritto: I don't think it's possible to submit changes to someone else's open pull request. You can upload the .patch file of your changes in the comments of the pull request, if you want the author of the PR to see your ideas. Or you can copy his branch in your repository and send a new PR, if you want to take up his work. And of course the full commit history, including commits of the first author, is present. You can see an example of a patch taken over by a new developer here: https://github.com/tomchristie/mkdocs/pull/222/commits He created a new pull request.. ___ Mutopia-discuss mailing list Mutopia-discuss@mutopiaproject.org http://lists.bcn.mythic-beasts.com/mailman/listinfo/mutopia-discuss
Re: [Mutopia-discuss] reviewing pull requests in github
Hi Federico, Having a link to this guide would've made things easier for the few times I've copy/pasted code to compile some else's pull-requests. This doesn't happen often, though, so maybe you can create a new wiki page for advanced topics.Is it possible to also submit changes to someone else's open pull-request via github? If so, add a link to this too. Speaking for myself: I'd be lost on how to process a change request to one of my open PR's thru github. I'm open to the next round of updates from Glenupdating Mutopia code sounds like a great plan for the Christmas time off...season of giving :) Javier On Tuesday, December 2, 2014 2:44 PM, Federico Bruni f...@inventati.org wrote: Hi all I'm reading this guide:https://help.github.com/articles/checking-out-pull-requests-locally/ I see that I can easily checkout the branch submitted through a pull request with this command: git fetch origin pull/ID/head:BRANCHNAMEgit checkout BRANCHNAME Now, if the author of the pull request add one or more commits, what's the best way to update it to the last commit?If I repeat the fetch above I get this error: fatal: Refusing to fetch into current branch refs/heads/search of non-bare repository The simple (stupid) solution I found is deleting the branch so I can repeat the two commands above without any problem. But I'm sure that there's something better.Mmmmh, I think I found it. If I checkout master again and run the fetch again it works.I guess that I'm missing what the fetch does. Anyway, do you think it's worth adding a small page in the wiki about reviewing patches? CheersFederico PS For Glen and Javier: what about another round of updates? Or some focus to close the Phase 3 milestone?I got a bit stuck on writing a piece from scratch. But during Christmas I might have some time to get some things done. ___ Mutopia-discuss mailing list Mutopia-discuss@mutopiaproject.org http://lists.bcn.mythic-beasts.com/mailman/listinfo/mutopia-discuss ___ Mutopia-discuss mailing list Mutopia-discuss@mutopiaproject.org http://lists.bcn.mythic-beasts.com/mailman/listinfo/mutopia-discuss
