Re: version.h rebuild change in stable

2019-06-05 Thread Derek Martin
On Sun, Jun 02, 2019 at 09:03:55AM +1000, Cameron Simpson wrote: > >I'm not a Makefile person myself. My "fix" added the version.sh > >prerequisite and appended to the version.h explicitly just to > >match the target below, reldate.h. > > > >If there is something to be gained by using the

Re: version.h rebuild change in stable

2019-06-01 Thread Vincent Lefevre
On 2019-06-02 08:31:01 +1000, Cameron Simpson wrote: > On 01Jun2019 14:16, vincent lefevre wrote: > > On 2019-06-01 16:36:38 +1000, Cameron Simpson wrote: > > > I'm an opinionated make user. Can you explain why you want the > > > "FORCE" > > > target at all? > > > > The goal is to make sure that

Re: version.h rebuild change in stable

2019-06-01 Thread Cameron Simpson
On 01Jun2019 07:18, Kevin J. McCarthy wrote: On Sat, Jun 01, 2019 at 04:36:38PM +1000, Cameron Simpson wrote: If I were writing the conjectured goal above I'd probably do this: mutt_version='#define MUTT_VERSION "'`sh "$(srcdir)/version.sh`'"' version_h=`[ -s version.h ] && cat version.h` [

Re: version.h rebuild change in stable

2019-06-01 Thread Cameron Simpson
On 01Jun2019 14:16, vincent lefevre wrote: On 2019-06-01 16:36:38 +1000, Cameron Simpson wrote: I'm an opinionated make user. Can you explain why you want the "FORCE" target at all? The goal is to make sure that version.h is up-to-date after an update such as "git pull". Ah, where the

Re: version.h rebuild change in stable

2019-06-01 Thread Kevin J. McCarthy
On Sat, Jun 01, 2019 at 04:36:38PM +1000, Cameron Simpson wrote: If I were writing the conjectured goal above I'd probably do this: mutt_version='#define MUTT_VERSION "'`sh "$(srcdir)/version.sh`'"' version_h=`[ -s version.h ] && cat version.h` [ "$$mutt_version" = "$$version_h" ] || echo

Re: version.h rebuild change in stable

2019-06-01 Thread Kevin J. McCarthy
On Sat, Jun 01, 2019 at 02:16:24PM +0200, Vincent Lefevre wrote: On 31May2019 17:36, Kevin J. McCarthy wrote: On Fri, May 31, 2019 at 11:19:27PM +0200, Vincent Lefevre wrote: How about using AM_CONDITIONAL in configure.ac, setting a variable GNU_MAKE when GNU Make is used (based on "make

Re: version.h rebuild change in stable

2019-06-01 Thread Vincent Lefevre
On 2019-06-01 16:36:38 +1000, Cameron Simpson wrote: > On 31May2019 17:36, Kevin J. McCarthy wrote: > > On Fri, May 31, 2019 at 11:19:27PM +0200, Vincent Lefevre wrote: > > > On 2019-05-31 09:37:02 -0700, Kevin J. McCarthy wrote: > > > > Of course, if anyone has an idea how to do this in a way

Re: version.h rebuild change in stable

2019-06-01 Thread Cameron Simpson
On 31May2019 17:36, Kevin J. McCarthy wrote: On Fri, May 31, 2019 at 11:19:27PM +0200, Vincent Lefevre wrote: On 2019-05-31 09:37:02 -0700, Kevin J. McCarthy wrote: Of course, if anyone has an idea how to do this in a way that works portably, we can revisit. But for now I consider their

Re: version.h rebuild change in stable

2019-05-31 Thread Kevin J. McCarthy
On Fri, May 31, 2019 at 11:19:27PM +0200, Vincent Lefevre wrote: On 2019-05-31 09:37:02 -0700, Kevin J. McCarthy wrote: Of course, if anyone has an idea how to do this in a way that works portably, we can revisit. But for now I consider their build issues more important than the minor

Re: version.h rebuild change in stable

2019-05-31 Thread Vincent Lefevre
On 2019-05-31 09:37:02 -0700, Kevin J. McCarthy wrote: > Of course, if anyone has an idea how to do this in a way that works > portably, we can revisit. But for now I consider their build issues more > important than the minor convenience for developers. How about using AM_CONDITIONAL in