Re: [Mutt] #3901: A canceled jump to message returns to index instead of staying in pager

[Mutt]

#3901: A canceled jump to message returns to index instead of staying in pager
-+--
  Reporter:  vinc17  |  Owner:  mutt-dev
  Type:  defect  | Status:  new
  Priority:  minor   |  Milestone:
 Component:  user interface  |Version:  1.7.1
Resolution:  |   Keywords:
-+--

Comment (by kevin8t8):

 I'm attaching a couple patches.  The v1 only stays in the pager if you
 abort the prompt.  If you enter an invalid message, it will return to the
 index.

 The v2 always stays in the pager.  The problem is that the error message
 may get overwritten as part of rendering the output (e.g. html autoview
 output).

 I prefer the first patch, but wanted to give you a choice.

--
Ticket URL: 
Mutt 
The Mutt mail user agent

Re: [Mutt] #3899: mutt_ssl's interactive_check_cert() has several issues

[Mutt]

#3899: mutt_ssl's interactive_check_cert() has several issues
---+--
  Reporter:  kevin8t8  |  Owner:  mutt-dev
  Type:  defect| Status:  new
  Priority:  major |  Milestone:
 Component:  crypto|Version:
Resolution:|   Keywords:
---+--

Comment (by kevin8t8):

 Funnily enough I just asked Damien not to use that construct, because
 we're not generally using it in mutt.  Now that I look closer, I do see a
 couple places in init.c and keymap.c, but there is still something I don't
 like about it...

 A problem is the menu structure is fragile too.  It currently hard codes
 the max size and pre-allocates it.  So if you increase the number of
 parts, you have to remember to increase the max size right now.  I didn't
 want to change too much in the function, so I took the easy way out.

 Perhaps a compromise is to set
   menu->max = numberof(parts) * 2 + 9;
 for now.

--
Ticket URL: 
Mutt 
The Mutt mail user agent

[Mutt] #3901: A canceled jump to message returns to index instead of staying in pager

[Mutt]

#3901: A canceled jump to message returns to index instead of staying in pager
+--
 Reporter:  vinc17  |  Owner:  mutt-dev
 Type:  defect  | Status:  new
 Priority:  minor   |  Milestone:
Component:  user interface  |Version:  1.7.1
 Keywords:  |
+--
 When I type a digit (e.g. by mistake) from the pager then cancel the "Jump
 to message:" with Ctrl-G, Mutt returns to the index instead of staying in
 the pager.

--
Ticket URL: 
Mutt 
The Mutt mail user agent

Re: [Mutt] #3899: mutt_ssl's interactive_check_cert() has several issues

[Mutt]

#3899: mutt_ssl's interactive_check_cert() has several issues
---+--
  Reporter:  kevin8t8  |  Owner:  mutt-dev
  Type:  defect| Status:  new
  Priority:  major |  Milestone:
 Component:  crypto|Version:
Resolution:|   Keywords:
---+--

Comment (by vinc17):

 I think that the number of fields in the two loops
 {{{for (i = 0; i < 7; i++)}}}
 should not be hardcoded, but automatically obtained from the real number
 of fields, with something like:
 {{{
 #define numberof(x)  (sizeof (x) / sizeof ((x)[0]))

 for (i = 0; i < numberof(parts); i++)
 }}}

--
Ticket URL: 
Mutt 
The Mutt mail user agent