Re: [Mzmine-devel] , MZmineModule interface update

2012-02-01 Thread Tomas Pluskal
Hi Chris, In the new design it is not necessary for the module to clone the parameter set, because MZmine will clone it automatically after the user clicks the OK button of the parameter setup dialog. I mentioned this in the MZmineProcessingModule comments ("The ParameterSet has already been cl

Re: [Mzmine-devel] , MZmineModule interface update

2012-02-01 Thread Pudney Chris (ext) GBJH
G'day, This is a great improvement. A related question. I often see code like the following new FooTask(..., parameters.clone()); It shouldn't be necessary to clone the parameter set should it? In fact, I think it's up to FooTask to decide how it deals with the ParameterSet it is passed. Ma

[Mzmine-devel] MZmineModule interface update

2012-01-29 Thread Tomas Pluskal
Hi all, I found an annoying bug in MZmine (up to last version 2.5). If you create a batch with two steps of the same mass detector (e.g. Centroid), then the instance of the parameter set of this mass detector is shared for both steps and it is not possible to set different parameters to them. T