The proposal to merge ~xavpaice/hw-health-charm:fix_tests into
hw-health-charm:master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363813
--
Your team Nagios Charm developers is
Review: Approve
lgtm
--
https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363813
Your team Nagios Charm developers is subscribed to branch
hw-health-charm:master.
--
Mailing list: https://launchpad.net/~nagios-charmers
Post to :
The proposal to merge ~xavpaice/hw-health-charm:fix_tests into
hw-health-charm:master has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363758
--
Your team Nagios Charm developers is
Thanks Peter, I've updated as suggested.
--
https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363813
Your team Nagios Charm developers is subscribed to branch
hw-health-charm:master.
--
Mailing list: https://launchpad.net/~nagios-charmers
Post to :
Xav Paice has proposed merging ~xavpaice/hw-health-charm:fix_tests into
hw-health-charm:master.
Requested reviews:
Peter Sabaini (peter-sabaini)
For more details, see:
https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363813
--
Your team Nagios Charm developers
Review: Needs Fixing
Hey, some inline comments
Diff comments:
> diff --git a/Makefile b/Makefile
> index d1043f4..89cd0ce 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -21,7 +21,7 @@ help:
>
> lint:
> @echo "Running flake8"
> - @flake8 --max-line-length=80 ./src
> + @flake8
6 matches
Mail list logo
