Re: [Nagios-charmers] [Merge] ~giulio.cervera/nagios-charm:bug/1860669 into nagios-charm:master

2020-02-16 Thread Xav Paice
The docs are pretty clear, this is an option for the main config file only, and given the age of Nagios 3 it's unlikely to be something that'll change any time soon. Since we're in the middle of a release, I'll postpone this till after the release and target for the next one. --

[Nagios-charmers] [Merge] ~aieri/nagios-charm:bug/1843863 into nagios-charm:master

2020-02-16 Thread Canonical IS Mergebot
The proposal to merge ~aieri/nagios-charm:bug/1843863 into nagios-charm:master has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~aieri/nagios-charm/+git/nagios-charm/+merge/378160 -- Your team Nagios Charm developers is subscribed to

Re: [Nagios-charmers] [Merge] ~aieri/nagios-charm:bug/1843863 into nagios-charm:master

2020-02-16 Thread Canonical IS Mergebot
Failed to merge change (unable to merge source repository due to conflicts), setting status to needs review. -- https://code.launchpad.net/~aieri/nagios-charm/+git/nagios-charm/+merge/378160 Your team Nagios Charm developers is subscribed to branch nagios-charm:master. -- Mailing list:

[Nagios-charmers] [Merge] ~aieri/nagios-charm:bug/1843863 into nagios-charm:master

2020-02-16 Thread Xav Paice
The proposal to merge ~aieri/nagios-charm:bug/1843863 into nagios-charm:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~aieri/nagios-charm/+git/nagios-charm/+merge/378160 -- Your team Nagios Charm developers is subscribed to

Re: [Nagios-charmers] [Merge] ~aieri/nagios-charm:bug/1843863 into nagios-charm:master

2020-02-16 Thread Xav Paice
Review: Approve Tested, lgtm. May need a rebase. -- https://code.launchpad.net/~aieri/nagios-charm/+git/nagios-charm/+merge/378160 Your team Nagios Charm developers is subscribed to branch nagios-charm:master. -- Mailing list: https://launchpad.net/~nagios-charmers Post to :

[Nagios-charmers] [Bug 1860669] Re: add support for enabling broker modules

2020-02-16 Thread Xav Paice
** Merge proposal linked: https://code.launchpad.net/~giulio.cervera/nagios-charm/+git/nagios-charm/+merge/378449 -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1860669 Title:

Re: [Nagios-charmers] [Merge] ~giulio.cervera/nagios-charm:bug/1860669 into nagios-charm:master

2020-02-16 Thread Xav Paice
Thanks for the contribution. I'm concerned that we have the code to enable the module, but nothing to actually deploy the module itself, meaning that this change alone doesn't achieve much. Adding the module would be ideally put into a subordinate charm, along with dropping a fresh config

Re: [Nagios-charmers] [Merge] ~aggkolaitis/nagios-charm:extra_contacts into nagios-charm:master

2020-02-16 Thread Xav Paice
I'd prefer to see a subordinate charm for this kind of option, adding the packages and package config, plus dropping an extra .cfg in the Nagios config dirs, to allow the extra contact. However, given that the charm includes contacts-cfg.tmpl and that templates the file which defines the

[Nagios-charmers] [Bug 1827006] Re: Add more notification groups

2020-02-16 Thread Xav Paice
Redirect to nagios-charm (not package) ** Package changed: nagios (Juju Charms Collection) => nagios-charm ** Changed in: nagios-charm Status: New => Triaged ** Changed in: nagios-charm Importance: Undecided => Wishlist -- You received this bug notification because you are a member

[Nagios-charmers] [Bug 1827006] [NEW] Add more notification groups

2020-02-16 Thread Launchpad Bug Tracker
You have been subscribed to a public bug: Nagios charm support the addition of notification groups only for pagerduty. It is necessary to add a more generic option to add extra notification groups in order to allow integration with various external utilities for notifications. ** Affects:

[Nagios-charmers] [Merge] ~aggkolaitis/nagios-charm:change_nagios_gui_username into nagios-charm:master

2020-02-16 Thread noreply
The proposal to merge ~aggkolaitis/nagios-charm:change_nagios_gui_username into nagios-charm:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~aggkolaitis/nagios-charm/+git/nagios-charm/+merge/374089 -- Your team Nagios Charm developers

Re: [Nagios-charmers] [Merge] ~aggkolaitis/nagios-charm:change_nagios_gui_username into nagios-charm:master

2020-02-16 Thread Canonical IS Mergebot
Change successfully merged at revision e3e2f757faa38e825a0cbf38e90c0f1ce876679e -- https://code.launchpad.net/~aggkolaitis/nagios-charm/+git/nagios-charm/+merge/374089 Your team Nagios Charm developers is requested to review the proposed merge of

Re: [Nagios-charmers] [Merge] ~woutervb/nagios-charm:master into nagios-charm:reactive

2020-02-16 Thread Xav Paice
Review: Needs Fixing Needs a review and update for the changes made to master since this was written, this is a massive rewrite and necessary work, but needs some focus from our engineering to complete. -- https://code.launchpad.net/~woutervb/nagios-charm/+git/nagios-charm/+merge/364360 Your

[Nagios-charmers] [Merge] ~aieri/nagios-charm:bug/1811997 into nagios-charm:master

2020-02-16 Thread noreply
The proposal to merge ~aieri/nagios-charm:bug/1811997 into nagios-charm:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~aieri/nagios-charm/+git/nagios-charm/+merge/378116 -- Your team Nagios Charm developers is subscribed to branch

Re: [Nagios-charmers] [Merge] ~aieri/nagios-charm:bug/1811997 into nagios-charm:master

2020-02-16 Thread Xav Paice
Review: Approve Trivial change, will merge without Canonical IS Reviewers input (been a couple of weeks waiting now). -- https://code.launchpad.net/~aieri/nagios-charm/+git/nagios-charm/+merge/378116 Your team Nagios Charm developers is subscribed to branch nagios-charm:master. -- Mailing