[Nagios-charmers] [Merge] ~xavpaice/charm-nagios:bug/1819537 into charm-nagios:master

2020-10-01 Thread James Hebden
The proposal to merge ~xavpaice/charm-nagios:bug/1819537 into charm-nagios:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~xavpaice/charm-nagios/+git/nagios-charm/+merge/391667 -- Your team Nagios Charm developers is subscribed

Re: [Nagios-charmers] [Merge] ~xavpaice/charm-nagios:bug/1819537 into charm-nagios:master

2020-10-01 Thread Joe Guo
Review: Approve LGTM, +1. -- https://code.launchpad.net/~xavpaice/charm-nagios/+git/nagios-charm/+merge/391667 Your team Nagios Charm developers is subscribed to branch charm-nagios:master. -- Mailing list: https://launchpad.net/~nagios-charmers Post to :

Re: [Nagios-charmers] [Merge] ~xavpaice/charm-nagios:bug/1819537 into charm-nagios:master

2020-10-01 Thread Xav Paice
Ah... the functest has enable livestatus enabled at install, and hooks/install does the package install for that. -- https://code.launchpad.net/~xavpaice/charm-nagios/+git/nagios-charm/+merge/391667 Your team Nagios Charm developers is subscribed to branch charm-nagios:master. -- Mailing list:

Re: [Nagios-charmers] [Merge] ~xavpaice/charm-nagios:bug/1819537 into charm-nagios:master

2020-10-01 Thread Xav Paice
Thanks for that, have updated and am re-running functional testing now. I'm concerned that a glaring hole like not installing the package didn't get pulled up by functests, might need to add a bug for that. -- https://code.launchpad.net/~xavpaice/charm-nagios/+git/nagios-charm/+merge/391667